Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-26 Thread Tom Davis
On Wed, Jan 26, 2011 at 1:39 PM, wrote: > On 06:28 pm, gl...@twistedmatrix.com wrote: > > > >On Jan 25, 2011, at 6:09 PM, Kevin Horn wrote: > >>Well, I can update the summary, but not the description, which is the > >>really bad part. > > > >The description _is_ mutable, just only by certain magi

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-26 Thread exarkun
On 06:28 pm, gl...@twistedmatrix.com wrote: > >On Jan 25, 2011, at 6:09 PM, Kevin Horn wrote: >>Well, I can update the summary, but not the description, which is the >>really bad part. > >The description _is_ mutable, just only by certain magical people. >(For the purpose of spam protection). > >

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-26 Thread Glyph Lefkowitz
On Jan 25, 2011, at 6:09 PM, Kevin Horn wrote: > Well, I can update the summary, but not the description, which is the really > bad part. The description _is_ mutable, just only by certain magical people. (For the purpose of spam protection). For now, please feel free to attach a comment to

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-25 Thread Kevin Horn
On Tue, Jan 25, 2011 at 1:53 PM, wrote: > On 07:23 pm, kevin.h...@gmail.com wrote: > >On Tue, Jan 25, 2011 at 11:54 AM, Jason J. W. Williams < > >jasonjwwilli...@gmail.com> wrote: > >>Hi Y'all, > >Howdy, Jason! > >>Certain servers (notably Hacker News) break HTTPClient because they > >>use LF > >

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-25 Thread Glyph Lefkowitz
On Jan 25, 2011, at 3:03 PM, Jason J. W. Williams wrote: >>> >>> Can we go ahead and close 2842 in favor of 4814? We have too many old >>> tickets floating around... >> >> #4814 is already closed. If the #2842 description is confusing, then >> feel free to update it to be more clear. :) >> >

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-25 Thread Jason J. W. Williams
>> >>Can we go ahead and close 2842 in favor of 4814?  We have too many old >>tickets floating around... > > #4814 is already closed.  If the #2842 description is confusing, then > feel free to update it to be more clear. :) > > We don't close old tickets as duplicates of new tickets, though.  That

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-25 Thread exarkun
On 07:23 pm, kevin.h...@gmail.com wrote: >On Tue, Jan 25, 2011 at 11:54 AM, Jason J. W. Williams < >jasonjwwilli...@gmail.com> wrote: >>Hi Y'all, >Howdy, Jason! >>Certain servers (notably Hacker News) break HTTPClient because they >>use LF >>instead of CRLF to terminate header lines. I've uploaded

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-25 Thread Tom Davis
On Tue, Jan 25, 2011 at 2:23 PM, Kevin Horn wrote: > On Tue, Jan 25, 2011 at 11:54 AM, Jason J. W. Williams < > jasonjwwilli...@gmail.com> wrote: > >> Hi Y'all, >> >> > Howdy, Jason! > > > >> Certain servers (notably Hacker News) break HTTPClient because they use LF >> instead of CRLF to terminat

Re: [Twisted-Python] HTTPClient handling LF only servers

2011-01-25 Thread Kevin Horn
On Tue, Jan 25, 2011 at 11:54 AM, Jason J. W. Williams < jasonjwwilli...@gmail.com> wrote: > Hi Y'all, > > Howdy, Jason! > Certain servers (notably Hacker News) break HTTPClient because they use LF > instead of CRLF to terminate header lines. I've uploaded a patch with tests > to ticket 4814 (m

[Twisted-Python] HTTPClient handling LF only servers

2011-01-25 Thread Jason J. W. Williams
Hi Y'all, Certain servers (notably Hacker News) break HTTPClient because they use LF instead of CRLF to terminate header lines. I've uploaded a patch with tests to ticket 4814 (merged into ticket 2842). I'd appreciate a review and some discussion about integrating it. -J Sent via iPhone Is