Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-10 Thread Jean-Paul Calderone
On Fri, Mar 10, 2017 at 3:26 AM, Cory Benfield wrote: > > On 9 Mar 2017, at 22:01, Jean-Paul Calderone > wrote: > > Run the server with TLSMemoryBIOProtocol and use the transport's > pauseProducing method before you attempt the shutdown? > > Jean-Paul > > > Yup, that will work. Similarly, having

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-10 Thread Cory Benfield
> On 9 Mar 2017, at 22:01, Jean-Paul Calderone > wrote: > > Run the server with TLSMemoryBIOProtocol and use the transport's > pauseProducing method before you attempt the shutdown? > > Jean-Paul Yup, that will work. Similarly, having two TLSMemoryBIOProtocols communicating together and pau

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-09 Thread Jean-Paul Calderone
On Thu, Mar 9, 2017 at 3:40 PM, Adi Roiban wrote: > On 7 March 2017 at 09:31, Cory Benfield wrote: > > > > On 6 Mar 2017, at 09:05, Adi Roiban wrote: > > > > I am not sure about which code are we talking here. > > The specific HTTP11ClientProtocol which will fix only the HTTP client > > part or

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-09 Thread Adi Roiban
On 7 March 2017 at 09:31, Cory Benfield wrote: > > On 6 Mar 2017, at 09:05, Adi Roiban wrote: > > I am not sure about which code are we talking here. > The specific HTTP11ClientProtocol which will fix only the HTTP client > part or the generic TLSMemoryBIOProtocol code which might fix any TLS > c

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-07 Thread Cory Benfield
> On 6 Mar 2017, at 09:05, Adi Roiban wrote: > > I am not sure about which code are we talking here. > The specific HTTP11ClientProtocol which will fix only the HTTP client > part or the generic TLSMemoryBIOProtocol code which might fix any TLS > connection? I’m talking about the fact that call

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-06 Thread Adi Roiban
On 6 March 2017 at 08:17, Cory Benfield wrote: > > On 5 Mar 2017, at 14:25, Tristan Seligmann wrote: > > On Sun, 5 Mar 2017 at 15:36 Adi Roiban wrote: >> >> I have observed this while running some end to end tests in which the >> pool.closeCachedConnections() deferred was not called, even after

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-06 Thread Cory Benfield
> On 5 Mar 2017, at 14:25, Tristan Seligmann wrote: > > On Sun, 5 Mar 2017 at 15:36 Adi Roiban > wrote: > I have observed this while running some end to end tests in which the > pool.closeCachedConnections() deferred was not called, even after a > generous amount of secon

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-05 Thread Paweł Miech
> It looks like when connected to some HTTPS servers, the TLS connection is not successfully closed. > But with Office365 sharepoint.com sites the TLS shutdown is not completed. > Has anyone else observed this behaviour ? I observed something simillar a while ago, there was bug report created for

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-05 Thread Glyph Lefkowitz
> On Mar 5, 2017, at 6:25 AM, Tristan Seligmann wrote: > > I think this code should either call abortConnection directly, or set a timer > which will abort the connection after a little while if a clean shutdown from > loseConnection has not completed yet. I' > Agreed - did someone file a bu

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-05 Thread Tristan Seligmann
On Sun, 5 Mar 2017 at 15:36 Adi Roiban wrote: > I have observed this while running some end to end tests in which the > pool.closeCachedConnections() deferred was not called, even after a > generous amount of seconds :) > The code to abort an HTTP client connection is here: https://github.com/t

[Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

2017-03-05 Thread Adi Roiban
Hi, It looks like when connected to some HTTPS servers, the TLS connection is not successfully closed. With sites like google.com, the connection is successfully closed. But with Office365 sharepoint.com sites the TLS shutdown is not completed. Has anyone else observed this behaviour ? I have