Re: [Twisted-Python] Development Process Failure

2009-02-23 Thread Jonathan Lange
On Tue, Feb 24, 2009 at 10:07 AM, wrote: > > On 09:39 pm, j...@mumak.net wrote: >> >> Given Trac, maybe numbering review points + being direct about the >> change would make it easier to inspect replies, which must in turn >> mention the numbered points. For this to work, the reviewer would have

Re: [Twisted-Python] Development Process Failure

2009-02-23 Thread glyph
On 09:39 pm, j...@mumak.net wrote: Given Trac, maybe numbering review points + being direct about the change would make it easier to inspect replies, which must in turn mention the numbered points. For this to work, the reviewer would have to clearly distinguish between "I would like you to chan

Re: [Twisted-Python] Development Process Failure

2009-02-23 Thread glyph
On 03:05 pm, exar...@divmod.com wrote: One possibility is to explicitly adjust the review guidelines and direct reviewers always to verify that previous review points have actually been addressed. What ideas do other people have? For starters, I think we should have a division between proces

Re: [Twisted-Python] Development Process Failure

2009-02-23 Thread Jonathan Lange
On Tue, Feb 24, 2009 at 2:05 AM, Jean-Paul Calderone wrote: > One possibility is to explicitly adjust the review guidelines and direct > reviewers always to verify that previous review points have actually been > addressed. What ideas do other people have? > In the Launchpad team, we replying to

[Twisted-Python] Development Process Failure

2009-02-23 Thread Jean-Paul Calderone
Hey all, Recently I've been bothered by a systematic shortcoming of the Twisted development process. When changes are made in response to a review, they are generally made in a way which is difficult to inspect. The value of a review is lost if the valid points raised by it are not addressed be