Re: [Twisted-Python] Code review comment for http.py

2019-10-07 Thread Glyph
> On Oct 7, 2019, at 3:36 AM, Scott, Barry wrote: > > On Saturday, 5 October 2019 04:48:03 BST Glyph wrote: >>> On Oct 4, 2019, at 4:26 AM, Scott, Barry >>> wrote: >>> >>> I see that there are duplicate lines in http.py in >>> _GenericHTTPChannelProtocol.dataReceived() >>> >>> Notice that ar

Re: [Twisted-Python] Code review comment for http.py

2019-10-07 Thread Scott, Barry
On Saturday, 5 October 2019 04:48:03 BST Glyph wrote: > > On Oct 4, 2019, at 4:26 AM, Scott, Barry > > wrote: > > > > I see that there are duplicate lines in http.py in > > _GenericHTTPChannelProtocol.dataReceived() > > > > Notice that around line 2960 two calls to setTimeout(). > > > >

Re: [Twisted-Python] Code review comment for http.py

2019-10-04 Thread Glyph
> On Oct 4, 2019, at 4:26 AM, Scott, Barry wrote: > > I see that there are duplicate lines in http.py in > _GenericHTTPChannelProtocol.dataReceived() > > Notice that around line 2960 two calls to setTimeout(). > >networkProducer.unregisterProducer() > ># Cance

[Twisted-Python] Code review comment for http.py

2019-10-04 Thread Scott, Barry
I see that there are duplicate lines in http.py in _GenericHTTPChannelProtocol.dataReceived() Notice that around line 2960 two calls to setTimeout(). networkProducer.unregisterProducer() # Cancel the old channel's timeout. self._channel.setTimeout(