Re: [Twisted-Python] Bytes vs unicode in twisted.python.logfile's python3 porting

2013-10-30 Thread Laurens Van Houtven
Hi Glyph, On Wed, Oct 30, 2013 at 1:22 AM, Glyph wrote: > > The new logging branch (destined for review Real Soon Now) is a bit more > rigorous about sensible behavior with respect to encoding, so we can > tighten up this behavior and make it work in more cases without breaking > compatibility.

Re: [Twisted-Python] Bytes vs unicode in twisted.python.logfile's python3 porting

2013-10-29 Thread Glyph
On Oct 27, 2013, at 6:57 AM, Laurens Van Houtven <_...@lvh.io> wrote: > Hi JP, > > > On Sun, Oct 27, 2013 at 2:19 AM, wrote: > *Or*, it now occurs to me, just stick with the ASCII-only policy that's > already in place. I'd even say this is more correct since porting isn't > supposed to chan

Re: [Twisted-Python] Bytes vs unicode in twisted.python.logfile's python3 porting

2013-10-27 Thread Laurens Van Houtven
Hi JP, On Sun, Oct 27, 2013 at 2:19 AM, wrote: > *Or*, it now occurs to me, just stick with the ASCII-only policy that's > already in place. I'd even say this is more correct since porting isn't > supposed to change behavior. Leave support for some other codec for > another ticket (perhaps #9

Re: [Twisted-Python] Bytes vs unicode in twisted.python.logfile's python3 porting

2013-10-26 Thread exarkun
On 26 Oct, 09:49 pm, _...@lvh.io wrote: Hi everyone, I'm working on #6749 for porting t.p.logfile to python3. I'm dealing with some test failures, which you can see from the buildbot here: http://buildbot.twistedmatrix.com/builders/python-3.3-tests/builds/1602/steps/shell/logs/stdio I have

[Twisted-Python] Bytes vs unicode in twisted.python.logfile's python3 porting

2013-10-26 Thread Laurens Van Houtven
Hi everyone, I'm working on #6749 for porting t.p.logfile to python3. I'm dealing with some test failures, which you can see from the buildbot here: http://buildbot.twistedmatrix.com/builders/python-3.3-tests/builds/1602/steps/shell/logs/stdio I have pasted the relevant bit into a gist here: h