Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool - time to test!

On Oct 10, 2014, at 11:26 PM, Glyph wrote: > The ticket is in review now, and > the branch is . I just tested my threadpool statistics collection code against that branch, and it works perfectly! Thanks a lot for your effort in this branch. __

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

tails of WSGIResource, nor was I planning to. I’ve already had some code (in another project) break across versions of twisted because of that, and I don’t want it to happen again. > Thanks a bunch for helping us improve Twisted, Thank you for taking the time to write up your original post a

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

ttributes, but that would require touching implementation details of WSGIResource. I’m not sure which is worse. ~weykent ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] On testing things wrapping other things

On Sep 21, 2014, at 10:36 AM, Glyph wrote: > If anything I'd say that the problem with this code is that it's not a > public, documented interface. The clients of this library might want to test > it as well :). Ah! You are referring to both _wrap and _issueRequest here, right? That makes sen

[Twisted-Python] On testing things wrapping other things

tests ended up being harder to read and write, and seemed to rely on the exact implementation of the thing I was wrapping. Thanks in advance for any feedback on the matter, ~weykent ___ Twisted-Python mailing list Twisted-Python@twistedmat