Re: [Twisted-Python] code contribution/participation policy

2021-03-10 Thread Boris Epstein
Hello all, Thank you. Just submitted my first PR into the Twisted repo. Hopefully it is all good. Here's the relevant ticket: https://twistedmatrix.com/trac/ticket/9951 Cheers, Boris. On Mon, Sep 14, 2020 at 1:49 PM Glyph wrote: > > > On Sep 14, 2020, at 10:11 AM, Boris

Re: [Twisted-Python] code contribution/participation policy

2020-09-14 Thread Boris Epstein
Hello Craig, Thanks. So basically you just work on the main Git repo, not on a clone - and you do the pull directly, not submit a pull request? Boris. On Sat, Sep 5, 2020 at 2:19 PM Craig Rodrigues wrote: > > > On Sat, Sep 5, 2020 at 10:25 AM Boris Epstein > wrote: > >

Re: [Twisted-Python] code contribution/participation policy

2020-09-05 Thread Boris Epstein
Hello all, Thanks again for your help. OK, so I think I have taken the first step: https://twistedmatrix.com/trac/ticket/9951 Now how do I proceed? What is the convention for Git brach names, etc? Cheers, Boris. On Sat, Aug 29, 2020 at 9:39 AM Boris Epstein wrote: > Hi Glyph, > &g

Re: [Twisted-Python] code contribution/participation policy

2020-08-29 Thread Boris Epstein
e details in those documents, please read them > carefully... but overall, the process is (1) Find/make a ticket (on trac, > not github), (2) Make a github pull request, and (3) set the trac ticket up > to be reviewed. > > Happy hacking! > > Colin > > On Fri, Aug 21, 2020 a

[Twisted-Python] code contribution/participation policy

2020-08-21 Thread Boris Epstein
Hi all, I have started working with Twisted and found it to be a very powerful package. That said, some modules are not documented very thoroughly (big surprise in the world of software, right?) and I also found some questionable code, too. If I were to contribute fixes/improvements, what is the