Re: [Twisted-Python] Twisted trunk and klein?

> On Feb 11, 2021, at 2:09 PM, Glyph wrote: > > > >> On Feb 11, 2021, at 1:04 PM, Glyph > > wrote: >> >> >>> On Feb 11, 2021, at 11:41 AM, Wilfredo Sánchez Vega >> > wrote: >>> My concern here is that Twisted may have adde

Re: [Twisted-Python] Twisted trunk and klein?

> On Feb 11, 2021, at 1:04 PM, Glyph wrote: > > >> On Feb 11, 2021, at 11:41 AM, Wilfredo Sánchez Vega > > wrote: >> >>> My concern here is that Twisted may have added a dependency on requests, >>> and that dependency means that if you want IDNA==3.1, as Klein’

Re: [Twisted-Python] Twisted trunk and klein?

> On Feb 11, 2021, at 1:15 PM, Adi Roiban wrote: > > I guess that we can remove idna from setup.cfg TLS section in Twisted > Nope; we use it directly, in https://github.com/twisted/twisted/blob/7cf6c8bc320ac5fd96b4784f6feb932ea819856d/src/twisted/internet/_idna.py

Re: [Twisted-Python] Twisted trunk and klein?

On Thu, 11 Feb 2021 at 19:26, Wilfredo Sánchez Vega wrote: > On Feb 10, 2021, at 3:44 PM, Glyph wrote: > > > This isn't even a bug in Klein, it's an issue with a version pin in its > tox.ini: > https://github.com/twisted/klein/blob/6e7b37158dea2fe73180809803a872ed98143c6d/tox.ini#L36 > > > The c

Re: [Twisted-Python] Twisted trunk and klein?

> On Feb 11, 2021, at 11:41 AM, Wilfredo Sánchez Vega > wrote: > >> My concern here is that Twisted may have added a dependency on requests, >> and that dependency means that if you want IDNA==3.1, as Klein’s tox.ini >> does, that you aren’t allowed to. That seems weak; I’d say a bug. No?

Re: [Twisted-Python] Twisted trunk and klein?

> My concern here is that Twisted may have added a dependency on requests, > and that dependency means that if you want IDNA==3.1, as Klein’s tox.ini > does, that you aren’t allowed to. That seems weak; I’d say a bug. No? Note this is only cause when installing treq, so the issue seems to

Re: [Twisted-Python] Twisted trunk and klein?

On Feb 10, 2021, at 3:44 PM, Glyph wrote: > > This isn't even a bug in Klein, it's an issue with a version pin in its > tox.ini: > https://github.com/twisted/klein/blob/6e7b37158dea2fe73180809803a872ed98143c6d/tox.ini#L36 > >