Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

2021-02-10 Thread Craig Rodrigues
On Wed, Feb 10, 2021 at 2:57 PM Glyph wrote: > > > > On Feb 10, 2021, at 6:45 AM, Craig Rodrigues wrote: > > > > On Wednesday, February 10, 2021, Glyph wrote: >> >> >> >> On Feb 10, 2021, at 12:40 AM, Craig Rodrigues wrote: >> >> How will this patch change for people installing Twisted on Windo

Re: [Twisted-Python] Twisted trunk and klein?

2021-02-10 Thread Glyph
> On Feb 10, 2021, at 3:18 PM, Craig Rodrigues wrote: > > Hi, > > I quickly asked Wilfredo if Twisted trunk worked with Klein, and he mentioned > that he saw this dependency issue on the Twisted klein side when used > with Twisted trunk: > > The conflict is caused by: >The user requested

[Twisted-Python] Twisted trunk and klein?

2021-02-10 Thread Craig Rodrigues
Hi, I quickly asked Wilfredo if Twisted trunk worked with Klein, and he mentioned that he saw this dependency issue on the Twisted klein side when used with Twisted trunk: The conflict is caused by: The user requested idna==3.1 hyperlink 21.0.0 depends on idna>=2.5 requests 2.25.1 dep

Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

2021-02-10 Thread Glyph
> On Feb 10, 2021, at 6:45 AM, Craig Rodrigues wrote: > > > > On Wednesday, February 10, 2021, Glyph > wrote: > > >> On Feb 10, 2021, at 12:40 AM, Craig Rodrigues > > wrote: >> >> How will this patch change for people installi

Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

2021-02-10 Thread Craig Rodrigues
On Wednesday, February 10, 2021, Glyph wrote: > > > On Feb 10, 2021, at 12:40 AM, Craig Rodrigues > wrote: > > How will this patch change for people installing Twisted on Windows? > > Twisted is still used by a lot of users on Windows, and the IOCP Reactor is > still used on this platform. > > >

Re: [Twisted-Python] Getting ready to do a release of Twisted

2021-02-10 Thread Glyph
> On Feb 10, 2021, at 12:49 AM, Craig Rodrigues wrote: > > Thanks to review work by Tom Most, > I have modified and merged https://github.com/twisted/twisted/pull/1502 > > which addresses test failures encountered against Buildbot's regression sui

[Twisted-Python] Getting ready to do a release of Twisted

2021-02-10 Thread Craig Rodrigues
Thanks to review work by Tom Most, I have modified and merged https://github.com/twisted/twisted/pull/1502 which addresses test failures encountered against Buildbot's regression suite. I would like to proceed with doing a Twisted release. Does anyone have any PR's that they are working on that t

Re: [Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

2021-02-10 Thread Glyph
> On Feb 10, 2021, at 12:40 AM, Craig Rodrigues wrote: > > How will this patch change for people installing Twisted on Windows? > > Twisted is still used by a lot of users on Windows, and the IOCP Reactor is > still used on this platform. This line is what does the trick: https://github.com/

[Twisted-Python] Moving iocpsupport to an external package? Implications on Windows?

2021-02-10 Thread Craig Rodrigues
Looking at this PR: https://github.com/twisted/twisted/pull/1446 I see that iocpsupport was moved to a separate package, in order to make building wheels on Windows easier. Before this patch, I was prototyping building binary wheels on Windows of Twisted core, and I had it working. It looks lik