Re: [Twisted-Python] More Conch Questions

2020-11-30 Thread Colin Dunklau
On Mon, Nov 30, 2020 at 10:21 PM Robert DiFalco wrote: > Alright, it's a but in twisted. How do I report twisted bugs? Under > python3 service.name is bytes and not a string. > > > https://github.com/twisted/twisted/blob/trunk/src/twisted/conch/client/direct.py#L86 > https://twistedmatrix.com/tr

Re: [Twisted-Python] More Conch Questions

2020-11-30 Thread Robert DiFalco
Alright, it's a but in twisted. How do I report twisted bugs? Under python3 service.name is bytes and not a string. https://github.com/twisted/twisted/blob/trunk/src/twisted/conch/client/direct.py#L86 On Mon, Nov 30, 2020 at 4:00 PM Robert DiFalco wrote: > Ok, my solution is to re-write the con

Re: [Twisted-Python] More Conch Questions

2020-11-30 Thread Robert DiFalco
Ok, my solution is to re-write the connect function like this. Any issues with this approach? def connect(options, userAuthObject): d_connect = Deferred() d_authorized = Deferred() factory = SFTPClientFactory(d_connect, options, userAuthObject) def _connect_failed(*args, **kwargs

Re: [Twisted-Python] ClientFactory design

2020-11-30 Thread Peter Westlake
On Mon, 30 Nov 2020, at 13:38, Jean-Paul Calderone wrote: > On Mon, Nov 30, 2020 at 6:48 AM Peter Westlake > wrote: >> __ >> I'm studying an SSH client implementation using Conch, and was surprised to >> see that the ClientFactory subclass had a connect() method which calls >> connectTCP. This

Re: [Twisted-Python] ClientFactory design

2020-11-30 Thread Jean-Paul Calderone
On Mon, Nov 30, 2020 at 6:48 AM Peter Westlake wrote: > I'm studying an SSH client implementation using Conch, and was surprised > to see that the ClientFactory subclass had a connect() method which calls > connectTCP. This isn't really a problem - the code works - but it seems > like an odd plac

Re: [Twisted-Python] ClientFactory design

2020-11-30 Thread Colin Dunklau
> On 30. Nov 2020, at 05:48, Peter Westlake wrote: > >  > I'm studying an SSH client implementation using Conch, and was surprised to > see that the ClientFactory subclass had a connect() method which calls > connectTCP. This isn't really a problem - the code works - but it seems like > an

[Twisted-Python] ClientFactory design

2020-11-30 Thread Peter Westlake
I'm studying an SSH client implementation using Conch, and was surprised to see that the ClientFactory subclass had a connect() method which calls connectTCP. This isn't really a problem - the code works - but it seems like an odd place to do the connection. Am I right to be surprised? Peter.__