Re: [Twisted-Python] Question regarding patch submission

2017-06-26 Thread Glyph
> On Jun 26, 2017, at 10:46 PM, Jason Litzinger wrote: > > On Mon, Jun 26, 2017 at 02:23:24PM -0400, Glyph wrote: >> The comment about rebasing predates our current process; it was from the >> days when we were using SVN. Nowadays we usually just merge trunk in to the >> branch. > > Yikes, d

Re: [Twisted-Python] Question regarding patch submission

2017-06-26 Thread Jason Litzinger
On Mon, Jun 26, 2017 at 02:23:24PM -0400, Glyph wrote: > The comment about rebasing predates our current process; it was from the days > when we were using SVN. Nowadays we usually just merge trunk in to the > branch. Yikes, definitely didn't do that on the PR above, will from now on. If that

Re: [Twisted-Python] Question regarding patch submission

2017-06-26 Thread Glyph
> On Jun 25, 2017, at 11:34 PM, Jason Litzinger wrote: > > Hello, > Quick question regarding #15 of > https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch. > > The step indicates that history shouldn't be re-written and the branch > should be rebased over trunk. Pretty strai

Re: [Twisted-Python] How to set up Twisted buildbot VM?

2017-06-26 Thread Craig Rodrigues
I found this particular problem was due to the fact that if I followed the instructions in the braid README, pip version 1.0 is installed on the system. This is a really ancient version of pip, and installing the latest versions of mock and pbr fail with it. -- Craig On Thu, Jun 22, 2017 at 1:4