Re: [Twisted-Python] Coverage exceptions

2016-07-05 Thread Glyph Lefkowitz
> On Jul 5, 2016, at 05:18, Adi Roiban wrote: > > > > On 3 July 2016 at 20:32, Craig Rodrigues > wrote: > > > On Sun, Jul 3, 2016 at 9:10 AM, Glyph Lefkowitz > wrote: > > For now, let's just bite the bullet and require 100% pa

Re: [Twisted-Python] Coverage exceptions

2016-07-05 Thread Craig Rodrigues
On Tue, Jul 5, 2016 at 5:18 AM, Adi Roiban wrote: > > > > I have disabled codecov patch coverage for now as I think that codecov.io reporting is buggy. > > For coverage merge protection please see See https://github.com/twisted-infra/braid/issues/213 > I'm still seeing problems with codecov. In

Re: [Twisted-Python] Coverage exceptions

2016-07-05 Thread Adi Roiban
On 3 July 2016 at 20:32, Craig Rodrigues wrote: > > > On Sun, Jul 3, 2016 at 9:10 AM, Glyph Lefkowitz > wrote: > >> >> For now, let's just bite the bullet and require 100% patch coverage from >> here on out. If we hit a really nasty case where it really *is* a >> significant investment of effor