[Twisted-Python] Regarding moving on with ticket #7934 (New Logging System)

2016-06-21 Thread Eeshan Garg
Hello again! I am fully aware that it has been a _very_ long time since I mentioned that I would get on with , but I haven't really had the time to actually do anything about it. :-/ I would love to work on more tickets like < https://twistedmatrix.com/

Re: [Twisted-Python] two minor things

2016-06-21 Thread Adi Roiban
On 21 June 2016 at 20:07, Glyph wrote: > 2. The branch-naming convention puts the ticket number at the _end_ of the > branch name. > > For example, foo-1234, not 1234-foo. If we re-add the automation to > recognize branch names and update the 'branch' field in trac, getting this > consistent wil

Re: [Twisted-Python] two minor things

2016-06-21 Thread Craig Rodrigues
On Tue, Jun 21, 2016 at 12:07 PM, Glyph wrote: > > 2. The branch-naming convention puts the ticket number at the _end_ of the > branch name. > > For example, foo-1234, not 1234-foo. If we re-add the automation to > recognize branch names and update the 'branch' field in trac, getting this > cons

[Twisted-Python] two minor things

2016-06-21 Thread Glyph
These are mostly for Craig but they're relevant to everyone, so I am sending it to the mailing list. I don't know if these have been properly written down as part of a policy. 1. Please don't assign reviews normally. If someone reviews your tickets, don't punish them by crushing them with all

[Twisted-Python] Error handling in twisted.web.HTTPClient for bad certificates with TLSMemoryBIOProtocol

2016-06-21 Thread Michael Schlenker
Hi, i just stumbled onto some issue while trying to use xmlrpc.Proxy together with the TLSMemoryBIOProtocol, but its probably the same for all wrapping protocols sitting on top of the old HTTP client. If the target certificate is invalid and cannot be verified, the errback just tells me 'Connecti

[Twisted-Python] Question about twistedchecker failures

2016-06-21 Thread Craig Rodrigues
Hi, Why did this twistedchecker build succeed: https://buildbot.twistedmatrix.com/builders/twistedchecker/builds/341 and this one fail: https://buildbot.twistedmatrix.com/builders/twistedchecker/builds/342 I don't understand what is causing the failure. I looked at: https://github.com/twisted-i

[Twisted-Python] Improvements to Resource dispatch

2016-06-21 Thread Cory Benfield
All, Now that the HTTP/2 server changes have landed, one of the things I’d like to start dealing with is server Resource dispatch. Those of you who have been paying attention to this mailing list will remember that we discussed this a bit back when I was originally implementing HTTP/2 logic, an