[Twisted-Python] Need write access to Twisted

2016-06-16 Thread Craig Rodrigues
Hi, Can someone grant me write access to Twisted? I want to continue with my Python3 porting patches, and help test things directly on the buildbots. Thanks. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix

Re: [Twisted-Python] web Resource question

2016-06-16 Thread Kevin Mcintyre
Hey, thanks for the reply. It seems like there's the possibility of more beneficial assignments...but first trying to understand if there's a specific reason for the child.server assignment. On Thu, Jun 16, 2016 at 5:11 AM, Cory Benfield wrote: > > > On 16 Jun 2016, at 05:16, Kevin Mcintyre wr

Re: [Twisted-Python] web Resource question

2016-06-16 Thread Cory Benfield
> On 16 Jun 2016, at 05:16, Kevin Mcintyre wrote: > > > what is child.server = self.server in Resource.putChild? > > shouldn't it be child.server = self? I don’t think so. The reference to the server is presumably intended to refer to the Site object that is hosting the Resource. With that s

Re: [Twisted-Python] Deprecating classes and writing tests

2016-06-16 Thread Adi Roiban
On 13 June 2016 at 22:46, Glyph wrote: > > On Jun 13, 2016, at 4:26 AM, Adi Roiban wrote: > > Hi, > > What is the best practice for deprecating a class in Twisted and writing > tests for it ... and updating existing tests. > > > We appear to have 'assertDeprecated' type methods scattered around