Re: [Twisted-Python] Persuading Python's Logging to use twisted.logger

2016-05-24 Thread Glyph
> On May 24, 2016, at 4:10 PM, Daniel Sutcliffe wrote: > >> The main reason I wanted to do the format-string translation is that it >> would allow the key/value pairs to be stored according to the same idiom >> that Twisted uses, and therefore be serialized to jsonFileLogObserver and >> conse

Re: [Twisted-Python] overview: new review queue venue

2016-05-24 Thread Jonathan Vanasco
On May 24, 2016, at 6:49 PM, Glyph wrote: > I KNOW, RIGHT!!! However, protected statuses somewhat reduce the potential > race-condition here. And contributing to a couple dozen Github projects I > have to say that practically this has never been an issue, even though I find > it aestheticall

Re: [Twisted-Python] Persuading Python's Logging to use twisted.logger

2016-05-24 Thread Daniel Sutcliffe
On May 10, 2016, at 4:23 PM, Daniel Sutcliffe wrote: >> Thanks for all the hints and suggestions guys, this was far simpler >> than I thought it would be and the results are exactly what I imagined >> without too much effort. On Sat, May 21, 2016 at 9:44 PM, Glyph wrote: > Fantastic! [...] >> G

Re: [Twisted-Python] overview: new review queue venue

2016-05-24 Thread Glyph
> On May 24, 2016, at 2:49 PM, Jonathan Vanasco wrote: > > just a few thoughts: > > The current system as-explained seems to use an "Issue" as a queue item that > is either a "bug report" or a "notice of a pull request, which may also > reference another bug report". In the current system, w

Re: [Twisted-Python] overview: new review queue venue

2016-05-24 Thread Jonathan Vanasco
just a few thoughts: The current system as-explained seems to use an "Issue" as a queue item that is either a "bug report" or a "notice of a pull request, which may also reference another bug report". that is weird. IMHO, a quality contributor will never get turned off by handling the docs,

Re: [Twisted-Python] overview: new review queue venue

2016-05-24 Thread Craig Rodrigues
Hi, Thanks for bringing up these points. See: https://twistedmatrix.com/trac/ticket/8352 Feel free to add any thoughts you may have on how to improve this. -- Craig On Tue, May 24, 2016 at 10:37 AM, Jonathan Vanasco wrote: > FWIW, I just noticed that the CONTRIBUTING message wasn't showing u

Re: [Twisted-Python] overview: new review queue venue

2016-05-24 Thread Jonathan Vanasco
FWIW, I just noticed that the CONTRIBUTING message wasn't showing up when trying to make a PR. github is supposed to make a warning box that shows the contents of /CONTRIBUTING or /CONTRIBUTING.md when opening an issue or PR ___ Twisted-Python mailing