Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:42 PM, Craig Rodrigues wrote: > > On Sat, May 21, 2016 at 11:37 PM, Glyph > wrote: > > I realize it can feel like that sometimes, but Google Analytics suggests the > large majority of our visitors (45%) are on Windows. By contrast, 0.0

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:42 PM, Daniel Sank wrote: > > I can speak for ~20 scientific research groups who use Twisted via LabRAD's > python API . A lot of us use or deploy to > Windows at least some times. So that's around 200 people you've never heard > of

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:24 PM, Daniel Sank wrote: > > That does leave the question of whether you want people to use merge commits > or to rebase their branch on the latest master before merging so that you > always get a fast-forward. Github will never fast-forward, and I never want to see

Re: [Twisted-Python] overview: new review queue venue

On Sat, May 21, 2016 at 11:37 PM, Glyph wrote: > > I realize it can feel like that sometimes, but Google Analytics suggests > the large majority of our visitors (45%) are on Windows. By contrast, > 0.05% are on FreeBSD. Granted, that's a *very *high percentage of > FreeBSD clients for the Inter

Re: [Twisted-Python] overview: new review queue venue

I can speak for ~20 scientific research groups who use Twisted via LabRAD's python API . A lot of us use or deploy to Windows at least some times. So that's around 200 people you've never heard of who use Twisted on Windows :)

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:24 PM, Daniel Sank wrote: > > Squashing commits is essential to making useful commit histories. Nope. It's just a handy hack to work around the commonly-used, broken history viewers (like Github's own) that can't correctly present multi-parent commits. If you use So

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:37 PM, Glyph wrote: > > the large majority of our visitors Sorry. "plurality" :). -glyph___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:30 PM, Amber Hawkie Brown > wrote: > > >> On 22 May 2016, at 14:23, Glyph wrote: >> >> A lot of projects do follow this workflow, and maybe it will be fine for us. >> The real question is; is FreeBSD support really worth it for the cost to >> contributors, since t

Re: [Twisted-Python] overview: new review queue venue

> On 22 May 2016, at 14:32, Glyph wrote: > > >> On May 21, 2016, at 11:21 PM, Amber Hawkie Brown >> wrote: >> >> >>> On 22 May 2016, at 14:15, Glyph wrote: >>> >>> Sorry, I guess I wasn't clear. I know that PRs are presently a potential >>> alternative to a diff, and that we are still u

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:21 PM, Amber Hawkie Brown > wrote: > > >> On 22 May 2016, at 14:15, Glyph wrote: >> >> Sorry, I guess I wasn't clear. I know that PRs are presently a potential >> alternative to a diff, and that we are still using Trac for ticketing. I >> want to make it possible

Re: [Twisted-Python] overview: new review queue venue

> On 22 May 2016, at 14:23, Glyph wrote: > > A lot of projects do follow this workflow, and maybe it will be fine for us. > The real question is; is FreeBSD support really worth it for the cost to > contributors, since that's the only platform we currently support but can't > test? I'm gues

Re: [Twisted-Python] overview: new review queue venue

> On 22 May 2016, at 14:24, Daniel Sank wrote: > > All, > > > Please do not use squash commits. See > > http://mjg59.dreamwidth.org/42759.html. > > Squashing commits is essential to making useful commit histories. Are you > just saying not to use Github's built-in feature which squashes eve

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:08 PM, Amber Hawkie Brown > wrote: > > The issue in 2016 is not actually the kernel; but OpenSSL and OpenSSH, among > other system libraries. Every new version of Fedora has been red on the > buildbots for this reason; OpenSSL changed, and we needed to fix our use of

Re: [Twisted-Python] overview: new review queue venue

All, > Please do not use squash commits. See http://mjg59.dreamwidth.org/42759.html. Squashing commits is essential to making useful commit histories. Are you just saying not to use Github's built-in feature which squashes everything into a _single_ commit? If so, note that you can turn that GUI

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 11:04 PM, Adi Roiban wrote: > > I am not sure that Travis supports Python on OSX It does. We test on OS X quite extensively on , including a py2app app bundle. > and it might take some time until there is support for Python on Wi

Re: [Twisted-Python] overview: new review queue venue

> On 22 May 2016, at 14:15, Glyph wrote: > > Sorry, I guess I wasn't clear. I know that PRs are presently a potential > alternative to a diff, and that we are still using Trac for ticketing. I > want to make it possible to avoid using Trac for ticketing; perhaps switching > to github issues

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 10:52 PM, Craig Rodrigues wrote: > > On Sat, May 21, 2016 at 3:12 PM, Glyph > wrote: > Hooray! We're on github now. Next: there's the question of how to deal with > pull requests? > > A few people, including myself modified the text with

Re: [Twisted-Python] overview: new review queue venue

Dear all, While I'm just a lurker, having used Twisted and Github for some time in a moderately sized team I would like to offer a couple comments: > This is exactly why issues and PRs should be separated. If you only have one > artifact - the PR - to represent both the issue and the potential s

Re: [Twisted-Python] overview: new review queue venue

> On 22 May 2016, at 06:12, Glyph wrote: > > It is therefore tempting to map it into GitHub via labels and webhooks and > bot workflows. However, I think a better mapping would be this: > > • Proposing: Just open a pull request. Any open pull request should be > treated as part of the

Re: [Twisted-Python] overview: new review queue venue

On 22 May 2016 at 02:04, Glyph wrote: > > > On May 21, 2016, at 4:00 PM, Werner Thie wrote: > > > > Thank you all for that great and massive move! > > > > Me running twisted almost exclusively on FreeBSD, what is the reason for > > > > > We could also potentially just replace our buildbot build

Re: [Twisted-Python] overview: new review queue venue

On Sat, May 21, 2016 at 3:12 PM, Glyph wrote: > Hooray! We're on github now. Next: there's the question of how to deal > with pull requests? > A few people, including myself modified the text with Git instructions: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch The b

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 7:25 PM, Clayton Daley wrote: > > To qualify my comments, I've yet to contribute to Twisted because I don't > have a good enough grasp of its internals, but I have contributed to a > variety of Git-based OSS projects. I definitely get uneasy with the general > idea that

Re: [Twisted-Python] overview: new review queue venue

To qualify my comments, I've yet to contribute to Twisted because I don't have a good enough grasp of its internals, but I have contributed to a variety of Git-based OSS projects. I definitely get uneasy with the general idea that we're trying to "replicate workflow A from Trac in tangentially rel

Re: [Twisted-Python] Persuading Python's Logging to use twisted.logger

> On May 10, 2016, at 4:23 PM, Daniel Sutcliffe wrote: > > Thanks for all the hints and suggestions guys, this was far simpler > than I thought it would be and the results are exactly what I imagined > without too much effort. Fantastic! > Jeff: Have to admit I started with your code and had i

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 3:57 PM, Terry Jones wrote: > > Hi Glyph > > On Sun, May 22, 2016 at 12:12 AM, Glyph > wrote: > Reviewing: This is the potentially slightly odd part. I believe a review > that doesn't result in acceptance should close the PR. > > This fe

Re: [Twisted-Python] overview: new review queue venue

> On May 21, 2016, at 4:00 PM, Werner Thie wrote: > > Thank you all for that great and massive move! > > Me running twisted almost exclusively on FreeBSD, what is the reason for > > > We could also potentially just replace our buildbot build farm with a > > combination of appveyor and travis-c

Re: [Twisted-Python] overview: new review queue venue

Thank you all for that great and massive move! Me running twisted almost exclusively on FreeBSD, what is the reason for > We could also potentially just replace our buildbot build farm with a > combination of appveyor and travis-ci; this would remove FreeBSD from > our list of supported platform

Re: [Twisted-Python] overview: new review queue venue

Hi Glyph On Sun, May 22, 2016 at 12:12 AM, Glyph wrote: > - Reviewing: This is the potentially slightly odd part. I believe a > review that doesn't result in acceptance should *close* the PR. This feels wrong to me. I find github pull requests very useful, in ways that it sounds like your sug

[Twisted-Python] overview: new review queue venue

Hooray! We're on github now. Next: there's the question of how to deal with pull requests? It occurs to me that what we really need from our code review system is mainly one thing: the review queue: a single place for reviewers to look to find things that need to be reviewed. This is importa

Re: [Twisted-Python] Looking for help dealing with ClientService reconnections

> On May 10, 2016, at 9:52 AM, Daniel Sutcliffe wrote: > > Thanks Glyph, I think you have given me a push back in the 'right' > direction - more thoughts and commentary embedded below if you, or > anyone else, has the time. > > On May 6, 2016, at 10:19 AM, Daniel Sutcliffe wrote: > [...] >>> T

Re: [Twisted-Python] Twisted 16.2 Release Announcement

On 18 May 2016 at 18:07, Amber "Hawkie" Brown wrote: > On behalf of Twisted Matrix Laboratories, I am honoured to announce the > release of Twisted 16.2! > > Just in time for PyCon US, this release brings a few headlining features > (like the haproxy endpoint) and the continuation of the modernis