Re: [Twisted-Python] running trial on windows

2016-04-04 Thread Glyph
> On Apr 4, 2016, at 1:39 AM, John Aherne wrote: > > I have to specify a really long path to pick up the copy of trial.py for the > virtualenv I am working in. > > I specify the virtualenv python I want to run with and then the path to > trial.py then the test I want to run. > > It would app

Re: [Twisted-Python] SSl wincertstore Ticket 6371

2016-04-04 Thread Glyph
> On Apr 4, 2016, at 2:56 AM, John Aherne wrote: > > I have done a clean download of twisted and run the tests without any changes. OK. This is a bug we should investigate, but I think we can safely say it's a separate bug and not one which will cause your patch to fail review. -glyph___

[Twisted-Python] Twisted 16.1 Release Announcement

2016-04-04 Thread Amber "Hawkie" Brown
On behalf of Twisted Matrix Laboratories, I am honoured to announce the release of Twisted 16.1! This release is hot off the heels of 16.0 released last month, including some nice little tidbits. The highlights include: - twisted.application.internet.ClientService, a service that maintains a p

Re: [Twisted-Python] web.client.readBody

2016-04-04 Thread Cory Benfield
> On 4 Apr 2016, at 09:32, John Aherne wrote: > > Cory > > Thanks for the detailed reply. > > I'll see what I can make of it. > > I must admit I don't see Google paying much attention to this. > > It does work if I use response.deliverBody, but I thought getting the > complete response in o

[Twisted-Python] SSl wincertstore Ticket 6371

2016-04-04 Thread John Aherne
I have done a clean download of twisted and run the tests without any changes. I still get the same error on:-- twisted.names.test.test_tap.OptionsTests.test_recursiveConfiguration [ERROR] Traceback (most recent call last): Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was uncl

[Twisted-Python] SSl wincertstore Ticket 6371

2016-04-04 Thread John Aherne
The failure is in test_agent test_setsTrustRootOnContextDefaultTrustRoot This fails if wincertstore is available with this failure:- twisted.trial.unittest.FailTest: is not an instance of This is because the patch from aaron which I have applied has_sslverify.platformTrust check for wincert

[Twisted-Python] running trial on windows

2016-04-04 Thread John Aherne
I have to specify a really long path to pick up the copy of trial.py for the virtualenv I am working in. I specify the virtualenv python I want to run with and then the path to trial.py then the test I want to run. It would appear to be only the wincertstore module that is missed. Perhaps I'll s

[Twisted-Python] web.client.readBody

2016-04-04 Thread John Aherne
Cory Thanks for the detailed reply. I'll see what I can make of it. I must admit I don't see Google paying much attention to this. It does work if I use response.deliverBody, but I thought getting the complete response in one hit would be better. John -- *John Aherne* *www.rocs.co.uk

[Twisted-Python] web.client.readbody

2016-04-04 Thread John Aherne
To Glyph This works fine if I use response.deliverBody I get a json response back. I'll look at what Cory says and see where I get. Thanks John -- *John Aherne* *www.rocs.co.uk * 020 7223 7567 ___ Twisted-Python mailing l

Re: [Twisted-Python] web.client.readBody

2016-04-04 Thread Cory Benfield
> On 3 Apr 2016, at 14:35, John Aherne wrote: > > I have been using deliverBody to process in responses but decided that > readBody might be a better fit. > > So far it works with http, but as soon as I switch to https it fails. > > I get a response http code 200 OK but no data. > > I've puz

Re: [Twisted-Python] SSL wincertstore Ticket 6371

2016-04-04 Thread Glyph
> On Apr 3, 2016, at 6:29 AM, John Aherne wrote: > > I have picked up on this again. > > There would appear to be a failing test in test_agent.py. You said 'test_agent' but the error below is coming from test_tap; which are you referring to? > I have added a new test to check that certificat

Re: [Twisted-Python] Running trial on windows

2016-04-04 Thread Glyph
> On Apr 3, 2016, at 6:45 AM, John Aherne wrote: > > When I run trial in a virtualenv it seems to miss some imports and skips some > tests. > > It would seem to be mainly wincertstore that it can't import. > > To make it work I have to include wincertstore in my main python setup and > then

Re: [Twisted-Python] web.client.readbody

2016-04-04 Thread Glyph
> On Apr 3, 2016, at 7:06 AM, John Aherne wrote: > > I was obviously half-asleep when I posted the previous email. > > Doing more tests, it would seem that only googlemaps is giving me this > problem. > Is the request in question one you expect no data from? -g _