Re: [Twisted-Python] twisted/runner/inetdtap.py pyflakes warnings cleanup

2015-11-23 Thread Glyph Lefkowitz
> On Nov 23, 2015, at 04:29, Adi Roiban wrote: > > > On 23 November 2015 at 03:13, Glyph Lefkowitz > wrote: > > [snip] > > > Thank you. This would be absolutely great. > > https://twistedmatrix.com/trac/ticket/8107 >

Re: [Twisted-Python] How to get the class of the wrapped fget/fset property methods

2015-11-23 Thread Glyph Lefkowitz
> On Nov 23, 2015, at 07:38, Adi Roiban wrote: > > > > Will push the tests and will ask for help in the review queue. > > Thanks! > > > Another option is to fix @deprecated to call getDeprecationWarningString when > the method is called not when it is created. I think you mean the other

Re: [Twisted-Python] AMP message length limit

2015-11-23 Thread Oon-Ee Ng
On Tue, Nov 24, 2015 at 10:58 AM, Oon-Ee Ng wrote: > On Tue, Nov 24, 2015 at 9:16 AM, Oon-Ee Ng wrote: >> >> Thanks, right now I just have plenty of return {} everywhere. Does >> requiresAnswer=False mean less bandwidth usage (no need to transmit an >> empty dict)? > > Having read the documentati

Re: [Twisted-Python] AMP message length limit

2015-11-23 Thread Oon-Ee Ng
On Tue, Nov 24, 2015 at 9:16 AM, Oon-Ee Ng wrote: > > Thanks, right now I just have plenty of return {} everywhere. Does > requiresAnswer=False mean less bandwidth usage (no need to transmit an > empty dict)? Having read the documentation a bit, it appears requiresAnswer=False is a hint and I'd s

Re: [Twisted-Python] AMP message length limit

2015-11-23 Thread Oon-Ee Ng
On Mon, Nov 23, 2015 at 8:54 AM, Glyph Lefkowitz wrote: > I'm sorry that this was an unpleasant surprise. I wish that we had a better > way of getting this across up-front :-). However, it seems like the length > limit is doing its job in terms of constraining your protocol design to not > have

Re: [Twisted-Python] Streaming HTTP

2015-11-23 Thread Cory Benfield
> On 19 Nov 2015, at 11:50, Cory Benfield wrote: > This seems super-gross but vaguely do-able, and we’ll need to write it in > order to get the new H2Connection/H2Stream objects working with the old > paradigm anyway. > > All of this approach sounds reasonable modulo some careful thinking abou

Re: [Twisted-Python] How to get the class of the wrapped fget/fset property methods

2015-11-23 Thread Adi Roiban
> > > > Will push the tests and will ask for help in the review queue. > > Thanks! > > Another option is to fix @deprecated to call getDeprecationWarningString when the method is called not when it is created. Regards -- Adi Roiban ___ Twisted-Python ma

Re: [Twisted-Python] How to get the class of the wrapped fget/fset property methods

2015-11-23 Thread Adi Roiban
On 23 November 2015 at 02:32, Glyph Lefkowitz wrote: > > On Nov 22, 2015, at 07:04, Adi Roiban wrote: > > The @deprecated decorator (at leas on py2.7) does not work when paired > @property > > For deprecated instance variables, our deprecation policy recommend > converting them into properties a

Re: [Twisted-Python] twisted/runner/inetdtap.py pyflakes warnings cleanup

2015-11-23 Thread Adi Roiban
On 23 November 2015 at 03:13, Glyph Lefkowitz wrote: [snip] > Thank you. This would be absolutely great. > https://twistedmatrix.com/trac/ticket/8107 is waiting for review... and should make this happen :) > I would like to clean the inetdtap.py module of pylakes warning but since > it is b