Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Daniel Sank
Dustin, > Adding what amounts to a use-after-free bug to the protocol seems like a really bad idea to me. Oh goody, a sarcastic comment which doesn't actually bother to explain the bug :) Since what I describe is basically WeakReferenceable, it's not obvious to me that there's a bug. I tell you

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Dustin J. Mitchell
Adding what amounts to a use-after-free bug to the protocol seems like a really bad idea to me. Perhaps you see a more compelling use-case than the chess example. In just about any case I can think of, I'm not at all concerned about when garbage collection takes place. Certainly it opens you to

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Daniel Sank
Dustin and glyph, > Indeed, what you're expecting is very much against the design of PB. I see. The existing Referenceable code now makes sense to me, since I now understand the intent. Thank you. Would having something like Referenceable but which is not reference counted across the network, an

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Dustin J. Mitchell
Indeed, what you're expecting is very much against the design of PB. Dustin On Mon, Aug 18, 2014 at 5:25 PM, Daniel Sank wrote: > Dustin, > > > No, this is simply incorrect. 'del myThingy' simply removes > > a reference to the object to which myThingy refers. > > Argh. I'm assuming, as in the

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Daniel Sank
Dustin, > No, this is simply incorrect. 'del myThingy' simply removes > a reference to the object to which myThingy refers. Argh. I'm assuming, as in the example, that the only strong reference to myThingy is the one I own. > the Broker keeps a Python reference to the object internally, > preve

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Dustin J. Mitchell
On Mon, Aug 18, 2014 at 3:37 PM, Daniel Sank wrote: > and I send you the Referenceable. Now suppose I do > > del myThingy > > Now myThingy will be garbage collected. No, this is simply incorrect. 'del myThingy' simply removes a reference to the object to which myThingy refers. If and only if th

Re: [Twisted-Python] patch for t.p.logger.SyslogObserver (was #7549)

2014-08-18 Thread Roberto Polli
Hi Glyph, thx for your feedback! > Is this otherwise ready for review? Not ready for review: there's even to check the interoperability with twistd ;) I was concerned about to be on the right track, eg: 1- is it fine to patch SyslogObserver.syslog or should I pass it as a parameter to SyslogOb

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Glyph Lefkowitz
On Aug 18, 2014, at 12:37 PM, Daniel Sank wrote: > glyph, > > > A "resource" - i.e. a Referenceable - is just a Python object in memory. > > Indeed. > > > but in normal operation, Python objects don't spontaneously ascend > > to a different plane of existence - as long as there are pointers t

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Daniel Sank
glyph, > A "resource" - i.e. a Referenceable - is just a Python object in memory. Indeed. > but in normal operation, Python objects don't spontaneously ascend > to a different plane of existence - as long as there are pointers to them in > memory Of course. > in the case of Referenceables that

Re: [Twisted-Python] t.p.syslog, t.p.logger and twistd (was #7549)

2014-08-18 Thread Glyph Lefkowitz
On Aug 18, 2014, at 9:14 AM, Roberto Polli wrote: > Hi @all, > > On Tuesday 12 August 2014 11:18:31 Glyph Lefkowitz wrote: >> 2- I'll create t.p.logger._syslog >> 3- I''ll patch t.p.syslog to use t.p.logger._syslog > While writing 2, I found that > > 1- t.p.logger.LogLevel implements a mappin

Re: [Twisted-Python] patch for t.p.logger.SyslogObserver (was #7549)

2014-08-18 Thread Glyph Lefkowitz
On Aug 18, 2014, at 10:50 AM, Roberto Polli wrote: > Hi everybody, > > I found some time for adding a stub of SyslogObserver to the new t.p.logger. > > https://github.com/ioggstream/twisted/commit/991156e1124d61ad26da0be12123079ffc45764c > > Feedback welcome! > > Peace, > R. For starters, Du

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Glyph Lefkowitz
On Aug 18, 2014, at 11:49 AM, Daniel Sank wrote: > glyph, > > > On the sender's side, the object can't disappear unless the recipient sends > > the deletion. > > Surely a resource can disappear on the server. When that happens, any > Referenceables being used to mediate access to that resour

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Daniel Sank
glyph, > On the sender's side, the object *can't* disappear unless the recipient sends the deletion. Surely a resource can disappear on the server. When that happens, any Referenceables being used to mediate access to that resource should go away... or something, right? I must not be thinking abo

Re: [Twisted-Python] Is there pb documentation somewhere?

2014-08-18 Thread Glyph Lefkowitz
On Aug 17, 2014, at 8:05 PM, Daniel Sank wrote: > glyph, > > >> 2. Do I notify you if Joe disappears on my side? > >> > > Yes. > > . > > That's the recipient announcing deletion, no

[Twisted-Python] patch for t.p.logger.SyslogObserver (was #7549)

2014-08-18 Thread Roberto Polli
Hi everybody, I found some time for adding a stub of SyslogObserver to the new t.p.logger. https://github.com/ioggstream/twisted/commit/991156e1124d61ad26da0be12123079ffc45764c Feedback welcome! Peace, R. -- Roberto Polli Community Manager Babel - a business unit of Par-Tec S.p.A. - http://w

Re: [Twisted-Python] t.p.syslog, t.p.logger and twistd (was #7549)

2014-08-18 Thread Roberto Polli
Hi @all, On Tuesday 12 August 2014 11:18:31 Glyph Lefkowitz wrote: > 2- I'll create t.p.logger._syslog > 3- I''ll patch t.p.syslog to use t.p.logger._syslog While writing 2, I found that 1- t.p.logger.LogLevel implements a mapping between syslog priorities and loglevels. 2- there's a private me