Re: [Twisted-Python] Some news about currently-pending code-reviews

2009-12-24 Thread Glyph Lefkowitz
On Dec 24, 2009, at 12:37 AM, Tim Allen wrote: > As I've started reviewing over the past week or two, the developers > whose code I've reviewed and the regulars in the #twisted IRC channel > have all been super-helpful, and I highly recommend code-reviewing as > a pleasant way to spend an idle af

Re: [Twisted-Python] Some news about currently-pending code-reviews

2009-12-24 Thread sstein...@gmail.com
On Dec 24, 2009, at 12:37 AM, Tim Allen wrote: > You don't have to be a Twisted expert to help out, and don't worry about > whether you're experienced enough to spot every possible problem - most > patches get reviewed *at > least* two or three times by different people, and every problem you pi

Re: [Twisted-Python] Some news about currently-pending code-reviews

2009-12-24 Thread Gerrat Rickert
[snip] >http://twistedmatrix.com/trac/ticket/3956 >Add arraysize option to runQuery in adbapi > > - The "arraysize" property is the only writable cursor property defined > by DBAPI2. Setting it can make the .fetchall() method faster with > some DB modules, but Twisted's adbapi module offers no