Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Cédric Krier
On 19/07/11 12:34 -0700, Ian Wilson wrote: > On Tue, Jul 19, 2011 at 12:06 AM, Cédric Krier wrote: > > > On 18/07/11 15:31 -0700, Ian Wilson wrote: > > > On Sun, Jul 17, 2011 at 2:05 PM, wrote: > > > > > > What is the purpose of this module? > > > > > > The term rebate seems ambiguous. Why not u

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Ian Wilson
On Tue, Jul 19, 2011 at 12:06 AM, Cédric Krier wrote: > On 18/07/11 15:31 -0700, Ian Wilson wrote: > > On Sun, Jul 17, 2011 at 2:05 PM, wrote: > > > > What is the purpose of this module? > > > > The term rebate seems ambiguous. Why not use the term discount? > > All those marketing terms "rebat

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Cédric Krier
On 18/07/11 17:34 -0500, Rob Martin wrote: > I prefer rebate in this case, especially if the rebate can be recorded as > an expense. I haven't reviewed the code. Is that possible? No. You are talking about rebate explicitly done on the invoice which generates accounting lines (like a credit note)

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Cédric Krier
On 18/07/11 15:31 -0700, Ian Wilson wrote: > On Sun, Jul 17, 2011 at 2:05 PM, wrote: > > What is the purpose of this module? > > The term rebate seems ambiguous. Why not use the term discount? All those marketing terms "rebate", "discount", "refund" do not have a clear definition. Just look at

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-18 Thread Rob Martin
I prefer rebate in this case, especially if the rebate can be recorded as an expense. I haven't reviewed the code. Is that possible? On Jul 18, 2011 6:31 PM, "Ian Wilson" wrote: > On Sun, Jul 17, 2011 at 2:05 PM, wrote: > >> Reviewers: , >> >> >> >> Please review this at http://codereview.tryton

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-18 Thread Ian Wilson
On Sun, Jul 17, 2011 at 2:05 PM, wrote: > Reviewers: , > > > > Please review this at > http://codereview.tryton.org/**66001/ > > Affected files: > A COPYRIGHT > A INSTALL > A LICENSE > A MANIFEST.in > A README > A __init__.py > A __tryton__.py > A doc

[tryton-dev] New module sale_rebate (issue66001)

2011-07-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/66001/ Affected files: A COPYRIGHT A INSTALL A LICENSE A MANIFEST.in A README A __init__.py A __tryton__.py A doc/index.rst A sale.py A sale.xml A setup.py A tests/__init__.py A tests/scenario_sale_rebate