Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Cédric Krier
On 19/07/11 12:34 -0700, Ian Wilson wrote: > On Tue, Jul 19, 2011 at 12:06 AM, Cédric Krier wrote: > > > On 18/07/11 15:31 -0700, Ian Wilson wrote: > > > On Sun, Jul 17, 2011 at 2:05 PM, wrote: > > > > > > What is the purpose of this module? > > > > > > The term rebate seems ambiguous. Why not u

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Ian Wilson
On Tue, Jul 19, 2011 at 12:06 AM, Cédric Krier wrote: > On 18/07/11 15:31 -0700, Ian Wilson wrote: > > On Sun, Jul 17, 2011 at 2:05 PM, wrote: > > > > What is the purpose of this module? > > > > The term rebate seems ambiguous. Why not use the term discount? > > All those marketing terms "rebat

[tryton-dev] Fix wrong fields passed to Group introduced by ce7f9b8ae8ab (issue70001)

2011-07-19 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/70001/ Affected files: M tryton/gui/window/view_form/model/field.py Index: tryton/gui/window/view_form/model/field.py === --- a/tryton/gui/window/view_form/model/

[tryton-dev] Add missing test on company (issue69001)

2011-07-19 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/69001/ Affected files: M forecast.py Index: forecast.py === --- a/forecast.py +++ b/forecast.py @@ -100,12 +100,13 @@ 'AND location = %s

[tryton-dev] Fix rowcount usage (issue68001)

2011-07-19 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/68001/ Affected files: M forecast.py Index: forecast.py === --- a/forecast.py +++ b/forecast.py @@ -106,7 +106,10 @@ forecast.from_date, fo

Re: [tryton-dev] Remove NetRPC

2011-07-19 Thread Cédric Krier
On 19/07/11 09:56 +0200, Borja LS wrote: > El 17/07/11 11:51, Cédric Krier escribió: > >proposal to drop NetRPC for jsonrpc > > > What about using Pyro instead of NetRPC? (http://packages.python.org/Pyro/) I don't know Pyro but it seems to be design to work with Pyro object on the server side. T

Re: [tryton-dev] Remove NetRPC

2011-07-19 Thread Borja LS
El 17/07/11 11:51, Cédric Krier escribió: proposal to drop NetRPC for jsonrpc What about using Pyro instead of NetRPC? (http://packages.python.org/Pyro/) NaN used it for Koo (KDE based OpenObject Client) with great success (is much faster than NetRPC over high latency networks). The server

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Cédric Krier
On 18/07/11 17:34 -0500, Rob Martin wrote: > I prefer rebate in this case, especially if the rebate can be recorded as > an expense. I haven't reviewed the code. Is that possible? No. You are talking about rebate explicitly done on the invoice which generates accounting lines (like a credit note)

Re: [tryton-dev] New module sale_rebate (issue66001)

2011-07-19 Thread Cédric Krier
On 18/07/11 15:31 -0700, Ian Wilson wrote: > On Sun, Jul 17, 2011 at 2:05 PM, wrote: > > What is the purpose of this module? > > The term rebate seems ambiguous. Why not use the term discount? All those marketing terms "rebate", "discount", "refund" do not have a clear definition. Just look at