[trojita] Re: Addressbook interface for qt plugins

2013-08-07 Thread Thomas Lübking
On Montag, 5. August 2013 17:20:16 CEST, Jan Kundrát wrote: It might be better to separate this into two classes. One that implements the addressbook and one that implements the interface using an instance of that class. One reason is that anyone creating new plugins will look at the existing

Re: [trojita] Re: Another GSoC review

2013-08-07 Thread Pali Rohár
On Monday 05 August 2013 23:15:00 Thomas Lübking wrote: > On Montag, 5. August 2013 22:32:48 CEST, Jan Kundrát wrote: > > On Monday, 5 August 2013 19:54:05 CEST, Thomas Lübking wrote: > >> Did i miss this? > >> Where's mentioned "does not work" (reason is perhaps > >> lacking Q_OBJECT macro?) > >

[trojita] Re: GSoC: CMake version & Kontact plugin

2013-08-07 Thread Jan Kundrát
On Wednesday, 7 August 2013 07:34:54 CEST, Pali Rohár wrote: Can you test to compile my gsoc branch (with decreased cmake version) on your target systems? Myabe POSITION_INDEPENDENT_CODE property will also work with older cmake... As you said, the POSITION_INDEPENDENT_CODE property got added i

Re: [trojita] Re: GSoC: CMake version & Kontact plugin

2013-08-07 Thread Pali Rohár
On Wednesday 07 August 2013 14:55:40 Jan Kundrát wrote: > On Wednesday, 7 August 2013 07:34:54 CEST, Pali Rohár wrote: > > Can you test to compile my gsoc branch (with decreased cmake > > version) on your target systems? Myabe > > POSITION_INDEPENDENT_CODE property will also work with > > older cma

[trojita] Re: GSoC: plugins & loader

2013-08-07 Thread Jan Kundrát
On Wednesday, 17 July 2013 21:42:04 CEST, Pali Rohár wrote: My current code have common "interface" classes for password and addressbook plugins. Because trojita working only with pointers of these common objects, code of interface classes must be statically linked into trojita executable binar