Re: [trojita] Re: GSoC review

2013-07-11 Thread Kevin Krammer
On Wednesday, 2013-07-10, Thomas Lübking wrote: > @Kevin, I'll now make a public statement: > If you've any influence, get rid of the name "akonadi". > It's so much burned that a huge amount of ppl. will never use it, no matter > how good it can get, just because of its name ;-) Ah, that is not a

Re: [trojita] Re: GSoC review

2013-07-11 Thread Kevin Krammer
On Wednesday, 2013-07-10, Pali Rohár wrote: > I already wrote that if you want I will create akonadi plugin > too. So there is no problem that distributions will do not have > plugin using new kde api. Sure, I was just commenting on the assumption that the goal was primarily to hook into people'

Re: [trojita] GSoC review

2013-07-11 Thread Thomas Lübking
Hi Pali Following some comments on the branch. I read the diff and wrote them in a train so it's rather brief ;-) On a general note, anyc API in a loop of course sucks but it might still worth trying to get rid of the nested event loops Cheers, Thomas + +namespace Common { + +PluginLoader::Plug

[trojita] Re: GSoC review

2013-07-11 Thread Jan Kundrát
On Wednesday, 10 July 2013 17:00:27 CEST, Kevin Krammer wrote: In my initial assessment I was assuming that the goal of the KDE plugin, especially in the context of the GSoC project, was to enable users of Trojita and using KDE PIM for addressbook to access addressbook data in Trojita. Most of

Re: [trojita] GSoC review

2013-07-11 Thread Kevin Krammer
On Friday, 2013-07-12, Thomas Lübking wrote: > +++ // TODO QMetaObject::invokeMethod > +QTimer::singleShot(0, this, SLOT(doStart())); Internally this is actually the same thing. > +protected slots: > +++ // TODO slots don't have to be virtual > +/** @short Reimplement starting job */