Re: [trojita] Re: GSoC merge request

2013-07-10 Thread Pali Rohár
On Monday 08 July 2013 22:04:33 Caspar Schutijser wrote: > Hi Pali, > > On Monday, July 8, 2013 6:10:36 PM CEST, Pali Rohár wrote: > > today I cleaned my git tree and created new (rebased) branch > > which is ready for comments and then for merging to master. > > One piece of feedback for now. >

Re: [trojita] GSoC review

2013-07-10 Thread Pali Rohár
On Monday 08 July 2013 19:56:54 Kevin Krammer wrote: > On Monday, 2013-07-08, Pali Rohár wrote: > > On Monday 08 July 2013 16:37:31 Kevin Krammer wrote: > > > On Monday, 2013-07-08, Pali Rohár wrote: > > > > On Thursday 04 July 2013 18:38:40 Kevin Krammer wrote: > > > > > Hi, > > > > > > > > > > I

Re: [trojita] GSoC review

2013-07-10 Thread Kevin Krammer
On Wednesday, 2013-07-10, Pali Rohár wrote: > On Monday 08 July 2013 19:56:54 Kevin Krammer wrote: > > If you want to display the plugin that has become unavailable > > you could additionally store the name, no? > > > > The main problem with using the identifier as a user visible > > string is th

[trojita] Re: GSoC review

2013-07-10 Thread Caspar Schutijser
On Wednesday, July 10, 2013 5:00:27 PM CEST, Kevin Krammer wrote: Creating a plugin for really old distribution versions or RHEL6 (or older) might be a worthwhile goal on its own, I am just not sure it should be the done as part of the GSoC scope. Do we have any opinion on that from the Trojit

Re: [trojita] Re: GSoC review

2013-07-10 Thread Pali Rohár
On Wednesday 10 July 2013 17:17:37 Caspar Schutijser wrote: > On Wednesday, July 10, 2013 5:00:27 PM CEST, Kevin Krammer wrote: > > Creating a plugin for really old distribution versions or > > RHEL6 (or older) might be a worthwhile goal on its own, I > > am just not sure it should be the done as p

[trojita] Re: GSoC review

2013-07-10 Thread Caspar Schutijser
On Wednesday, July 10, 2013 8:26:52 PM CEST, Pali Rohár wrote: On Wednesday 10 July 2013 17:17:37 Caspar Schutijser wrote: On Wednesday, July 10, 2013 5:00:27 PM CEST, Kevin Krammer wrote: Creating a plugin for really old distribution versions or RHEL6 (or older) might be a worthwhile goal on i

[trojita] Re: GSoC merge request

2013-07-10 Thread Caspar Schutijser
On Wednesday, July 10, 2013 1:16:39 PM CEST, Pali Rohár wrote: I fixed this problem. Also that one which caused that tests was not possible to compile. Patches pushed to my same git branch. Thanks :) I read through the diff (that is, everything that has changed between your version and the "m

[trojita] Re: GSoC review

2013-07-10 Thread Thomas Lübking
On Mittwoch, 10. Juli 2013 20:52:20 CEST, Caspar Schutijser wrote: I don't know if someone has another opinion on this? The problem with the KABC plugin is that it seems to be unusable with a few months (but on older distros) - i don't have to sell that to google but it sounds like a pointle

[trojita] Re: GSoC merge request

2013-07-10 Thread Caspar Schutijser
Hi Pali, One other thing, related to the GUI: the minimumSize of the added QComboBoxes in the settings dialog cause a horizontal scrollbar to appear in the settings dialog, at least on my computer. How about lowering the width of the minimumSize for a bit? While we are at it, since the addition

Re: [trojita] Re: GSoC merge request

2013-07-10 Thread Pali Rohár
On Wednesday 10 July 2013 21:35:09 Caspar Schutijser wrote: > Hi Pali, > > One other thing, related to the GUI: the minimumSize of the > added QComboBoxes in the settings dialog cause a horizontal > scrollbar to appear in the settings dialog, at least on my > computer. How about lowering the width

Re: [trojita] Re: GSoC merge request

2013-07-10 Thread Pali Rohár
On Wednesday 10 July 2013 20:59:21 Caspar Schutijser wrote: > On Wednesday, July 10, 2013 1:16:39 PM CEST, Pali Rohár wrote: > > I fixed this problem. Also that one which caused that tests > > was not possible to compile. Patches pushed to my same git > > branch. > > Thanks :) > > > I read throu

[trojita] Re: GSoC merge request

2013-07-10 Thread Thomas Lübking
On Mittwoch, 10. Juli 2013 21:41:30 CEST, Pali Rohár wrote: I played a lot with minimal size and on my machine there are no scrollbars. But now I think that minimal size depends on used qt theme and so we cannot predicate correct minmal size. So is there any way to tell general settings tab w