Re: [trojita] Feedback on UI for message redirection

2014-08-13 Thread Jan Kundrát
On Wednesday, 13 August 2014 20:08:46 CEST, Karan Luthra wrote: Only for the redirect composer dialog? Is it useful? OK, the PartWidgetFactory relies on a MessageView instance, and that class assumes that it's a viewer, including its willingness to modify the message flags and what not. Clean

Re: [trojita] Feedback on UI for message redirection

2014-08-13 Thread Karan Luthra
On Wednesday, August 13, 2014 11:27:59 PM IST, Jan Kundrát wrote: On Wednesday, 13 August 2014 19:48:26 CEST, Thomas Lübking wrote: Actually, I don't see a reason why the body should be hidden for the same reason. Yes, but there's a pretty big impedance mismatch between what Trojita-the-viewe

Re: [trojita] Feedback on UI for message redirection

2014-08-13 Thread Jan Kundrát
On Wednesday, 13 August 2014 19:48:26 CEST, Thomas Lübking wrote: Actually, I don't see a reason why the body should be hidden for the same reason. Yes, but there's a pretty big impedance mismatch between what Trojita-the-viewer can display (any MIME structure) and what Trojita-the-composer c

Re: [trojita] Feedback on UI for message redirection

2014-08-13 Thread Thomas Lübking
On Mittwoch, 13. August 2014 19:11:56 CEST, Karan Luthra wrote: In the initial UI mockup that started this thread, this wasn't so. Infact in the redirection use-case, the subject field was serving the purpose of identifying the message picked for redirection to be the correct, intended one. Th

Re: [trojita] Feedback on UI for message redirection

2014-08-13 Thread Jan Kundrát
On Wednesday, 13 August 2014 19:11:56 CEST, Karan Luthra wrote: In the QWidget subclass (I call it EnvelopeFormWidget) that would be used in the normal compose dialog as well as the redirect dialog, only the form fields for senders and recipients will be included. I.e. the subject field will be

Re: [trojita] Feedback on UI for message redirection

2014-08-13 Thread Karan Luthra
On Wednesday, August 6, 2014 9:19:33 PM IST, Jan Kundrát wrote: IMHO these three parts should be reused for the redirection dialog: - sender/from handling, - recipients list, - the logic which takes care about the submission process and its GUI visualization This is going to bring one change

Re: [trojita] Feedback on UI for message redirection

2014-08-06 Thread Jan Kundrát
On Tuesday, 5 August 2014 19:45:19 CEST, Karan Luthra wrote: I like this hack because it re-uses GUI code, and allows creation of the redirection widget to be grouped with creation of composer widget for other purposes (new, draft, reply, forward, etc). But let me know if this is a bad way to g

[trojita] Feedback on UI for message redirection

2014-08-05 Thread Karan Luthra
Hi folks, I was working on a patch for Message Redirection[1] and thought I'd take feedback on a mock UI. Would you suggest creating a new widget class for the message redirection widget? Otherwise, I wanted to have a ComposeWidget::createRedirect(..) type static, just as an addition to the