Re: [trojita] Another GSoC review

2013-08-18 Thread Jan Kundrát
On Tuesday, 13 August 2013 08:58:19 CEST, Pali Rohár wrote: I do not want to tell password plugin that "this is password for username ABC for server XYZ", because both ABC and XYZ can be changed, but password not. Imagine that ip address (or dns name) of server will be changed and then user los

Re: [trojita] Another GSoC review

2013-08-13 Thread Pali Rohár
On Wednesday 14 August 2013 00:31:10 Jan Kundrát wrote: > On Tuesday, 13 August 2013 20:34:48 CEST, Pali Rohár wrote: > > So what about chaging code > > disconnect(jobSecond, 0, 0, 0); > > to > > disconnect(jobSecond, 0, this, 0); > > Yes please. Done. -- Pali Rohár pali.ro...@gmail.com signa

Re: [trojita] Another GSoC review

2013-08-13 Thread Jan Kundrát
On Tuesday, 13 August 2013 20:34:48 CEST, Pali Rohár wrote: So what about chaging code disconnect(jobSecond, 0, 0, 0); to disconnect(jobSecond, 0, this, 0); Yes please. -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/

Re: [trojita] Another GSoC review

2013-08-12 Thread Pali Rohár
On Monday 12 August 2013 18:22:59 Jan Kundrát wrote: > On Sunday, 11 August 2013 11:57:59 CEST, Pali Rohár wrote: > > Both plugins passes information in signals params. This is > > unified. But only in ComposeWidget.cpp code I need sender() > > because pointer of Job is removed from queue. This is

Re: [trojita] Another GSoC review

2013-08-12 Thread Kevin Krammer
On Monday, 2013-08-12, Jan Kundrát wrote: > On Sunday, 11 August 2013 11:57:59 CEST, Pali Rohár wrote: > > Both plugins passes information in signals params. This is > > unified. But only in ComposeWidget.cpp code I need sender() > > because pointer of Job is removed from queue. This is needed > >

Re: [trojita] Another GSoC review

2013-08-12 Thread Jan Kundrát
On Sunday, 11 August 2013 11:57:59 CEST, Pali Rohár wrote: Both plugins passes information in signals params. This is unified. But only in ComposeWidget.cpp code I need sender() because pointer of Job is removed from queue. This is needed because ComposeWidget had sync API for completion and it

Re: [trojita] Another GSoC review

2013-08-11 Thread Pali Rohár
On Sunday 11 August 2013 10:22:27 Jan Kundrát wrote: > On Thursday, 8 August 2013 22:04:52 CEST, Pali Rohár wrote: > >> - Why is function "loadPlugin" trying to unload plugins? > > > > It is not "trying", but clean up resources when library is > > not for trojita or if plugin for category is alrea

Re: [trojita] Another GSoC review

2013-08-11 Thread Jan Kundrát
On Thursday, 8 August 2013 22:04:52 CEST, Pali Rohár wrote: - Why is function "loadPlugin" trying to unload plugins? It is not "trying", but clean up resources when library is not for trojita or if plugin for category is already loaded and selected. But for creating list of available plugins

Re: [trojita] Another GSoC review

2013-07-13 Thread Pali Rohár
Hello, On Friday 12 July 2013 21:39:21 Jan Kundrát wrote: > Hi Pali, > looking at the work you've done so far. First of all, it looks > great -- I believe that you're on a good track. > > - Why are TrojitaPluginJob::start/stop postponing the actual > operation via the event loop? I'm not saying i

[trojita] Another GSoC review

2013-07-12 Thread Jan Kundrát
Hi Pali, looking at the work you've done so far. First of all, it looks great -- I believe that you're on a good track. - Why are TrojitaPluginJob::start/stop postponing the actual operation via the event loop? I'm not saying it's bad, but I'm wondering why. A comment explaining this would be