Re: [trojita] Another GSoC review

2013-08-13 Thread Pali Rohár
On Wednesday 14 August 2013 00:31:10 Jan Kundrát wrote: > On Tuesday, 13 August 2013 20:34:48 CEST, Pali Rohár wrote: > > So what about chaging code > > disconnect(jobSecond, 0, 0, 0); > > to > > disconnect(jobSecond, 0, this, 0); > > Yes please. Done. -- Pali Rohár pali.ro...@gmail.com signa

Re: [trojita] Another GSoC review

2013-08-13 Thread Jan Kundrát
On Tuesday, 13 August 2013 20:34:48 CEST, Pali Rohár wrote: So what about chaging code disconnect(jobSecond, 0, 0, 0); to disconnect(jobSecond, 0, this, 0); Yes please. -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/

Re: [trojita] Re: Another GSoC review

2013-08-13 Thread Pali Rohár
On Friday 09 August 2013 18:15:41 Jan Kundrát wrote: > On Thursday, 8 August 2013 17:00:10 CEST, Pali Rohár wrote: > > As Kevin wrote, protection against emitting signals. > > Looking at the code, it seems to me that the only connections > are to ComposeWidget::completionDone which looks like a sa

[trojita] Re: master build fails?

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 19:57:29 CEST, Caspar Schutijser wrote: Weird. Do you really have the unmodified master branch? I hope so =) There's actually passwordWarning = new QLabel(scrollAreaWidgetContents); in ui_SettingsOutgoingPage.h BUT (hehe, sorry): There're relicts from qmake based

Re: [trojita] master build fails?

2013-08-13 Thread Caspar Schutijser
On Tuesday, August 13, 2013 7:44:58 PM CEST, Thomas Lübking wrote: /home/src/KDE4/trojita/src/Gui/SettingsDialog.cpp: In Konstruktor »Gui::OutgoingPage::OutgoingPage(QWidget*, QSettings&)«: /home/src/KDE4/trojita/src/Gui/SettingsDialog.cpp:509:5: Fehler: »passwordWarning« wurde in diesem Gültig

[trojita] Re: master build fails?

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 19:35:21 CEST, Caspar Schutijser wrote: What kind of error do you get? /home/src/KDE4/trojita/src/Gui/SettingsDialog.cpp: In Konstruktor »Gui::OutgoingPage::OutgoingPage(QWidget*, QSettings&)«: /home/src/KDE4/trojita/src/Gui/SettingsDialog.cpp:509:5: Fehler: »pa

Re: [trojita] master build fails?

2013-08-13 Thread Caspar Schutijser
On Tuesday, August 13, 2013 7:06:13 PM CEST, Thomas Lübking wrote: For a while now, patch attached but i'm unsure whether that's just something local? (Somebody would have noticed?) I didn't notice anything. In the past few days, I have been building Trojita quiet a couple of times but I have s

[trojita] master build fails?

2013-08-13 Thread Thomas Lübking
For a while now, patch attached but i'm unsure whether that's just something local? (Somebody would have noticed?) Cheers, Thomas From d85b06b93691d05b49ce8d8d55945058e7b35803 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20L=C3=BCbking?= Date: Sun, 11 Aug 2013 13:18:36 +0200 Subject: [PATCH

Re: [trojita] GSoC: plugins & loader

2013-08-13 Thread Pali Rohár
On Tuesday 13 August 2013 12:39:58 Jan Kundrát wrote: > On Tuesday, 13 August 2013 08:26:51 CEST, Pali Rohár wrote: > > Yes, I want to support also this configuration. But not only > > this. > > What are the benefits of this? "There will be no shared > library" is not a benefit, that's a statement

Re: [trojita] Re: GSoC: plugins & loader

2013-08-13 Thread Pali Rohár
On Tuesday 13 August 2013 13:57:48 Thomas Lübking wrote: > On Dienstag, 13. August 2013 12:39:58 CEST, Jan Kundrát wrote: > > - it works only on GCC > > Semi, see my other mail. > > > - the linker flags one needs could be considered hackish > > Yesno. > It's used to wrap static archives into sha

Re: [trojita] Re: GSoC: plugins & loader

2013-08-13 Thread Pali Rohár
On Tuesday 13 August 2013 13:43:14 Thomas Lübking wrote: > On Dienstag, 13. August 2013 08:26:51 CEST, Pali Rohár wrote: > > On Monday 12 August 2013 22:36:26 Jan Kundrát wrote: > >> They way I understand it, Pali wants to support a > >> configuration where there are no shared libraries, just the >

[trojita] Re: GSoC: plugins & loader

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 12:39:58 CEST, Jan Kundrát wrote: - it works only on GCC Semi, see my other mail. - the linker flags one needs could be considered hackish Yesno. It's used to wrap static archives into shared objects, esp. when using them for toolkits. It's (afaics) rather uncom

[trojita] Re: GSoC: plugins & loader

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 08:26:51 CEST, Pali Rohár wrote: On Monday 12 August 2013 22:36:26 Jan Kundrát wrote: They way I understand it, Pali wants to support a configuration where there are no shared libraries, just the /usr/bin/trojita with some plugins statically linked in. Yes, I wa

Re: [trojita] GSoC: CMake version & Kontact plugin

2013-08-13 Thread Jan Kundrát
On Tuesday, 13 August 2013 12:52:24 CEST, Pali Rohár wrote: Code for older cmake & gcc compiler is in my gsoc branch. So it could work. Can you test it (try to compile kontact kpart)? I can't -- my KDE requires new cmake, unfortunately. What we can do is making this build work in Travis, see t

Re: [trojita] GSoC: CMake version & Kontact plugin

2013-08-13 Thread Pali Rohár
On Tuesday 13 August 2013 12:30:44 Jan Kundrát wrote: > On Tuesday, 13 August 2013 08:48:27 CEST, Pali Rohár wrote: > > Anyway, on my akonadi testing machine I have ubuntu precise > > with > > backported > > > KDE and here I have cmake 2.8.9. I'm using kubuntu backport > > apt > > repository >

Re: [trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-13 Thread Jan Kundrát
On Tuesday, 13 August 2013 08:30:54 CEST, Pali Rohár wrote: I do not like idea to include compile output path into binaries. This sounds like that something is bad if some random path (=compile path) must be present in application executable. I asked for opinion, I got one -- thanks. I happen

Re: [trojita] GSoC: plugins & loader

2013-08-13 Thread Jan Kundrát
On Tuesday, 13 August 2013 08:26:51 CEST, Pali Rohár wrote: Yes, I want to support also this configuration. But not only this. What are the benefits of this? "There will be no shared library" is not a benefit, that's a statement of fact. I want to know *why* it is important to you to work wit

Re: [trojita] GSoC: CMake version & Kontact plugin

2013-08-13 Thread Jan Kundrát
On Tuesday, 13 August 2013 08:48:27 CEST, Pali Rohár wrote: Anyway, on my akonadi testing machine I have ubuntu precise with backported KDE and here I have cmake 2.8.9. I'm using kubuntu backport apt repository http://ppa.launchpad.net/kubuntu-ppa/backports/ubuntu/ and there is new cmake. So

Re: [trojita] Re: GSoC merge request

2013-08-13 Thread Pali Rohár
On Thursday 08 August 2013 09:49:37 Pali Rohár wrote: > > +void AkonadiAddressbook::openContactWindow(const QString > > &email, const QString &displayName) +{ > > +// TODO > > +#if 0 > > > > > > > > is this short-term todo or long term todo? (in latter case the > > feature should not be announ