[trojita] Another GSoC review

2013-07-12 Thread Jan Kundrát
Hi Pali, looking at the work you've done so far. First of all, it looks great -- I believe that you're on a good track. - Why are TrojitaPluginJob::start/stop postponing the actual operation via the event loop? I'm not saying it's bad, but I'm wondering why. A comment explaining this would be

Re: [trojita] Re: GSoC review

2013-07-12 Thread Pali Rohár
On Wednesday 10 July 2013 21:08:19 Thomas Lübking wrote: > On Mittwoch, 10. Juli 2013 20:52:20 CEST, Caspar Schutijser wrote: > > I don't know if someone has another opinion on this? > > The problem with the KABC plugin is that it seems to be > unusable with a few months (but on older distros) -

Re: [trojita] GSoC review

2013-07-12 Thread Pali Rohár
On Friday 12 July 2013 19:38:50 Thomas Lübking wrote: > >> +disconnect(job, 0, 0, 0); > >> +job->stop(); > >> +++ // TODO how do the get off the hash? > > > > QLineEdit is asociated with job. So other option could be to > > move job pointer to new class inhered by QLineEdit. > >

Re: [trojita] GSoC review

2013-07-12 Thread Thomas Lübking
> >> +disconnect(job, 0, 0, 0); >> +job->stop(); >> +++ // TODO how do the get off the hash? > > QLineEdit is asociated with job. So other option could be to move > job pointer to new class inhered by QLineEdit. That doesn't scale because everytime you want to change the assiciati

Re: [trojita] GSoC review

2013-07-12 Thread Pali Rohár
Hello, On Friday 12 July 2013 01:28:21 Thomas Lübking wrote: > Hi Pali > > Following some comments on the branch. > I read the diff and wrote them in a train so it's rather brief > ;-) > > On a general note, anyc API in a loop of course sucks but it > might still worth trying to get rid of the n