Hi Pali,
On Monday, July 8, 2013 6:10:36 PM CEST, Pali Rohár wrote:
today I cleaned my git tree and created new (rebased) branch
which is ready for comments and then for merging to master.
One piece of feedback for now.
If I do this:
1) Go to Settings.
2) Select "None - Disable passwords" at
On Monday, 2013-07-08, Pali Rohár wrote:
> On Monday 08 July 2013 16:37:31 Kevin Krammer wrote:
> > On Monday, 2013-07-08, Pali Rohár wrote:
> > > On Thursday 04 July 2013 18:38:40 Kevin Krammer wrote:
> > > > Hi,
> > > >
> > > > I had a look at the current state of the integration
> > > > clone.
Hello,
today I cleaned my git tree and created new (rebased) branch which is ready for
comments and then for merging to master.
My GSoC work is in branch pali-gsoc-merge in repository:
git://anongit.kde.org/clones/trojita/pali/trojita.git
Web link to kde quickgit:
http://quickgit.kde.org/?p=clo
On Monday 08 July 2013 16:37:31 Kevin Krammer wrote:
> On Monday, 2013-07-08, Pali Rohár wrote:
> > On Thursday 04 July 2013 18:38:40 Kevin Krammer wrote:
> > > Hi,
> > >
> > > I had a look at the current state of the integration
> > > clone.
> > >
> > > TrojitaPluginJob.h
> > >
> > > - autoDele
On Monday, 2013-07-08, Pali Rohár wrote:
> On Thursday 04 July 2013 18:38:40 Kevin Krammer wrote:
> > Hi,
> >
> > I had a look at the current state of the integration clone.
> >
> > TrojitaPluginJob.h
> >
> > - autoDelete() and isRunning() should be const and normal
> > public method (not slots)
On Monday, 2013-07-08, Pali Rohár wrote:
> On Saturday 29 June 2013 16:02:59 Kevin Krammer wrote:
> > - AbookAddressbook has lots of public API that is not in
> > AddressbookInterface (e.g. model).
>
> It is needed in AddressbookInterface (somewhere for Trojita)? Or
> where is problem? AbookAddre
On Saturday 29 June 2013 16:02:59 Kevin Krammer wrote:
> On Saturday, 2013-06-29, Pali Rohár wrote:
> > > - Not sure whether you need to #include ;
> > > perhaps a forward declaration is enough (haven't checked,
> > > might be wrong)
> >
> > This will not work, because in class is full QPointer ob
On Thursday 04 July 2013 18:38:40 Kevin Krammer wrote:
> Hi,
>
> I had a look at the current state of the integration clone.
>
> TrojitaPluginJob.h
>
> - autoDelete() and isRunning() should be const and normal
> public method (not slots).
>
Ok, changed.
> - I am not sure calling stop() in the
