Thanks Albert for merging it.
Yes it's not finished and I'm intending to pick up last summer's work on the
glib frontend part.
I agree that we should close this bug and open specific ones to track
the frontend development or any other issue we find with the core code.
--
You received this bug
Created attachment 120992
Load NSS root certs module
This change is needed to actually do certificate validation, because as
it is NSS is trying to load the module which contains all the builtin
root certs from the Firefox profile directory where it is usually
missing. This way it will load the mo
I'm in favour of Adrian's patch. It's an improvement with additional sanity
checks on the ByteRange values.
Indeed I tried to see if you could check if a given ByteRange covers the whole
document and also found no easy way to do it with existing poppler
functions/APIs.
--
You received this bu
Created attachment 120434
Improve robustness of SignatureHandler::validateCertificate
This patch adds additional NULL-checking in
SignatureHandler::validateCertificate() which avoids segfault for some
signatures like the one contained here:
http://www.gpo.gov/fdsys/pkg/BUDGET-2015-BUD/pdf/BUDGET-2
(In reply to Adrian Johnson from comment #79)
> + r_values[0] = r2.isInt64() ? r2.getInt64() : r2.getInt();
> + r_values[1] = r3.isInt64() ? r3.getInt64() : r3.getInt();
> + r_values[2] = r4.isInt64() ? r4.getInt64() : r4.getInt();
>
> According the PDF Reference, the ByteRange array contains
Created attachment 119283
Manpage improvement
Here's an improvement to the manpage.
Corrected a typo and added some missing context
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.ne
Created attachment 118745
Incremental hashing + large file support
With this patch I've implemented the incremental hashing plus the large
file support.
This is still untested with files larger than 2GB but is correct for all
the regular test cases I gathered before.
--
You received this bug no
Created attachment 118446
NSS conditional build
This patch makes the NSS dependency optional in the CMake and Autotools
build systems.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.
Created attachment 118449
Support for adbe.pkcs7.sha1 signatures
This patch, to be applied over the previous one, adds support for
adbe.pkcs7.sha1 signatures so now we should have a more complete
coverage of actual signed PDFs.
--
You received this bug notification because you are a member of Ub
Created attachment 118398
Fix for Buffer overflow
Regarding the illegal ByteRange values which would cause overflow this
patch should fix it
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to poppler in Ubuntu.
https://bugs.laun
@Adrian
Thanks for the tips on support for large files, progressive hashing and
the NSS includes. We'll be posting our attempts to improve these issues
as individual patches.
I also thought of adding the feature to pdfinfo but it seems wrong to
mix up something which performs various computations
@Albert
Thanks for the improvements.
Regarding your 3 questions:
1- I've no objection to make the feature optional. I understand there
are people building more minimal versions of poppler that dislike
additional dependencies.
2- Yes we should. Our defaults are meant to take advantage of the
alre
Created attachment 118193
poppler nss signature support - v5 - refactor
Here's a new patch following Albert's recommendations.
We've expanded the FormFieldSignature and FormFieldWidget classes to expose the
signature method.
We also added checking for non-supported signature types as we only
sup
Created attachment 118195
poppler nss signature support - v6
Sorry, there were still some missing NULL checks and a useless new(),
here's a new one.
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to poppler in Ubuntu.
https://b
Created attachment 118036
poppler nss signature support - v3
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/740506
Title:
verify digital signatures
Status in Evince:
C
Sorry for the succession of patches. This one fixes some remaining leaks
in the new PDFDoc methods and improves the indentation
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs
Sorry for the long absence and here's another attempt at solving this
issue.
I just attached a patch developed by me and André Esser which adds signature
verification support to poppler core and the glib frontend.
It uses the NSS CMS API for the crypto operations (signature and certificate
Valid
Created attachment 117885
PDF signature verification using NSS
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/740506
Title:
verify digital signatures
Status in Evince:
18 matches
Mail list logo
