cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java JspCompiler.java

2003-07-01 Thread marcsaeg
marcsaeg2003/07/01 13:59:02 Modified:src/share/org/apache/jasper/compiler Tag: tomcat_32 Compiler.java JspCompiler.java Log: Avoid multiple calls to isOutDated(). Avoid multiple string concatenations in getPackageName(). Revision ChangesPath No

cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java JspParseEventListener.java JspReader.java

2001-03-09 Thread marcsaeg
marcsaeg01/03/09 15:35:26 Modified:src/share/org/apache/jasper/compiler Tag: tomcat_32 Compiler.java JspParseEventListener.java JspReader.java Log: Change JSP default character encoding from 8859_1 to ISO-8859-1 which is the preferre

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Craig R. McClanahan
"Scott M. Stirling" wrote: > On 05 Jan 2001 16:35:09 -0800, Hans Bergsten wrote: > > "Scott M. Stirling" wrote: > > > 1. Doesn't it seem a bit sloppy to leave a bunch of classes loaded that > > > will never get dumped unless the server is shutdown? Just a matter of > > > elegance, I suppose. > >

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Glenn Nielsen
"Scott M. Stirling" wrote: > > On 05 Jan 2001 16:35:09 -0800, Hans Bergsten wrote: > > "Scott M. Stirling" wrote: > > > 1. Doesn't it seem a bit sloppy to leave a bunch of classes loaded that > > > will never get dumped unless the server is shutdown? Just a matter of > > > elegance, I suppose. >

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread M.
On 05 Jan 2001 16:35:09 -0800, Hans Bergsten wrote: > "Scott M. Stirling" wrote: > > 1. Doesn't it seem a bit sloppy to leave a bunch of classes loaded that > > will never get dumped unless the server is shutdown? Just a matter of > > elegance, I suppose. [Hans Bergsten] > Yes, it does. But AFA

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Hans Bergsten
"Scott M. Stirling" wrote: > > OK, I am thinking this is a pretty good idea now too, since seeing your > and Marc's emails. My last two thoughts on the matter (just playing Devil's > advocate): That's good. It's easy to overlook some problems. > 1. Doesn't it seem a bit sloppy to leave a bun

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread M.
OK, I am thinking this is a pretty good idea now too, since seeing your and Marc's emails. My last two thoughts on the matter (just playing Devil's advocate): 1. Doesn't it seem a bit sloppy to leave a bunch of classes loaded that will never get dumped unless the server is shutdown? Just a mat

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Hans Bergsten
Scott Stirling wrote: > > I agree with Craig. > > The ability to run JSP apps without any source JSPs must be maintained > for app vendors who want to ship without source code. Not sure if this > patch would interfere with that or not. It shouldn't; if you want to distribute JSP pages without

RE: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Marc Saegesser
> -Original Message- > From: Scott Stirling [mailto:[EMAIL PROTECTED]] > Sent: Friday, January 05, 2001 3:58 PM > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: > jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java > > > I agree with Craig. >

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Scott Stirling
I agree with Craig. The ability to run JSP apps without any source JSPs must be maintained for app vendors who want to ship without source code. Not sure if this patch would interfere with that or not. A separate issue: if a user removes the source JSP, it may be OK to remove the JSP class file

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Craig R. McClanahan
[EMAIL PROTECTED]] > > Sent: Friday, January 05, 2001 1:16 PM > > To: [EMAIL PROTECTED] > > Subject: Re: cvs commit: > > jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java > > > > > > [EMAIL PROTECTED] wrote: > > > > > marcsaeg

RE: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Marc Saegesser
ilto:[EMAIL PROTECTED]] > Sent: Friday, January 05, 2001 1:16 PM > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: > jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java > > > [EMAIL PROTECTED] wrote: > > > marcsaeg01/01/05 10:04:37 > > > > M

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread Craig R. McClanahan
[EMAIL PROTECTED] wrote: > marcsaeg01/01/05 10:04:37 > > Modified:src/share/org/apache/jasper/compiler Tag: tomcat_32 > Compiler.java > Log: > Added a method to remove the generated .class file. This will be called > to remove generated files in the event

cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler Compiler.java

2001-01-05 Thread marcsaeg
marcsaeg01/01/05 10:04:37 Modified:src/share/org/apache/jasper/compiler Tag: tomcat_32 Compiler.java Log: Added a method to remove the generated .class file. This will be called to remove generated files in the event that the associated JSP page is removed