cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java StandardManager.java

2005-06-16 Thread remm
remm2005/06/16 02:50:12 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java StandardManager.java Log: - 34760: Passivating session should not make stop fail. Revision ChangesPath 1.60 +3 -2 jakarta-tomcat

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-06-15 Thread luehe
luehe 2005/06/15 16:50:12 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverted the scope of readObject() and writeObject() from protected to private, in order to give subclasses an opportunity to implement their own

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-06-15 Thread luehe
luehe 2005/06/15 16:41:25 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: After deserializing a StandardSession, reinit its transient "listeners" and "notes" fields, to prevent NPEs when they are acc

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2005/03/25 08:49:28 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Commented out session validity check in StandardSession.getId(). Will revisit for 5.5.10. There will be two options for the

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-25 Thread luehe
luehe 2005/03/25 08:49:28 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Commented out session validity check in StandardSession.getId(). Will revisit for 5.5.10. Revision ChangesPath 1.55 +4 -1

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties StandardSession.java

2005-03-24 Thread Remy Maucherat
StandardSession.java Log: Fixed getId() so that it throws IllegalStateException when called on an invalidated session, in order to be compliant with item 2 ("Fix typos in HttpSession.java") of the Servlet 2.4 Errata at http://jcp.org/aboutJava/communityprocess/maintenance/jsr154

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties StandardSession.java

2005-03-24 Thread Remy Maucherat
StandardSession.java Log: Fixed getId() so that it throws IllegalStateException when called on an invalidated session, in order to be compliant with item 2 ("Fix typos in HttpSession.java") of the Servlet 2.4 Errata at http://jcp.org/aboutJava/communityprocess/maintenance/jsr154

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-23 Thread Jan Luehe
Yoav, Yoav Shapira wrote: > Hola, > > >>My believe is that the above errata will be reflected in the next >>(maintenance) release of the servlet spec. I will remind the servlet >>spec lead that this needs to happen. >> >>Jan > > > What's the ETA on this maintenance spec release? work is suppo

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties StandardSession.java

2005-03-23 Thread luehe
luehe 2005/03/23 14:44:14 Modified:catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties StandardSession.java Log

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Yoav Shapira
Hola, > My believe is that the above errata will be reflected in the next > (maintenance) release of the servlet spec. I will remind the servlet > spec lead that this needs to happen. > > Jan What's the ETA on this maintenance spec release? Yoav ---

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Jan Luehe
tomcat-catalina/catalina/src/share/org/apache/catalina/session >>StandardSession.java >> >> >> >>>[EMAIL PROTECTED] wrote: >>> >>> >>>>billbarker2005/03/21 19:50:03 >>>> >>>> Modified:catalina/src/shar

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Tuesday, March 22, 2005 7:46 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java [EMAIL PR

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: billbarker2005/03/22 07:26:44 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverting change. Note to self: Next time check the errata as well as -fr I think someone closer to the spec needs to

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread billbarker
billbarker2005/03/22 07:26:44 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverting change. Note to self: Next time check the errata as well as -fr Revision ChangesPath 1.53 +6 -2 jakarta

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Remy Maucherat
Bill Barker wrote: - Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Tuesday, March 22, 2005 1:57 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSessi

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Tuesday, March 22, 2005 1:57 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java [EMAIL PR

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: billbarker2005/03/21 19:50:03 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: From the comments for R1.11, it seems that some early version of the spec had an exception here. However, this didn&#

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-21 Thread billbarker
billbarker2005/03/21 19:50:03 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: From the comments for R1.11, it seems that some early version of the spec had an exception here. However, this didn't survive to the final

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-21 Thread remm
remm2005/03/21 12:02:21 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Undo change. Revision ChangesPath 1.51 +4 -4 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-21 Thread Bill Barker
- Original Message - From: <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, March 21, 2005 8:25 AM Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java > remm2005/03/21 08:25:53 > > Modi

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-21 Thread remm
remm2005/03/21 08:25:53 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - 34107: I would think the session should still be seen as valid when notifying attributes of unbinding. - Does this cause regressions or not

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session DistributedManager.java FileStore.java ManagerBase.java PersistentManager.java PersistentManagerBase.java StandardManager.java StandardSession.java StandardSessionFacade.java

2005-02-14 Thread markt
StandardSession.java StandardSessionFacade.java Log: Clean up Eclipse warnings for o.a.c.session - remove unused imports - static access warnings Revision ChangesPath 1.7 +3 -8 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

2004-11-22 Thread jfarcand
SecurityUtil.java catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java Log: Port patch from Tomcat 5.0: When the package protection is not used, do not create the

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

2004-11-19 Thread Jean-Francois Arcand
Remy Maucherat wrote: Jean-Francois Arcand wrote: It's not useless. Normal permissions are still turned on. It's only the package protection that is disabled. When disabled, Tomcat 5 is as unsecure as Tomcat 4 in term of sniffing/loading classes, but still secure in term of browsing the file sy

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

2004-11-19 Thread Remy Maucherat
Jean-Francois Arcand wrote: It's not useless. Normal permissions are still turned on. It's only the package protection that is disabled. When disabled, Tomcat 5 is as unsecure as Tomcat 4 in term of sniffing/loading classes, but still secure in term of browsing the file system etc. Possibly. But

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

2004-11-19 Thread Jean-Francois Arcand
Remy Maucherat wrote: Jean-Francois Arcand wrote: Actually, my next steps is to allows empty field in catalina.properties, which will disable the mechanism (next commit :-)). Right now you can only disable the mechanism by removing the catalina.properties or if you use the Embedded interfance.

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

2004-11-19 Thread Remy Maucherat
Jean-Francois Arcand wrote: Actually, my next steps is to allows empty field in catalina.properties, which will disable the mechanism (next commit :-)). Right now you can only disable the mechanism by removing the catalina.properties or if you use the Embedded interfance. By default I still wan

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

2004-11-18 Thread Remy Maucherat
StandardSession.java Log: When the package protection is not used, do not create the doPrivileged objects so we don't suffer the performance hit (15% faster with trade2 and this change). Also fixed a memory leak when security manager is turned on. Fixing leaks is good :) I have a question: C

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

2004-11-18 Thread jfarcand
StandardSession.java Log: When the package protection is not used, do not create the doPrivileged objects so we don't suffer the performance hit (15% faster with trade2 and this change). Also fixed a memory leak when security manager is turned on. Revision ChangesPath No rev

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java StandardSession.java StandardManager.java mbeans-descriptors.xml

2004-09-07 Thread luehe
luehe 2004/09/07 13:57:03 Modified:catalina/src/share/org/apache/catalina Manager.java catalina/src/share/org/apache/catalina/session ManagerBase.java StandardSession.java StandardManager.java mbeans-descriptors.xml Log

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java StandardSession.java mbeans-descriptors.xml

2004-09-02 Thread luehe
luehe 2004/09/02 17:53:02 Modified:catalina/src/share/org/apache/catalina Manager.java catalina/src/share/org/apache/catalina/session ManagerBase.java StandardSession.java mbeans-descriptors.xml Log: Added longest time

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session Constants.java DistributedManager.java FileStore.java JDBCStore.java ManagerBase.java PersistentManager.java PersistentManagerBase.java StandardManager.java StandardSession.java StandardSessionFacade.java StoreBase.java

2004-08-26 Thread markt
PersistentManagerBase.java StandardManager.java StandardSession.java StandardSessionFacade.java StoreBase.java Log: Update TC4 branch to Apache License 2.0. Revision ChangesPath 1.4 +13 -56 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-07-15 Thread remm
remm2004/07/15 07:42:39 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - I looked in the spec, and I don't think the notifications should be sent when "replacing" an attribute with the same instanc

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-06-02 Thread remm
remm2004/06/02 03:18:21 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Replace "this" with "getSession()" as suggested by Filip. Revision ChangesPath 1.44 +11 -9 jakarta-tomc

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-05-01 Thread Remy Maucherat
Glenn Nielsen wrote: Please accept my apology for that one. Accepted. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-05-01 Thread Glenn Nielsen
On Sat, May 01, 2004 at 06:39:15PM +0200, Remy Maucherat wrote: > Glenn Nielsen wrote: > >I dont' care what you think of me personally. But when your animosity > >towards me impacts Tomcat I had to say something. > > I'm sure it fully justifies the "egotistical piece of shit like you" > comment ;

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-05-01 Thread Remy Maucherat
Glenn Nielsen wrote: I dont' care what you think of me personally. But when your animosity towards me impacts Tomcat I had to say something. I'm sure it fully justifies the "egotistical piece of shit like you" comment ;) Jon is funny at least, but this is just pathetic. Rémy

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-05-01 Thread Glenn Nielsen
On Sat, May 01, 2004 at 02:26:34PM +0200, Remy Maucherat wrote: > Glenn Nielsen wrote: > >Remy, > > > >I am sick and tired of your crap. For whatever reason you don't like > >any of my contributions. You always try to find some way to justify > >a -1 of anything I contribute. Frankly you are the

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-05-01 Thread Remy Maucherat
Glenn Nielsen wrote: Remy, I am sick and tired of your crap. For whatever reason you don't like any of my contributions. You always try to find some way to justify a -1 of anything I contribute. Frankly you are the main reason why I rarely contribute to Tomcat any more. I just got tired of deal

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread Glenn Nielsen
Apr 30, 2004, at 1:15 PM, [EMAIL PROTECTED] wrote: > > >glenn 2004/04/30 12:15:26 > > > > Modified:catalina/src/share/org/apache/catalina/session > >JDBCStore.java PersistentManagerBase.java > >Standa

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread Glenn Nielsen
ava PersistentManagerBase.java > > StandardManager.java StandardSession.java > >StoreBase.java > > Log: > > The JDBCStore required a great deal of unnecessary db > > queries to manage the persisted data. This could severly > > impact its a

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread Remy Maucherat
Tom Anderson wrote: I'm just a list lurker (so my opinion doesn't "count") but I'm really happy to see these fixes. I have had to override JDBCStore and PersistentManagerBase at my site to make similar fixes so that things work acceptably (yes, I submitted patches but they weren't accepted).

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread Tom Anderson
JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java Log: The JDBCStore required a great deal of unnecessary db queries to manage the persisted data. This could severly impact its abilit

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread Remy Maucherat
Filip Hanik - Dev wrote: And of course you don't discuss this before making the change ? This is the old branch, so this is clearly not acceptable. I have to -1 regardless of the possible merits. Ok, so he forgot to ask the developers if this would be ok, no big deal. Can happen to anybody. But if

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread Filip Hanik - Dev
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> >And of course you don't discuss this before making the change ? >This is the old branch, so this is clearly not acceptable. >I have to -1 regardless of the possible merits. Ok, so he forgot to ask the developers if this woul

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: glenn 2004/04/30 12:15:26 Modified:catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java Log

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2004-04-30 Thread glenn
glenn 2004/04/30 12:15:26 Modified:catalina/src/share/org/apache/catalina/session JDBCStore.java PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java Log: The JDBCStore required

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread jfarcand
jfarcand2004/04/01 12:18:15 Modified:catalina/src/share/org/apache/catalina Globals.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: Re-add initinal work since it doesn't seems to work (my bad) Than

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread daniel andefors
From: Jeanfrancois Arcand <[EMAIL PROTECTED]> Reply-To: "Tomcat Developers List" <[EMAIL PROTECTED]> To: Tomcat Developers List <[EMAIL PROTECTED]> Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread Jeanfrancois Arcand
t. Thanks! -- Jeanfrancois Daniel From: [EMAIL PROTECTED] Reply-To: "Tomcat Developers List" <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java Date: 1 Apr 2004 17:39:53 - jf

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread daniel andefors
mcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java Date: 1 Apr 2004 17:39:53 - jfarcand2004/04/01 09:39:53 Modified:catalina/src/share/org/apache/catalina Globals.java catalina/src/share/org/apache/catalina/session

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread jfarcand
jfarcand2004/04/01 09:39:53 Modified:catalina/src/share/org/apache/catalina Globals.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: Minor fixe. Instead of using an exclude list, make the variable transient

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-25 Thread markt
markt 2004/03/25 14:17:54 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Fix bug 18479. Non-serializable sessions attributes should be removed (so valueUnbound is called). This aligns the actual functionality with

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-25 Thread markt
markt 2004/03/25 14:15:45 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Fix bug 18479. Non-serializable sessions attributes should be removed (so valueUnbound is called). This aligns the actual functionality with

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-12 Thread luehe
luehe 2004/03/12 14:36:46 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: set accessCount to 0 (instead of 1) in recycle() Revision ChangesPath 1.40 +2 -2 jakarta-tomcat-catalina/catalina/src/share

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-11 Thread luehe
luehe 2004/03/11 11:56:52 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverted previous change, as it breaks the fix for Bugzilla 26051. Test case for Bugtraq 4839736 (see revision 1.20) is invalid. Revision

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-11 Thread Jan Luehe
Remy Maucherat wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 ("HttpSession.setMaxInactiveInt

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-10 Thread Remy Maucherat
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 ("HttpSession.setMaxInactiveInterval() doesn't

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-10 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 ("HttpSession.setMaxInactiveInterval() doesn't behave as expected"),

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-10 Thread luehe
luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 ("HttpSession.setMaxInactiveInterval() doesn't behave as expected"), which had been orig

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-04 Thread jfarcand
jfarcand2004/03/04 09:51:16 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Avoid serializing Subject/Principal when persisting the session. Revision ChangesPath 1.36 +27 -2 jakarta-tomcat-catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session LocalStrings.properties StandardSession.java

2004-02-12 Thread markt
markt 2004/02/12 12:54:21 Modified:catalina/src/share/org/apache/catalina/session LocalStrings.properties StandardSession.java Log: Fix bug 14283. Catch and log exceptions in listeners. Reported by Eddie Ruvinsky. Ported from TC4. Revision Changes

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session LocalStrings.properties StandardSession.java

2004-02-12 Thread markt
markt 2004/02/12 12:52:52 Modified:catalina/src/share/org/apache/catalina/session LocalStrings.properties StandardSession.java Log: Fix bug 14283. Catch and log exceptions in listeners. Reported by Eddie Ruvinsky. Revision ChangesPath 1.13

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java PersistentManagerBase.java StandardSession.java PersistentManager.java ManagerBase.java

2004-01-26 Thread remm
remm2004/01/26 11:47:48 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java PersistentManagerBase.java StandardSession.java PersistentManager.java ManagerBase.java Log: - Remove

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-23 Thread remm
remm2004/01/23 14:29:32 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Bug 26341: When calling the removeAttributes during session expiration, notified attributes should see the session as invalid. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-22 Thread remm
remm2004/01/22 10:21:21 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Improvements to session activity tracking, handling the case where the session is new, as well as cross context. - If this doesn't wo

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-21 Thread remm
remm2004/01/21 02:46:59 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Remove some synchronization. - Avoid useless event objects allocation. - Minimize the amount of hashmap lookups. - Bug 26051: session must

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-19 Thread remm
remm2004/01/19 15:39:05 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Don't call expire after calling isValid. - Bug 26261, submitted by Paul Harvey. Revision ChangesPath 1.29 +5 -11 ja

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-19 Thread Mark Thomas
> My hair splitting detector is beeping. > > This session code will need to be optimized, BTW. Will do. Tomorrow OK? > > Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-18 Thread Mark Thomas
Resending from right account. > My hair splitting detector is beeping. > > This session code will need to be optimized, BTW. Will do. Tomorrow OK? > > Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-18 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: markt 2004/01/18 12:37:52 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Fix bug 12363. valueBound() must be called before the object is made available via getAttribute() . Submitted by

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-18 Thread markt
markt 2004/01/18 12:38:35 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Fix bug 12363. valueBound() must be called before the object is made available via getAttribute() . Submitted by: Pablo Morales - Port from

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-18 Thread markt
markt 2004/01/18 12:37:52 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Fix bug 12363. valueBound() must be called before the object is made available via getAttribute() . Submitted by: Pablo Morales Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-12-31 Thread remm
remm2003/12/31 13:24:56 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Bug 25792: Fix session timeout implementation, which could lead to incorrect invalidation in some cases. - Submitted by Jarno Peltoniemi

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java

2003-11-29 Thread remm
remm2003/11/29 10:06:35 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java Log: - private -> protected. A lot of this package should be protected, as there could be an good use case to reuse code

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-11-25 Thread remm
remm2003/11/24 23:56:27 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - It seems that, for consistency, getLastAccessedTime should not throw an ISE while expiring. This allows addressing bug 9077. - Patch

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-10-02 Thread jfarcand
jfarcand2003/10/02 18:53:17 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: We also need to call the listener when the session is invalidated because we can't predict the interval between the time the session is m

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-10-02 Thread jfarcand
jfarcand2003/10/02 10:10:54 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fix for bugzilla 23525 HttpSessionListener implementors are called to late according to Servlet Specification 2.4 Final Draft 3. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java

2003-08-26 Thread remm
remm2003/08/26 07:18:54 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java Log: - Revert my previous fix. I think it could cause sessions to not be invalidated properly. - Instead, don't chec

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/sessionPersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2003-08-19 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2003/08/18 17:49:58 Modified:catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java Log: Fixed Bugtraq 4839736

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java

2003-08-18 Thread luehe
luehe 2003/08/18 17:49:58 Modified:catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java StoreBase.java Log: Fixed Bugtraq 4839736 ("HttpSession.setMaxInactiveInt

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-08-10 Thread remm
catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Split the applicationListeners array in two, for performance reasons. Revision ChangesPath 1.9 +29 -8 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Context.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java PersistentManagerBase.java StandardManager.java StandardSession.java

2003-07-07 Thread remm
remm2003/07/07 23:28:02 Modified:catalina/src/share/org/apache/catalina/session ManagerBase.java PersistentManagerBase.java StandardManager.java StandardSession.java Log: - Remove session recycling. Revision ChangesPath

StandardSession.java

2003-06-04 Thread Shankar
? java.lang.IllegalStateException: removeAttribute: Session already invalidated at org.apache.catalina.session.StandardSession.removeAttribute(StandardSession.java:1052) at org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1152) at

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-03-12 Thread luehe
luehe 2003/03/12 18:26:32 Modified:catalina/src/share/org/apache/catalina/core StandardHostValve.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed Bugtraq 4661001

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-03-11 Thread jfarcand
jfarcand2003/03/11 19:53:15 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Forgot to commit this one. Add a doPrivileged block. Revision ChangesPath 1.14 +18 -6 jakarta-tomcat-catalina/catalina/src

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-02-18 Thread luehe
luehe 2003/02/18 16:33:28 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fix for Bugtraq 4688277: Invoking session.invalidate() after setting max inactive interval to 0 does not throw IllegalStateException The

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session FileStore.java JDBCStore.java ManagerBase.java PersistentManagerBase.java StandardSession.java

2003-02-11 Thread jfclere
StandardSession.java Log: Correct problems related to the persistence of sessions: Revision ChangesPath 1.9 +10 -4 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/Manager.java Index: Manager.java === RCS

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-02-10 Thread remm
remm2003/02/10 01:59:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Disable session recycling for now. Revision ChangesPath 1.34 +9 -4 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-02-10 Thread remm
remm2003/02/10 01:59:01 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Experiment: add some syncing in Session.expire. Revision ChangesPath 1.12 +58 -49 jakarta-tomcat-catalina/catalina/src/share

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_fr.properties StandardSession.java

2003-01-10 Thread jfarcand
jfarcand2003/01/10 18:50:06 Modified:catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_fr.properties StandardSession.java Log: According to the javadocs for HttpSession.getLastAccessedTime(), and

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-12-31 Thread glenn
glenn 2002/12/31 04:55:21 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: oops, revert last change Revision ChangesPath 1.33 +5 -5 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-12-31 Thread glenn
glenn 2002/12/31 04:53:45 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: oops, revert last change Revision ChangesPath 1.10 +5 -5 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-12-31 Thread glenn
glenn 2002/12/31 04:48:24 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fix typo in LocalStrings property Revision ChangesPath 1.9 +5 -5 jakarta-tomcat-catalina/catalina/src/share/org/apache

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-12-31 Thread glenn
glenn 2002/12/31 04:44:05 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fix typo in LocalStrings property Revision ChangesPath 1.32 +5 -5 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardSession.java

2002-12-12 Thread jfclere
jfclere 2002/12/12 07:11:53 Modified:catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardSession.java Log: Calling session.setId() was removing the session from the store. Revision ChangesPath 1.6 +6 -5

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java StandardSession.java DistributedManager.java

2002-12-05 Thread remm
remm2002/12/05 05:52:51 Modified:catalina/src/share/org/apache/catalina/session ManagerBase.java StandardSession.java Removed: catalina/src/share/org/apache/catalina/session DistributedManager.java Log: - Allow extending

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-11-26 Thread jfarcand
jfarcand2002/11/26 11:56:10 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Change HttpSessionListener.sessionDestroyed() from notifying after the invalidation to notifying before the invalidation (Servlet 2.4 spec change

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-08-29 Thread bobh
bobh2002/08/29 15:23:38 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - fix for some of bug 12147 Namely, logout() was deferring to the SingleSignOn bit to perform the logout - however if SingleSignOn isn't

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-08-12 Thread patrickl
patrickl2002/08/12 12:12:44 Modified:catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: This patch causes logout() and

  1   2   >