Re: [VOTE] Proposed API change to the Manager interface

2005-02-10 Thread Remy Maucherat
Rainer Jung wrote: I have the impression you fixed the jvmRoute in the new Session(-Id) in ManagerBase, but not in DeltaManager? Even when the context is distributable one might prefer to stick the session to the node where it now originates. You mean the commented out code ? It would need to be cu

Re: [VOTE] Proposed API change to the Manager interface

2005-02-09 Thread Rainer Jung
I have the impression you fixed the jvmRoute in the new Session(-Id) in ManagerBase, but not in DeltaManager? Even when the context is distributable one might prefer to stick the session to the node where it now originates. Furthermore: I did not really understand the use case of emptySessionPath,

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Rainer Jung
Upgrading mod_jk would be possible (not too complicated), but I'm afraid we are going to break other products we don't control the way we do with mod_jk. mod_jk is a good example to see, why it's not unlikely that changes would be needed for other balancers. Rainer Remy Maucherat wrote: Filip Hanik

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Rainer Jung
a dark basement somewhere :) Whatever the change you decide on, I'll be happy to implement it and test it for the cluster stuff Filip - Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Monday, February 07,

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Remy Maucherat
Filip Hanik - Dev wrote: its not at all that complicated. This is how a big5 load balancer does it. A) it sets a cookie, and based on the cookie it load balances. B) if a cookie is not supported, it does a calculation based on the IP address, and stays sticky that way. No need to exchange any info

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Filip Hanik - Dev
Maucherat" <[EMAIL PROTECTED]> > To: "Tomcat Developers List" > Sent: Monday, February 07, 2005 11:34 AM > Subject: Re: [VOTE] Proposed API change to the Manager interface > > > >>@@ -744,15 +747,17 @@ >> session.setValid(true); >

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Rainer Jung
the change you decide on, I'll be happy to implement it and test it for the cluster stuff Filip - Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Monday, February 07, 2005 11:34 AM Subject: Re: [VOTE] Proposed A

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Filip Hanik - Dev
7;ll be happy to implement it and test it for the cluster stuff Filip - Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Monday, February 07, 2005 11:34 AM Subject: Re: [VOTE] Proposed API change to th

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Remy Maucherat
Peter Rossbach wrote: Hmm, I think that Remy's patch is working correct. But I think we must controll the jvmRoute from those client sessions id's (ManagerBase include this at a comment :-)). I must check my cluster failover szenarios. I can to that tomorrow. Yes, I don't know if it is needed or

Re: [VOTE] Proposed API change to the Manager interface

2005-02-08 Thread Peter Rossbach
Hmm, I think that Remy's patch is working correct. But I think we must controll the jvmRoute from those client sessions id's (ManagerBase include this at a comment :-)). I must check my cluster failover szenarios. I can to that tomorrow. Peter Rainer Jung schrieb: Both Cluster Managers (Delta and

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Remy Maucherat
Bill Barker wrote: I'd be happier if this was conditional on emptySessionPath="true" (or otherwise could be disabled). Otherwise I have to trust that the browser doesn't have some JavaScript and/or IFrame bug that allows a Cookie to be sent. I think it should be safe, but once in a while there's a

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Rainer Jung
Both Cluster Managers (Delta and SimpleTcpReplication) extend ManagerBase but override createSession(). Maybe Filip or Peter can check how to make them long-time compatible with your proposal? > Managers extending ManagerBase should work and compile as before with no changes unless they override

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Monday, February 07, 2005 8:57 AM Subject: Re: [VOTE] Proposed API change to the Manager interface >Tim Funk wrote: >> If I read this correctly (big if

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Yoav Shapira
Hi, > Right, that's what I tried at first. However, session tracking would > break in mysterious ways whenever emptySessionPath is used if we did > that. So I considered it was better to remove the method to signal some > change is needed. > > That was my idea, but I'm ok with adding back the

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Remy Maucherat
Yoav Shapira wrote: Hi, However, the problem is that I need to modify a method in the top level Manager interface :( public Session createSession() must become: public Session createSession(String sessionId) (if sessionId is null, a new session id will be generated) As the createSession() will no

Re: RE: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread bounce
Geachte relatie, Het door u gebruikte e-mailadres is niet meer actief. U kunt uw e-mailbericht sturen naar [EMAIL PROTECTED] of dit bericht beantwoorden. Bedankt voor uw medewerking, Met vriendelijke groet, ATP Hypotheken Het Spoor 40 3994 AK Houten Tel. 030 750 25 33 Fax. 030 750 25 88 [EMAI

RE: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Yoav Shapira
Hi, >However, the problem is that I need to modify a method in the top level >Manager interface :( > >public Session createSession() >must become: >public Session createSession(String sessionId) >(if sessionId is null, a new session id will be generated) > >As the createSession() will no longer b

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Remy Maucherat
@@ -744,15 +747,17 @@ session.setValid(true); session.setCreationTime(System.currentTimeMillis()); session.setMaxInactiveInterval(this.maxInactiveInterval); -String sessionId = generateSessionId(); +if (sessionId == null) { +sessionId = generat

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Remy Maucherat
Tim Funk wrote: If I read this correctly (big if), the solution could be a security problem. If I were a phisher, I might be able to send you an email with a link to that would redirect you to a tomcat server with the new configuration in question with a special id. If the user were to perform

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Remy Maucherat
Tim Funk wrote: If I read this correctly (big if), the solution could be a security problem. If I were a phisher, I might be able to send you an email with a link to that would redirect you to a tomcat server with the new configuration in question with a special id. If the user were to perform

Re: [VOTE] Proposed API change to the Manager interface

2005-02-07 Thread Tim Funk
If I read this correctly (big if), the solution could be a security problem. If I were a phisher, I might be able to send you an email with a link to that would redirect you to a tomcat server with the new configuration in question with a special id. If the user were to perform other actions of