Re: New Valve Tester and NullValve

2000-11-29 Thread Remy Maucherat
> Remy Maucherat wrote: > > > > Also, in which package should this tester code reside, really? > > > > org.apache.catalina.valves.tester ? > > Well, if the hi-tech stocks continue to dive, I guess we can all go get jobs as > plumbers, testing valves :-) Oh, ok, it all makes sense now. You were pl

Re: New Valve Tester and NullValve

2000-11-29 Thread Craig R. McClanahan
Remy Maucherat wrote: > > Also, in which package should this tester code reside, really? > > org.apache.catalina.valves.tester ? Well, if the hi-tech stocks continue to dive, I guess we can all go get jobs as plumbers, testing valves :-) > > Doing that will make it end up in the Catalina JAR, w

Re: New Valve Tester and NullValve

2000-11-29 Thread Remy Maucherat
> Also, in which package should this tester code reside, really? org.apache.catalina.valves.tester ? Doing that will make it end up in the Catalina JAR, which is not a big problem IMO, but perhaps it could be packaged separately. We could add a src/test directory and put it in there. > I'm apreh

New Valve Tester and NullValve

2000-11-29 Thread Jason Brittain
In the process of optimizing AccessLogValve, I came to the conclusion that I needed a tester that would allow me to benchmark (and otherwise test) the valve without needing to run all of Catalina -- I needed to isolate just the valve so that I could get clean benchmark times. So, I thought about