Re: AW: AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Ben Souther
Martin- > - Original Message - > From: "Ben Souther" <[EMAIL PROTECTED]> > To: "Tomcat Developers List" <[EMAIL PROTECTED]> > Sent: Tuesday, October 12, 2004 3:42 PM > Subject: Re: AW: AW: DefaultServlet and getOutputStream() / getWriter() > >

Re: AW: AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Martin Gainty
Catch!!! Martin- - Original Message - From: "Ben Souther" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, October 12, 2004 3:42 PM Subject: Re: AW: AW: DefaultServlet and getOutputStream() / getWriter() > This is the

Re: AW: AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Ben Souther
This is the code that I saw (from the beginning of this discussion on the user's list). begin quote-- PS: Since I am already sending another mail, let me append a pending question: I often see code like this in the servlet: while (...) {

AW: AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Steffen Heil
Hi > Compile, run, and view the output from this program. > I think you'll see the difference :o) Sorry, but did you actually read the code it posted? I KNOW that there CAN be a difference in semantics. YOUR code has different semantics. BUT in the code I POSTED there is NONE ! So, please read

Re: AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Ben Souther
Steffen, Compile, run, and view the output from this program. I think you'll see the difference :o) public class Loop{ public static void main(String[] args){ System.out.println("Try-Catch inside loop:"); for(int i = 0; i < 10; i++){ try{ Syst

Re: AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Remy Maucherat
Steffen Heil wrote: I agree, that I am new to this and I might be wrong, but this leads me back right to where I started. Whom to ask to understand the existing code? I implied it already: no one. There are too many people who have touched the code, and too many tricky things going on. As a res

RE: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Shapira, Yoav
--Original Message- >From: Steffen Heil [mailto:[EMAIL PROTECTED] >Sent: Tuesday, October 12, 2004 1:43 PM >To: 'Tomcat Developers List' >Subject: AW: DefaultServlet and getOutputStream() / getWriter() > >Hi > > >> The rewritten while{} patch you sug

AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Steffen Heil
Hi > The rewritten while{} patch you suggested definitely changed behavior significantly, as I and others pointed out ;) Ähm, no. Sorry to say that, but I think, you didn't review the code for that statement: One example taken from DefaultServlet.java, lines 2030 to 2054: IOException e

RE: DefaultServlet and getOutputStream() / getWriter()

2004-10-12 Thread Shapira, Yoav
Hi, >Additionally, every change I suggested (on tomcat-user) was definitly not >changing any behaviour, but maybe improving performance. The rewritten while{} patch you suggested definitely changed behavior significantly, as I and others pointed out ;) >"Returns a ServletOutputStream suitable f

Re: AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-09 Thread Rick Knowles
Steffen, My understanding (and I might be wrong here, so someone please correct me if I am) is that once you've called getWriter(), you can't call getOutputStream() on the same request. The reason is primarily so that you have to use the same char encoding etc on included servlets as in the inc

AW: DefaultServlet and getOutputStream() / getWriter()

2004-10-09 Thread Steffen Heil
Hi > That's definitely why I am not interested by code cleanups done by folks who might not know all the small tricks: the risk of breaking stuff is far greater than the gain. Why are you soo hostile? I am just trying to get into the code and if I understand it, I will propably start to contribu

Re: Re: DefaultServlet and getOutputStream() / getWriter()

2004-10-09 Thread support
Responder, The email address you have contacted is no longer active. Please use your company’s user log-in to www.apparelmagic.com/support to contact the ApparelMagic Support Department. Thank you. - To unsubscrib

Re: DefaultServlet and getOutputStream() / getWriter()

2004-10-09 Thread Remy Maucherat
Steffen Heil wrote: Hi I am reviewing the source code of the DefaultServlet. I do not understand the following: // slightly modified from source of "serveResource". ServletOutputStream ostream = null; PrintWriter writer = null; try { ostream = response.getOutputStream();

Re: DefaultServlet and getOutputStream() / getWriter()

2004-10-08 Thread support
Responder, The email address you have contacted is no longer active. Please use your company’s user log-in to www.apparelmagic.com/support to contact the ApparelMagic Support Department. Thank you. - To unsubscrib

DefaultServlet and getOutputStream() / getWriter()

2004-10-08 Thread Steffen Heil
Hi I am reviewing the source code of the DefaultServlet. I do not understand the following: // slightly modified from source of "serveResource". ServletOutputStream ostream = null; PrintWriter writer = null; try { ostream = response.getOutputStream(); } catch (Ille