Re: [TC4] ResourcesBase.setCheckInterval() bug and HTTP

2000-11-16 Thread Craig R. McClanahan
Remy Maucherat wrote: > > Remy Maucherat wrote: > > > > > > You're correct that this kind of code is appropriate (because the > > > component > > > > has already been started without the thread). > > > > > > Really ? The threadStart() call is in the start() method, and > threadStop() > > > is alw

Re: [TC4] ResourcesBase.setCheckInterval() bug and HTTP

2000-11-16 Thread Remy Maucherat
> Remy Maucherat wrote: > > > > You're correct that this kind of code is appropriate (because the > > component > > > has already been started without the thread). > > > > Really ? The threadStart() call is in the start() method, and threadStop() > > is always called in stop(). How would the threa

Re: [TC4] ResourcesBase.setCheckInterval() bug

2000-11-16 Thread Craig R. McClanahan
Remy Maucherat wrote: > > You're correct that this kind of code is appropriate (because the > component > > has already been started without the thread). > > Really ? The threadStart() call is in the start() method, and threadStop() > is always called in stop(). How would the thread need to be st

Re: [TC4] ResourcesBase.setCheckInterval() bug

2000-11-16 Thread Remy Maucherat
> You're correct that this kind of code is appropriate (because the component > has already been started without the thread). Really ? The threadStart() call is in the start() method, and threadStop() is always called in stop(). How would the thread need to be started if the component is not star

Re: [TC4] ResourcesBase.setCheckInterval() bug

2000-11-16 Thread Craig R. McClanahan
Hi Jason, See below. Jason Brittain wrote: > Hi guys! > > In reading through the org.apache.catalina.resources package code, I found > a small omission from the ResourcesBase.setCheckInterval() method: > > public void setCheckInterval(int checkInterval) { > > // Perform the property update >

Re: [TC4] ResourcesBase.setCheckInterval() bug

2000-11-16 Thread Remy Maucherat
> At the end of this method, we changed the check interval, and then we > need to either start or stop the background thread that periodically > checks for resource updates. The code in this method handles the > following: > > 1. When the background thread is already running and we should be shut

[TC4] ResourcesBase.setCheckInterval() bug

2000-11-16 Thread Jason Brittain
Hi guys! In reading through the org.apache.catalina.resources package code, I found a small omission from the ResourcesBase.setCheckInterval() method: public void setCheckInterval(int checkInterval) { // Perform the property update int oldCheckInterval = this.checkInterval; this.checkInt