Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-23 Thread Günter Knauf
CTED]> > To: "Tomcat Developers List" <[EMAIL PROTECTED]> > Sent: Thursday, January 22, 2004 1:22 PM > Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c > On Thu, Jan 22, 2004 at 01:16:45PM -0800, Bill Barker wrote: >> However, it is the corr

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Bill Barker
st" <[EMAIL PROTECTED]> Sent: Thursday, January 22, 2004 1:22 PM Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c On Thu, Jan 22, 2004 at 01:16:45PM -0800, Bill Barker wrote: > However, it is the correct value to pass to Tomcat. Tomcat correctly uses > this

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Kyle VanderBeek
<[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Thursday, January 22, 2004 12:25 PM > Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c > > > On Thu, Jan 22, 2004 at 09:08:48PM +0100, Günter Knauf wrote: > > Hi Henri, > > > Th

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Bill Barker
rBeek" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, January 22, 2004 12:25 PM Subject: Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c On Thu, Jan 22, 2004 at 09:08:48PM +0100, Günter Knauf wrote: > Hi Henri, > > Thanks to resubmit the latest patc

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Kyle VanderBeek
On Thu, Jan 22, 2004 at 09:08:48PM +0100, Günter Knauf wrote: > Hi Henri, > > Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if > > everybody agree > ok. > With APR 1.0 apr_sockaddr_port_get() was removed without replacement. > I believe that the patch below is the correct repla

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Günter Knauf
Hi Henri, > Thanks to resubmit the latest patch for jk/jk2 on Apache 2 to see if > everybody agree ok. With APR 1.0 apr_sockaddr_port_get() was removed without replacement. I believe that the patch below is the correct replacement to archive _same_ behaviour as with apr_sockaddr_port_get() before

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Henri Gomez
Günter Knauf a écrit : Hi Henri, In JK 1.2.x for Apache 2 we're using : s->server_name = (char *)ap_get_server_name(r); ... apr_sockaddr_port_get(&port,r->connection->local_addr); s->server_port = port; Do you agree with this, if so I'll do the same for jk2 no, apr_sockaddr_por

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Günter Knauf
Hi Henri, > In JK 1.2.x for Apache 2 we're using : > s->server_name = (char *)ap_get_server_name(r); > ... > apr_sockaddr_port_get(&port,r->connection->local_addr); > s->server_port = port; > Do you agree with this, if so I'll do the same for jk2 no, apr_sockaddr_port_get() was rec

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Henri Gomez
Günter Knauf a écrit : IMHO, this is wrong. The server port isn't necessarily the port being listened on. See bug report and patch, long ignored: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16901 ok, but its as wrong as before - my patch doesnt change the behaviour from what I see, and

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-22 Thread Henri Gomez
Günter Knauf a écrit : IMHO, this is wrong. The server port isn't necessarily the port being listened on. See bug report and patch, long ignored: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16901 ok, but its as wrong as before - my patch doesnt change the behaviour from what I see, and t

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-21 Thread Günter Knauf
> IMHO, this is wrong. The server port isn't necessarily the port being > listened on. See bug report and patch, long ignored: > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16901 ok, but its as wrong as before - my patch doesnt change the behaviour from what I see, and this is what I can

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-21 Thread Kyle VanderBeek
IMHO, this is wrong. The server port isn't necessarily the port being listened on. See bug report and patch, long ignored: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16901 On Wed, Jan 21, 2004 at 02:08:28PM +0100, Günter Knauf wrote: > # patch for APR 1.0 compatiblity > # > --- jk_servi

Re: [PATHCH] ./jk/native2/server/apache2/jk_service_apache2.c

2004-01-21 Thread Günter Knauf
oops, take two: forgot to remove the obsolete port var. # patch for APR 1.0 compatiblity # --- jk_service_apache2.c.orig Tue Sep 30 18:16:14 2003 +++ jk_service_apache2.cWed Jan 21 17:43:14 2004 @@ -343,7 +343,6 @@ static int JK_METHOD jk2_init_ws_service(jk_env_t *env, jk_ws_service_t