Re: [PATCH] Fun with tag pools

2001-03-19 Thread Craig R. McClanahan
On Sun, 18 Mar 2001, Casey Lucas wrote: > [snip] > I was thinking of something like: > > If an exception is thrown (from any code, not necessarily the tag) during > the scope of a tag handler's use (between doStartTag and doEndTag), then > that tag should be removed from the pool because its s

Re: [PATCH] Fun with tag pools

2001-03-18 Thread Casey Lucas
Thanks for the comments. See my additional comments within. "Craig R. McClanahan" wrote: > > Casey, I haven't looked at the details but the concept looks really > great! I'm looking forward to a corresponding implementation for 4.0. > > A couple of interspersed comments below: > > On Sun, 1

Re: [PATCH] Fun with tag pools

2001-03-18 Thread Craig R. McClanahan
Casey, I haven't looked at the details but the concept looks really great! I'm looking forward to a corresponding implementation for 4.0. A couple of interspersed comments below: On Sun, 18 Mar 2001, Casey Lucas wrote: > > Ok, here's the patch. The attached files apply to tc 3.3. They > al

[PATCH] Fun with tag pools

2001-03-17 Thread Casey Lucas
Ok, here's the patch. The attached files apply to tc 3.3. They allow tag handler pooling per the jsp spec. The files come with a few questions and comments. Patch info: -- TagPoolManagerInterceptor.java should be placed in src/facade22/org/apache/tomcat/facade TagPoolManager.java Ta