RE: [PATCH] Tomcat4.0: org.apache.catalina.connector.http.SocketInput Stream

2001-01-08 Thread Vanlerberghe, Luc
chr != LF)) { > pos--; > } will always execute pos--; so either the test is obsolate or the writer meant it differently. Luc Vanlerberghe > -Original Message----- > From: Vanlerberghe, Luc [mailto:[EMAIL PROTECTED]] > Sent: Monday, January 08, 2001 12:02 PM >

[PATCH] Tomcat4.0: org.apache.catalina.connector.http.SocketInputStream

2001-01-08 Thread Vanlerberghe, Luc
I noticed the possibility for an infinite loop in org.apache.catalina.connector.http.SocketInputStream after the commit on thursday... I've attached a patch, but the diff is pretty unreadable... I changed the following piece of code: do { // Skipping CR or LF try {

Jasper: Thread-safety in generated _jspService code

2000-11-22 Thread Vanlerberghe, Luc
Hi, I've taken a look at the servlet code that jasper generates when compiling my jsp pages. I noticed the following code fragment near the start of each _jspService method: if (_jspx_inited == false) { _jspx_init(); _jspx_inited = true; } This code is not thread-safe: u