In the following code, I think that if b2 is actually null, you'll get an
NPE for b2.length. Better to check whether (b2 == null) first. Right?
+if (b2.length > len || b1 == null || b2 == null) {
+return false;
-David
-Original Message-
From: [EMAIL PROTECTED] [
I had a few spare minutes so I went ahead and grabbed last night's build.
I ran it on Red Hat Linux 7.2 and can confirm the report.
Requesting foo.jsp%00.txt gets you the source.
Requesting foo.jsp%00 gets you a strange page that includes some html
widgets and some of the jsp source too. Surpr
Short version:
Here's a patch that modifies the NotFoundHandler to incorporate the
msg from sendError(sc, msg) into the html response body. Currently, the
passed in msg is ignored.
Long version:
I know the servlet spec lets the server decide what the response body will
contain, and I k
usage_message() says "lphanumeric" instead of "alphanumeric"
-David
--- jk_nt_service.c.origThu Mar 21 16:52:21 2002
+++ jk_nt_service.c Thu Mar 21 16:52:29 2002
@@ -173,7 +173,7 @@
printf("%s -i {optional params} \n", name);
printf("Optional parameters\n");
pri
e J-T-C version of jk_nt_service.c is more out of
sync than just this. This is why I didn't apply your patch
to the J-T-C version when I applied it to jakarta-tomcat.
It is on my to do list to get them back in sync after
Tomcat 3.3.1 is final.
Cheers,
Larry
> -Original Message-----
&g
ge-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Thursday, March 14, 2002 11:10 AM
To: Tomcat Developers List
Subject: RE: cvs commit: jakarta-tomcat-connectors/jk/native/nt_service
jk _nt_service.c
On Thu, 14 Mar 2002, Schreibman, David wrote:
> Hi Costin,
>
> This merge
Hi Costin,
This merge from 3.3 doesn't include the -n option that Larry added 2 weeks
ago. It allows for specifying a display name separately from the service
name since the rules for what is a valid name differ in each case. For
example, the display name is allowed to contain spaces while the
Hi Larry,
Thanks for checking this in. By the way, what's up with
-Djava.security.policy=="$(wrapper.tomcat_policy)"
?
Is the == intentional?
I had changed it to just = in the patch I submitted but I noticed that you
left it in. Just curious and didn't want to pass up the chance to learn
This patch makes 2 minor changes to the wrapper.cmd_line
1) removes extra equals sign from the security policy assignment
2) adds quotes around wrapper.javabin so that JDK paths with spaces
will work. For example "c:\Program
Files\Javasoft\JRE\1.3.1_02\bin\java.exe"
-David
<>
You have to rename the file db2java.zip to db2java.jar. Previous versions
of Tomcat were not as strict about the requirement for classes to be stored
in jar files
-David
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, January 16, 2002 6:41 AM
Hi,
We've encountered a problem with the way jk_nt_service.c creates nt
services.
Specifically, the call to CreateService uses the name passed in for the
service as both the service name and the service display name. This is a
problem because there are restrictions on the service name that do n
Cool.
If and when you decide to check it in, you might want to consider this minor
update applying the same logic to the error handler's warning method. The
previously posted patch only covered calls the to error handler's error and
fatalError methods. I couldn't make up my mind as to whether p
Hi All,
Some people I work with noticed that Tomcat was spitting out a web.xml
validation error for their app, but only the first time they started up.
This gave them the impression that everything was ok the second time.
Well, I looked around a bit and found that WebXmlReader writes out a
"vali
Hi,
Just wondering what happened to the 3.3 release build at
http://jakarta.apache.org/site/binindex.html
I'm pretty sure I got a copy from there last week but it's gone now.
One of my co-workers was looking to install it today and just came by to ask
me about this.
Thanks,
-David
I'm submitting this with mixed feelings since the recent discussion has
shown strong opinions about the utility of the SingleThreadModel.
I was already in the middle of doing the work when all that came about so I
went ahead and finished it. After reaping the benefits of Tomcat for a
couple of y
Here's a simple tweak that clears out references to objects that are removed
from the pool. The current code can delay garbage collection for objects
that are removed from the pool but not returned.
The diff is against 3.3-rc1
-David
--- SimplePool.java.origThu Oct 4 10:14:51 2001
+
FYI: I'm taking a look at implementing a pool for this since it seems like a
fun task. If nobody beats me to it, I'll post my attempt when it's ready.
-David
> -Original Message-
> From: Bill Barker [mailto:[EMAIL PROTECTED]]
> Sent: Sunday, September 30, 2001 9:22 PM
> To: [EMAIL PROTE
Hi,
Is there a schedule update in the works?
I'm working on a migration plan and noticed that the current 3.3 release
plan calls for RC2 code freeze on Sept. 21 and a final code freeze on Sept.
28.
Thanks,
-David
]
Subject: RE: cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3
mo d_jk.c
>OK, Sorry. It's right there in front of me! Been a long week ...
For some it was even longer...
What do you think of the CHUNK code, David ?
>-David
>
>-Original Message-
>From: Schre
OK, Sorry. It's right there in front of me! Been a long week ...
-David
-Original Message-
From: Schreibman, David [mailto:[EMAIL PROTECTED]]
Sent: Friday, September 14, 2001 4:07 PM
To: '[EMAIL PROTECTED]';
[EMAIL PROTECTED]
Subject: RE: cvs commit: jakarta-tomca
Hi,
Shouldn't "content-length" be "Content-Length"? Or are the headers already
forced to lowercase elsewhere? Or how about a case insensitive comparison
to be nice
-David
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Friday, September 14, 2001 3:32 PM
#x27;t know for sure until I get past the
current problem and get to do my stress tests.
-David
-Original Message-
From: Schreibman, David
Sent: Tuesday, September 04, 2001 11:27 AM
To: '[EMAIL PROTECTED]'
Subject: RE: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/mo
Oops. Sorry for the typo.
About
>... "chunk-size [ chunk-ext ] CRLF", as defined in rfc 2069. That's ...
I meant rfc 2068!
-David
-Original Message-
From: Schreibman, David
Sent: Tuesday, September 04, 2001 11:03 AM
To: '[EMAIL PROTECTED]'; [EMAIL
It's great to see this work on chunked input progressing!
It's hard for me to see if it's covered here, so I wanted to double check
whether this code addresses a subtle bug that I ran into while getting
chunked input working on 3.2.2
For me, the problem came up when read_fully_from_server() woul
le in that
you can cause it to attempt up to three restarts (after a delay period),
execute a file on failure, reboot the system, etc.
We might as well use the facilities the OS provides instead of duplicating
this inside the service.
Marc Saegesser
> -Original Message-
> From:
If you really want the service code to be aggressive about restarting
Tomcat, I would suggest just calling start_tomcat() again. This would avoid
any dependency on the Service Control Manager's reaction to "ungraceful"
exits. In fact, I've never seen any documentation from Microsoft about such
r
Great! I will limp along with what I've got now in 3.2.2. Looking forward
to getting your changes.
What version(s) of Tomcat this will get into?
Thanks 100,
-David
-Original Message-
From: Keith Wannamaker [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, August 28, 2001 6:21 PM
To: [EMA
ful but I haven't thought too much about it.
In general, it seems like a good idea to leverage as much as possible from
the transport.
-David
>-Original Message-
>From: Schreibman, David [mailto:[EMAIL PROTECTED]]
>Sent: Tuesday, August 28, 2001 5:17 PM
>To: '[EMAIL
m: Keith Wannamaker [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, August 28, 2001 8:29 AM
To: [EMAIL PROTECTED]
Subject: RE: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/util/testHeader.java
HttpRequest.java
Heh, you beat me to it. I'd like to compare notes.
Can you resend the diff w
For whatever it's worth, here are some changes I made to the 3.2.2 code base
to add support for chunked requests. I just did the work a few days ago and
am still in the process of moving them to 3.3. Still, since the topic came
up now I thought it would be helpful to share my approach. I have b
30 matches
Mail list logo
