hi

2004-04-13 Thread pierre . delisle
the information is wrong! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PROPOSAL] EL Transition to Jakarta Commons

2002-12-18 Thread Pierre Delisle
+1 -- Pierre Jan Luehe wrote: > > I'd like to resume discussion on a proposal circulated by James > Strachan on March 13, 2002, about turning the implementation of JSTL's > expression language (EL) into a reusable component and moving it from > the Standard Taglib, an implementation of JSTL

Re: re-use of tag objects via Tag.release method

2001-03-01 Thread Pierre Delisle
Casey Lucas wrote: > Ok, I'll bite. Where's the best place to start looking? > Code that does the rendering? Wasn't there at one point talk > of making the renderer more "pluggable"? Great! Since you asked, here are some ideas: As a first step, I'd make sure to clearly understand all the spe

Re: re-use of tag objects via Tag.release method

2001-03-01 Thread Pierre Delisle
Casey Lucas wrote: > > Looking at the rendered jsp -> java files in the work directory > (and noticing the calls to Tag.release), I realized that Jasper > is not reusing tags that it creates. So, my question is: > > Has there been any conversations about implementing tag > reuse in Jasper? T

Re: Is it legal to have multiple taglib setter methods for the same property

2001-02-07 Thread Pierre Delisle
Alex, Until the expert group rules on this, one workaround (that will always work) is to simply do the following (assuming a property of type Object): instead of: use: Another way is to define a PropertyEditor associated with your property of type Object. As Craig men

Re: [VOTE] New Committer: Kief Morris

2001-02-06 Thread Pierre Delisle
+1 -- Pierre > > -Original Message- > > From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] > > Sent: Tuesday, February 06, 2001 12:16 PM > > To: [EMAIL PROTECTED] > > Subject: [VOTE] New Committer: Kief Morris > > > > > > Kief has recently proposed improvements to the session manag

Re: [VOTE] Tomcat 3.3 Release Plan

2001-01-31 Thread Pierre Delisle
> Tomcat 3.3 Release Plan Ballot: > > [ ] +1I am in favor of this plan and will help > [X] +0I am in favor of this plan, but am unable to help > [ ] -0I am not in favor of this plan > [ ] -1I am against this plan being executed, and my > reason is:

Re: [VOTES] Tomcat 4.0-Beta-1 and New CVS Repositories

2001-01-03 Thread Pierre Delisle
> (1) Tomcat 4.0 Beta 1 +1 > (2) Tomcat 4.1 Repository +1 > (3) New "jakarta-servletapi-4.0" CVS Repository +1 -- Pierre - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]

Re: back port to 3.2 --> JspInterceptor

2000-12-22 Thread Pierre Delisle
[EMAIL PROTECTED] wrote: > > > > BTW, did you fixed the command line compiler ? JspInterceptor is based on > > > the command line compiler, so if you fix the first it'll be very easy for > > > me to fix the 3.3 interceptor. > > > > Sorry, my radar must have missed this one. If you can give me p

Re: back port to 3.2 --> JspInterceptor

2000-12-22 Thread Pierre Delisle
Hi Costin, > JspInterceptor is not "enabled" in 3.2 - it was one of the changes I > wanted to spend more time into and make sure it's stable enough. It'll be > used in 3.3 - or whatever will be called. Thanks for the clarification. However since it is being compiled in the build, it is "somewhat

Re: VOTE: New Commiter Shai Fultheim (was:RE: Tomcat session replicator)

2000-12-22 Thread Pierre Delisle
+1 for Shai Fultheim -- Pierre

Re: Bug #55: Default for included files is 8859_1, with no optionto set otherwise

2000-12-21 Thread Pierre Delisle
> Maybe I'm not reading carefully enough (and I haven't had time to trace the > code) but I don't understand what you mean in your "modifications". > > The correct behavior seems to me that when a file is included, a 'fake' > JspReader should be created to scan the file for a @page directive w

back port to 3.2 --> JspInterceptor

2000-12-21 Thread Pierre Delisle
Tried to back port the last fix I made to Jasper in tomcat 4.0 to tomcat 3.2 (the fix related to bug report #269 -- java encoding). Was almost there until I realized there is a new class "JspInterceptor" in tomcat 3.2 that is impacted by that fix. Unfortunately, I'm not too knowledgeable about

Re: Bug #55: Default for included files is 8859_1, with no option to set otherwise

2000-12-21 Thread Pierre Delisle
Hans Bergsten wrote: ... > So, > the only possible remaining thing I can think of is to make > sure the encoding specified by jspEncoding is also used as > the "-encoding" argument to the javac command. It is. -- Pierre

Re: Bug #55: Default for included files is 8859_1, with no option to set otherwise

2000-12-21 Thread Pierre Delisle
Hans, > What about the javac encoding? I believe it's currently hardcoded > as "UTF8" (in Compiler at least). I'm not sure what it should be > in case different included pages specify different charsets ... If you refer to bug report #269, I have a fix coming in the next few minutes. [testing it

Bug #55: Default for included files is 8859_1, with no option to set otherwise

2000-12-21 Thread Pierre Delisle
Trying to close a few Jasper bugs before the holiday break. I'd appreciate at least another pair of eyes to review what I believe should be done on that one... -- Pierre - Bug #55 - Synopsis: Default for included files is 8859_1, with no option to set otherwise. Report

Re: Jasper Compiler -- when things go really wrong

2000-12-19 Thread Pierre Delisle
This seems right. I'll put the fix in tomorrow unless someone objects. [no need to send a patch]. -- Pierre "Bucknam, Brian" wrote: > > It's a long story, but I'm working on a project where Jasper 3.x is embedded > inside a servlet, which can then be deployed to the container of our > custo

Committers

2000-12-19 Thread Pierre Delisle
+1 for Vasile Gaburici +1 for Petr Jiricka +1 for Marc Saegesser -- Pierre

Re: jsp - html speedup

2000-12-18 Thread Pierre Delisle
cga wrote: > > Hi there, > > I was thinking "There is a way to speed up jps". I mean if I take out > white spaces and other unnecesary text out of the html part of a jsp, the > server will send less bytes to the browser so it will be faster. > > I am pretending to do a Reader that take

Re: Jasper tag class usage: bug?

2000-12-13 Thread Pierre Delisle
Rickard, The current implementation of Jasper (in all versions of tomcat) does not "reuse" tag handlers. Not a bug, just a not-so-efficient implementation. No-one has had/volunteered the time to look into it so far. We're just about done with the new JSP 1.2 features, and efficiency should beco

Re: cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler BeanGenerator.java JspParseEventListener.java ParserXJspSaxHandler.java

2000-12-09 Thread Pierre Delisle
Hans Bergsten wrote: > > Pierre Delisle wrote: > > > > Hans Bergsten wrote: > > > > > > [EMAIL PROTECTED] wrote: > > > > > > > > pierred 00/12/09 21:56:44 > > > > > > > > Modified:jasper/src/share

Re: cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler BeanGenerator.java JspParseEventListener.java ParserXJspSaxHandler.java

2000-12-09 Thread Pierre Delisle
Hans Bergsten wrote: > > [EMAIL PROTECTED] wrote: > > > > pierred 00/12/09 21:56:44 > > > > Modified:jasper/src/share/org/apache/jasper Constants.java > >jasper/src/share/org/apache/jasper/compiler > > BeanGenerator.java JspParseEventListener.ja

Re: Proposal: new commiter

2000-12-06 Thread Pierre Delisle
> Please vote for Dan Milstein as a new commiter for tomcat. Great! +1 -- Pierre

Re: AW: [PATCH REPOST] Tomcat 4.0 JSP Examples view Source

2000-12-01 Thread Pierre Delisle
examples/jsp/dates/date.txt Is that what you have? -- Pierre > > So did I misunderstand the intent of this View Source thingy ? > > Please enlighten me. > > Best Regards, > Hans > > > -Ursprüngliche Nachricht- > > Von: Pierre Delisle [mailto:[EMAI

Re: [PATCH REPOST] Tomcat 4.0 JSP Examples view Source

2000-11-30 Thread Pierre Delisle
Hans, I just tried the examples on tomcat 4.0, and the only problem I could see is with the source code of the "number guess" example. The link in num/numguess.html should be changed from "/examples/jsp/source.jsp?/jsp/num/numguess.jsp" to "numguess.txt" Otherwise, everything seems

Re: [VOTE] Tomcat 3.2 Final Release (!) and Ongoing Maintenance Plan

2000-11-28 Thread Pierre Delisle
> (1) Build and release Tomcat 3.2 final on Wednesday 11/29/2000 +1 > (2) Ongoing Support Plan for Tomcat 3.2 +1 > (3) Release Manager for Tomcat 3.2.x Maintenance Releases +1 -- Pierre

Re: [VOTE] Tomcat 3.2 Final Release (!) and Ongoing Maintenance Plan

2000-11-28 Thread Pierre Delisle
The JSP spec is quite clear on the subject: "The only types of properties that can be assigned to from String constants and request parameter values are those listed in TABLE 2-4; the conversion applied is that shown in the table. Request-time expressions can be assigned to properties of any ty

Re: [PATCH] JspParseEventListener.java - Catch Throwable and throw new Exception

2000-11-26 Thread Pierre Delisle
Rob Saccoccio wrote: > > Would it be possible to change the generated _jspService() method to catch > Throwable instead of Exception? JSP 1.2 is taking this direction (excerpt > and patch below). Just committed the fix in tomcat-4.0 (since this is JSP1.2). > + writer.println("java.lang

Re: Patch for JikesJavaCompiler.java

2000-11-24 Thread Pierre Delisle
Christian, Thanks for the patch. I've just aplied it to tomcat-4.0. As for tomcat-3.2, I will be porting patches there *only* if this is approved by Craig (since we are so close to an official release of 3.2). -- Pierre "Schmitt, Christian" wrote: > > Hi all, > we've been working with TC

Re: Proper jsp:setProperty behavior for Tomcat 3.2

2000-11-20 Thread Pierre Delisle
Larry Isaacs wrote: > ... > I'll try to commit a patch that fixes just the following: > > 1) Fix value="" without allowing param="..." to set. > 2) For a String array property, make "?prop=&prop=text" set the >property for property="*". Currently property="*" handling >assumes only simpl

PageContext.removeAttribute

2000-11-20 Thread Pierre Delisle
> Bug report #412 has just been filed. > Synopsis: > public void removeAttribute(String name) does not work properly > > Description: > lt. spec from sun this method is required to remove > the attribute from every scope. in class PageContextImpl > however this only removes attributes from the

Re: Proper jsp:setProperty behavior for Tomcat 3.2

2000-11-20 Thread Pierre Delisle
Larry, As you pointed out, whether or not the sequence of parameters in the query string is reliable seems the key issue here. Let's consider the following two use cases: A) truly indexed fields HTML form with 5 text fields labeled "Period 1" to "Period 5". The data entered by the user in ea

Re: Proper jsp:setProperty behavior for Tomcat 3.2

2000-11-20 Thread Pierre Delisle
Larry Isaacs wrote: > > When applying Gareth Morgan's bug fix for JspRuntimeLibrary in the Tomcat MAIN > branch, a difference between the tomcat_32 and MAIN versions revealed that > Tomcat 3.2 still has the bug discovered by Glenn Nielsen. This is where: > > > > leaves the property un

Re: Proper jsp:setProperty behavior for Tomcat 3.2

2000-11-17 Thread Pierre Delisle
Larry Isaacs wrote: > I'm +1 on fixing the > bug in Tomcat 3.2. +1 > If the desired behavior for indexed properties can be > determined, I can try to fix that too. Sent email to Eduardo to try to get a clarification. -- Pierre

Re: [Proposal] Tomcat 3.2b8

2000-11-17 Thread Pierre Delisle
> I propose to do a 3.2b8 build on Monday afternoon (which should give us time to > address the remaining b7 issues that I know about). What do you think? +1 -- Pierre

Re: 3.2 status -- no taglibs in jars

2000-11-16 Thread Pierre Delisle
> I'd be glad to test this in my scenario and any others you suggest. > > I haven't tried simply commenting out or removing the code that says "Take this >stuff out..." because that would remove the entire section devoted opening the jar >and finding the .tld inside. Maybe I'm missing somethin

Re: FW: lock

2000-11-16 Thread Pierre Delisle
Original Message- > From: Larry Isaacs > To: 'Pierre Delisle ' > Cc: '[EMAIL PROTECTED]' > Sent: 11/15/00 9:55 PM > Subject: RE: lock > > Hi Pierre, > > I saw the same thing a little after 5:00 PM when I tried a commit some > changes to this di

Re: 3.2 status -- no taglibs in jars

2000-11-15 Thread Pierre Delisle
> I'll commit the patch right now and I'd appreciate if you > could run some exhaustive tests. Well, it may take a little while, as my commit is currently blocked because of a lock held by Larry (I've notified him). Since the lock has been on for more than 10 minutes, I suspect something is wro

Re: 3.2 status -- no taglibs in jars

2000-11-15 Thread Pierre Delisle
Brian Bucknam wrote: > > Craig says all the critical bugs are fixed, and it seems maybe they are. > > However, there is still a problem (see bug #215) in TagLibraryInfoImpl which makes >it so that tag libraries cannot be packaged in .jar files. (3.2b7 (and 3.1) at least >not on Windows, have

Re: Tomcat 4.0 -- JSP XML representation problems

2000-11-14 Thread Pierre Delisle
Boyd, > I cannot really use the XML representation, because the tag > doesn't work with current Tomcat-4.0-devel. I get classCastExceptions if > I try to use this tag. But you could still use for your CDATA. should be in tomcat-4.0 befroe the end of the week. > ps: I can see that ultimately,

Re: [PATCH] JspRuntimeLibrary boolean bug

2000-11-14 Thread Pierre Delisle
Gareth, Thanks for the patch. I've committed it to 4.0, and will wait for feedback from Craig to see if it can be committed to 3.2b7. -- Pierre Gareth Morgan wrote: > > This file seems to use the wrong method of String->Boolean conversion, > resuting in an always false result. > - Could so

Re: Patch for bug report #362 (and a patch for a logging error)

2000-11-14 Thread Pierre Delisle
e Tomcat 3.2 be uniform in both jspc and the Jasper Servlet. > > That is *definitely* true. Unfortunately, I'm not the person most versed with > the JSP compiler. Pierre Delisle is, and he will also be back on Monday. > > > I looked > > through the code some and didn&#

Re: [ANNOUNCE] Tomcat 4.0 Milestone 3

2000-10-20 Thread Pierre Delisle
Remy Maucherat wrote: > > > Did we need JAXP 1.1 ? > > Yes. I can't see that being documented anywhere yet, though ... That will > have to be fixed. > Xerces 1.2 is only JAXP 1.0 compliant, so it can't be used yet. > > Remy >From the commit log (10/12/00 4:34pm). Log: Back to using a JA