, the result is
> what you have noticed.
>
> I'll see if I can add some code to compute the input line ranges, but
> it is going to be messy. :(
>
> But really, all this is more academic than useful in practice: who do
> you think may need to single step over template
Remy Maucherat wrote:
>
> [ ] Alpha
> [X] Beta
>
Eric
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
This SMAPs all declaration nodes, including the ones tacked on to the root node by
ELFunctionMapper.java. So for instance the SMAP for jsp2/el/functions.jsp from the
jsp-examples webapp ends with
43,6:120
1,3:10
1,5:13
thus SMAPping
<%@ taglib prefix="my" uri="http://jakarta.apache.org/tom
cal/cal1.jsp from the jsp-examples webapp starts like this:
Before this commit, cal1.jsp's SMAP started like this:
*L
1,2:41
3:42
4:42
5:42
6:43,2
Now it starts like this:
*L
1,2:41
6:43,2
I think the reason lines 3, 4, and 5 aren't being SMAPped is that you only add
LineInfos inside "if
> Unfortunately, not having a debugger that uses SMP, it is hard to automate
> SMAP testing. You pretty much has to manually eyeball the files to verify
> its correctness. I think netbeans is planning to use tomcat 5 for its
> next major, so we'll expect more use there.
In the wake of Bugzilla #
> SMAP generation is one of the area that does not got enough test and use.
> You seem to be one of the few who actually look at it. Are you doing
anything
> with it?
Nope. Just trying to make myself useful.
Eric
-
To unsubscr
> But this also shows that tight coupling between Generator and SmapUtil is
> flagile and error prone. I think it would be a better design if we
> decouple these two modules somehow. We could create additional data
> structure that captures the mapping info for template texts, with
Generator
> it
This change leads to incorrect SMAPs of TemplateText nodes with 3 or fewer
characters, because the "if (textSize <= 3)" logic isn't mirrored in
SmapUtil.java.
Moving the "if (textSize <= 3)" block into the "if
(ctxt.getOptions().genStringAsCharArray())" block seems to be a quick way to
fix the pro
> +1, welcome on board
Thanks, happy to be here.
> If he like Xerces, he can jump on that side too ;-)
> -- Jeanfrancois
I'm going to stick to Tomcat 5/Jasper 2 while there are still bugs there
that I can do something about. After that, well, Xerces can't be any less
glamorous than SMAPping
> (hopefully, we'll have a good quality build this time :) )
To that end, could someone add xml/xml.jsp from the jsp-examples webapp (or
something like it) to tester? There isn't very much XML coverage in tester,
and this particular jsp would have flagged bugs 22277 and 21366 before they
made it
Remy Maucherat wrote:
> Note 2: As far as I am concerned, the 5.0.7 build is feature complete
> (ie, my TODO list is empty).
FYI, there are still a handful of TODOs in the Jasper code, at least one of
which ("need to check for uniqueness of attribute name, variable name-given,
and variable alias"
11 matches
Mail list logo
