DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Watchdog problems on 3.3.x

2002-04-09 Thread Bill Barker
The current Coyote connector (almost, but more on that later) passes Watchdog on port 80. It fails badly on port 8080. From the discussions on list between Remy and Costin, this is because the Watchdog tests incorrectly fail to include the port in the Host header for the HTTP/1.1 protocol. Give

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java

2002-04-09 Thread billbarker
billbarker02/04/09 22:01:01 Modified:coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java Log: Fix the return value to conform to the API. Why can't Java be like C++ where this is an error? Revision ChangesPath 1.8 +4 -3

[ANN] MinTC 0.5 Alpha "It Wants to be Your Friend"

2002-04-09 Thread Christopher K. St. John
MinTC needs adventurous testers. http://www.distributopia.com Changes for 0.5 include: Initial support for error pages, better support for RequestDispatcher, more testing with J2ME/CDC, a start on supporting precompiled jsp's, and general cleanup. Watchdog conformance testing results: "342 T

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor.java CoyoteProcessor.java CoyoteRequest.java CoyoteResponse.java

2002-04-09 Thread billbarker
billbarker02/04/09 20:43:17 Removed: coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor.java CoyoteProcessor.java CoyoteRequest.java CoyoteResponse.java Log: Removing the old Interceptor. If necessary, we can always get t

cvs commit: jakarta-tomcat-4.0/catalina build.xml

2002-04-09 Thread larryi
larryi 02/04/09 20:26:01 Modified:catalina build.xml Log: tomcat-jk.jar and tomcat-jk2.jar recently moved in jakarta-tomcat-connectors Revision ChangesPath 1.111 +2 -2 jakarta-tomcat-4.0/catalina/build.xml Index: build.xml ===

cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread larryi
larryi 02/04/09 20:24:45 Modified:.build.xml Log: Include our "home" to ensure it is set correctly Revision ChangesPath 1.171 +6 -2 jakarta-tomcat/build.xml Index: build.xml === RC

cvs commit: jakarta-tomcat-connectors/jk build.xml

2002-04-09 Thread larryi
larryi 02/04/09 20:21:42 Modified:jk build.xml Log: Adding Tomcat 3.3's servlet.jar in case a Tomat 4 isn't available Revision ChangesPath 1.34 +2 -0 jakarta-tomcat-connectors/jk/build.xml Index: build.xml =

DO NOT REPLY [Bug 7904] New: - Tag Pool Manager - ClassCastException

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java SingleSignOnValveForm.java

2002-04-09 Thread manveen
manveen 02/04/09 17:38:32 Added: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java SingleSignOnValveForm.java Log: Added form beans for Remote addr, remote host and single s

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_en.properties ApplicationResources_es.properties

2002-04-09 Thread manveen
manveen 02/04/09 17:37:07 Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_en.properties ApplicationResources_es.properties Log: Added valve related properties Revision ChangesPath 1.41

cvs commit: jakarta-tomcat-4.0/webapps/admin/valve remoteAddrValve.jsp remoteHostValve.jsp singleSignOnValve.jsp accessLogValve.jsp

2002-04-09 Thread manveen
manveen 02/04/09 17:35:49 Modified:webapps/admin/valve accessLogValve.jsp Added: webapps/admin/valve remoteAddrValve.jsp remoteHostValve.jsp singleSignOnValve.jsp Log: Added jsp's for remote addr , remote host and single sign on valves. Revision

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java MBeanUtils.java

2002-04-09 Thread amyroh
amyroh 02/04/09 16:54:35 Modified:catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java MBeanUtils.java Log: Add check for "null" string address as part of MBean name for connector since MBean nomenclature doesn't like empty string. In the case

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardHostDeployer.java

2002-04-09 Thread craigmcc
craigmcc02/04/09 16:48:21 Modified:catalina/src/share/org/apache/catalina Deployer.java catalina/src/share/org/apache/catalina/core StandardHostDeployer.java Log: When using the Manager webapp to deploy, add a container event *after* the new

Re: CoyoteInterceptor2

2002-04-09 Thread Bill Barker
Let's kill it then :-) - Original Message - From: <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, April 09, 2002 3:50 PM Subject: Re: CoyoteInterceptor2 > On Tue, 9 Apr 2002, Bill Barker wrote: > > > I'm +1 for this. But for at least a little while, I

Jk2 configuration ( again )

2002-04-09 Thread costinm
This is mostly a reminder of the previous discussion, and an update wrt. the java side, now based on coyote. We agreed ( I hope :-) that mod_jk ( C ) needs a better config, and we agreed that the new config must support both user-editable and runtime changes ( like discovery, etc - where the ajp

DO NOT REPLY [Bug 7897] New: - Realm problem...

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-tomcat-connectors/jk/native/iis jk_isapi_plugin.c

2002-04-09 Thread nacho
nacho 02/04/09 16:09:25 Modified:jk/native/iis jk_isapi_plugin.c Log: * Fix for #2342 Revision ChangesPath 1.15 +73 -23jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c Index: jk_isapi_plugin.c ===

cvs commit: jakarta-tomcat-connectors/jk/native/iis isapi.dsp isapi.dsw isapi.mak

2002-04-09 Thread nacho
nacho 02/04/09 16:06:52 Modified:jk/native/iis isapi.dsp Removed: jk/native/iis isapi.dsw isapi.mak Log: * Readded ajp12 dependencies, they are still present in jk * Delted uneeded files, mak can be generated easily in the ide, and dsw it's automatically created when the

Re: CoyoteInterceptor2

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Bill Barker wrote: > I'm +1 for this. But for at least a little while, I'd rather just deprecate > CoyoteInterceptor and related classes. It seems Remy already removed the old connector for 4.0. If we need it' we can get it back from the CVS :-) Costin -- To unsubscribe

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteConnector.java CoyoteAdapter.java CoyoteConnector2.java

2002-04-09 Thread remm
remm02/04/09 15:27:11 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java Added: coyote/src/java/org/apache/coyote/tomcat4 CoyoteConnector.java Removed: coyote/src/java/org/apache/coyote/tomcat4 CoyoteCo

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteConnector.java CoyoteProcessor.java

2002-04-09 Thread remm
remm02/04/09 15:25:07 Removed: coyote/src/java/org/apache/coyote/tomcat4 CoyoteConnector.java CoyoteProcessor.java Log: - Remove the old Coyote connector (and replace it with the new JK2 enabled one). CVS will allow restoring it if it turns out there

cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 Makefile

2002-04-09 Thread costin
costin 02/04/09 14:48:21 Modified:jk/native2/server/apache2 Makefile Log: Finally, update the Makefile - it should behave exaclty as the ant-based builder for native. Revision ChangesPath 1.3 +1 -1 jakarta-tomcat-connectors/jk/native2/server/apache2/Makefil

cvs commit: jakarta-tomcat-connectors/jk/native2 build.xml

2002-04-09 Thread costin
costin 02/04/09 14:46:42 Modified:jk/native2 build.xml Log: Remove WEB-INF. Added a flag to build APR-based jk with apache13 It should work, but the build file is broken, it includes apr by using the apache2 include dir - if detected. That creates problem since httpd.h i

cvs commit: jakarta-tomcat-connectors/jk/native build.xml

2002-04-09 Thread costin
costin 02/04/09 14:42:55 Modified:jk/native build.xml Log: Remove the WEB-INF extra path. Revision ChangesPath 1.29 +15 -14jakarta-tomcat-connectors/jk/native/build.xml Index: build.xml ===

cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costin
costin 02/04/09 14:37:53 Modified:.build.xml Log: Update j-t-c/jk build file Revision ChangesPath 1.170 +1 -1 jakarta-tomcat/build.xml Index: build.xml === RCS file: /home/cvs/jaka

cvs commit: jakarta-tomcat-connectors/jk build.xml

2002-04-09 Thread costin
costin 02/04/09 14:36:47 Modified:jk build.xml Log: Get rid of WEB-INF and a lot of stuff that is no longer needed. We should also get rid of most tomcat deps - the only one that's needed is to build the ajp package for tomcat4, but that shouldn't require all the det

DO NOT REPLY [Bug 5735] - HTTP connector running out of processors under heavy load

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 5735] - HTTP connector running out of processors under heavy load

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 5735] - HTTP connector running out of processors under heavy load

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-tomcat-connectors/jk interceptors.xml

2002-04-09 Thread costin
costin 02/04/09 14:09:22 Removed: jk interceptors.xml Log: Remove interceptors - coyote mechanism is used as connector -- To unsubscribe, e-mail: For additional commands, e-mail:

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread Remy Maucherat
> > I'm still missing something I guess :-) > > > > I can try to preserve the host/addr at the http11 level if you think > > it's important ( just to make Remy nervous :-) > > > > It's not extremely important. It's just a nice optimization for people who > use remoteHost. If you want to concentr

cvs commit: jakarta-tomcat-connectors/jk/conf web.xml webapp_41.xml

2002-04-09 Thread costin
costin 02/04/09 14:08:13 Removed: jk/conf web.xml webapp_41.xml Log: Removed the web.xml-based config - coyote is used instead. -- To unsubscribe, e-mail: For additional commands, e-mail:

Re: CoyoteInterceptor2

2002-04-09 Thread Bill Barker
I'm +1 for this. But for at least a little while, I'd rather just deprecate CoyoteInterceptor and related classes. - Original Message - From: <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, April 09, 2002 1:48 PM Subject: CoyoteInterceptor2 > > Bill,

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread Bill Barker
- Original Message - From: <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, April 09, 2002 1:45 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java > On Tue, 9 Apr 2002, Bill Barker wrote:

cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache13 mod_jk2.c

2002-04-09 Thread jfclere
jfclere 02/04/09 14:00:38 Modified:jk/native2/common jk_config.c jk_workerEnv.c jk/native2/server/apache13 mod_jk2.c Log: Add $(serverRoot) handling for apache13 and jk_config.c (it cores when modifying the value parameter (in the read only part of executable).

cvs commit: jakarta-tomcat-connectors/jk/native2 build.xml

2002-04-09 Thread jfclere
jfclere 02/04/09 13:57:19 Modified:jk/native2 build.xml Log: Add unless HAVE_APR to compile it without APR. Revision ChangesPath 1.17 +2 -0 jakarta-tomcat-connectors/jk/native2/build.xml Index: build.xml ==

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread remm
remm02/04/09 13:51:06 Modified:jk/java/org/apache/jk/common JkInputStream.java jk/java/org/apache/jk/server JkCoyoteHandler.java Log: - Remove old package from imports. Revision ChangesPath 1.6 +0 -1 jakarta-tomcat-connectors/jk/java/org/ap

CoyoteInterceptor2

2002-04-09 Thread costinm
Bill, Do you think we can move to CoyoteInterceptor2 and "Protocol" ? It seems to be working for both http and ajp - it is still less stable than your original one, but I think we're close. Your call. Costin -- To unsubscribe, e-mail: For additional commands, e-

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3Tomcat3Request.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Bill Barker wrote: > > Unless I'm missing something. > > These fields are recycled per-request, so we lose the value of > remoteHost/remoteAddr and will have to look it up again. If the buffers are > identical, then the o.a.c.Request field is recycled as well. At least for >

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread costin
costin 02/04/09 13:40:44 Modified:jk/java/org/apache/jk/common JkInputStream.java jk/java/org/apache/jk/core JkHandler.java jk/java/org/apache/jk/server JkCoyoteHandler.java Log: Revision ChangesPath 1.5 +10 -0 jakarta-tomcat-co

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/util C2B.java

2002-04-09 Thread costin
costin 02/04/09 13:39:38 Removed: jk/java/org/apache/jk/util C2B.java Log: Remove the duplicated class. -- To unsubscribe, e-mail: For additional commands, e-mail:

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf C2BConverter.java

2002-04-09 Thread costin
costin 02/04/09 13:39:06 Modified:util/java/org/apache/tomcat/util/buf C2BConverter.java Log: Backward-compatible change to C2BConverter. Needed by jk - this would avoid duplicating the code. The duplicated class was needed to allow jk to work with unmodified versions of t

DO NOT REPLY [Bug 7891] - Class loader collision

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: > Yes, that's what the fixed patch does. > So I did it right, I think :) Thanks. Costin -- To unsubscribe, e-mail: For additional commands, e-mail:

DO NOT REPLY [Bug 7891] New: - Class loader collision

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread Bill Barker
- Original Message - From: <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, April 09, 2002 1:45 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java > On Tue, 9 Apr 2002, Bill Barker wrote:

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread costin
costin 02/04/09 13:19:53 Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java Log: Update to the stateless-enabled Input/OutputBuffer interfaces. Clean up the code ( jk2 is mostly stateless ) Revision ChangesPath 1.6 +42 -58 jakarta-tomcat-connectors/j

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat40 JkConfig40.java JkConnector.java JkRequest40.java JkResponse40.java LocalStrings.properties Worker40.java

2002-04-09 Thread costin
costin 02/04/09 13:17:47 Removed: jk/java/org/apache/jk/server/tomcat40 JkConfig40.java JkConnector.java JkRequest40.java JkResponse40.java LocalStrings.properties Worker40.java Log: Removed the duplicated tomcat4 connector. We'll use

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat40/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java

2002-04-09 Thread costin
costin 02/04/09 13:16:54 Removed: jk/java/org/apache/jk/server/tomcat40/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java Log: Removed the duplicate config. We'll use the one in ajp for mod_jk1, a different

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat33 JkConfig33.java JkRequest33.java JkResponse33.java JkServlet33.java Worker33.java

2002-04-09 Thread costin
costin 02/04/09 13:15:09 Removed: jk/java/org/apache/jk/server/tomcat33 JkConfig33.java JkRequest33.java JkResponse33.java JkServlet33.java Worker33.java Log: Removed the old connector, use Coyote instead. -- To unsubscribe, e-mail:

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread Remy Maucherat
> On Tue, 9 Apr 2002, Remy Maucherat wrote: > > > > port if it is not the standard one. > > > > > > But if the Host header is correct, it'll allways be the same thing as > > > the getPort on socket - if it's https on standard port, the port will > > > be 443 as the default, etc. > > > > Even if th

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java Tomcat3Request.java

2002-04-09 Thread costin
costin 02/04/09 13:14:11 Modified:coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java Tomcat3Request.java Log: Fix get/setAttribute, thanks Bill. Revision ChangesPath 1.7 +19 -7 jakarta-tomcat-connectors/coyote/src/java/o

JAAS IN TOMCAT 4.0.x

2002-04-09 Thread Williams Mark L DLPC
I've been trying to get JAAS capabilities to work (JDK 1.4.0, Tomcat 4.0.1, 4.0.3, Solaris 8) and am getting odd (and unsatisfactory) results. Is there any reference that identifies if JAAS should work under Tomcat 4.0.x? BTW, I get different behavior between 4.0.1 and 4.0.3 with the same catalin

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: > > port if it is not the standard one. > > > > But if the Host header is correct, it'll allways be the same thing as > > the getPort on socket - if it's https on standard port, the port will > > be 443 as the default, etc. > > Even if the port in the ho

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3Tomcat3Request.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Bill Barker wrote: > > + > > +remoteAddrMB = coyoteRequest.remoteAddr(); > > + remoteHostMB = coyoteRequest.remoteHost(); > > + serverNameMB = coyoteRequest.serverName(); > > + > > + > > This forces the lookup to always be per-request, when it would be muc

cvs commit: jakarta-tomcat/src/etc server.xml

2002-04-09 Thread costin
costin 02/04/09 12:43:27 Modified:src/etc server.xml Log: Changed to CoyoteInterceptor2. ( after we are comfortable with it, we'll rename it to CoyoteInterceptor ) Added the commented out impl of Coyte-based jk. Revision ChangesPath 1.97 +8 -2 jakarta

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread Remy Maucherat
> On Tue, 9 Apr 2002, Remy Maucherat wrote: > > > > ( this used to be in the 3.3-specific code, and is needed to construct > > > redirects, etc ) > > > +//The info from socket is usually acurate > > > +// req.setServerPort(80); > > > > That's not good. If no host is

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread Remy Maucherat
> On Tue, 9 Apr 2002, Remy Maucherat wrote: > > > > Can you add a small comment in Response and clearly indicate who should > > > call it - I'm fine with any, but we should do it consistenlty in the 2 > > > adapters and in the 2 protocols. > > > > The class which is implementing the Adapter interf

cvs commit: jakarta-tomcat/src/etc modules.xml

2002-04-09 Thread costin
costin 02/04/09 12:34:20 Modified:src/etc modules.xml Log: Add CoyoteInterceptor2. Revision ChangesPath 1.14 +2 -0 jakarta-tomcat/src/etc/modules.xml Index: modules.xml === RCS file: /ho

cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costin
costin 02/04/09 12:33:43 Modified:.build.xml Log: As discussed on tomcat-dev, place j-t-c/tomcat-utils.jar in common, rename the old one to container-utils. Call the ant files for j-t-c to build and clean Revision ChangesPath 1.169 +53 -31jakarta-

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread Bill Barker
> + > +remoteAddrMB = coyoteRequest.remoteAddr(); > + remoteHostMB = coyoteRequest.remoteHost(); > + serverNameMB = coyoteRequest.serverName(); > + > + This forces the lookup to always be per-request, when it would be much nicer to do it per-connection. > + > +public

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4CoyoteResponse.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: > > Can you add a small comment in Response and clearly indicate who should > > call it - I'm fine with any, but we should do it consistenlty in the 2 > > adapters and in the 2 protocols. > > The class which is implementing the Adapter interface is calli

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Processor.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: > > ( this used to be in the 3.3-specific code, and is needed to construct > > redirects, etc ) > > +//The info from socket is usually acurate > > +// req.setServerPort(80); > > That's not good. If no host is specified wit

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyoteInputBuffer.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: > > BTW, this is a very cool idea - it avoids one copy and allocations, > > and simplifies the code. But it deserves a comment :-). > > Yes, indeed. I worked hard so that there wouldn't be any useless copy. Yes, excelent !. > > One question for

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server/tomcat33/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java

2002-04-09 Thread costin
costin 02/04/09 11:43:11 Removed: jk/java/org/apache/jk/server/tomcat33/config ApacheConfig.java BaseJkConfig.java IISConfig.java NSConfig.java Log: Removed duplicated config. mod_jk2 will use a different syntax and a single conf

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread Remy Maucherat
> costin 02/04/09 10:23:49 > > Modified:http11/src/java/org/apache/coyote/http11 > Http11Processor.java > Log: > If host header is not set, use the local socket to set the local port > and hostname. > > Remy - I'm not sure if this is correct, but I see no

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor.java CoyoteInterceptor2.java CoyoteProcessor.java CoyoteRequest.java CoyoteResponse.java Tomcat3Adapter.java Tomcat3Request.java Tomcat3Response.java

2002-04-09 Thread costin
costin 02/04/09 11:37:24 Modified:coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor.java CoyoteInterceptor2.java CoyoteProcessor.java CoyoteRequest.java CoyoteResponse.java Tomcat3Adapter.java

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters ChunkedInputFilter.java ChunkedOutputFilter.java IdentityInputFilter.java IdentityOutputFilter.java VoidInputFilter.java VoidOutputFilter.java

2002-04-09 Thread costin
costin 02/04/09 11:35:54 Modified:http11/src/java/org/apache/coyote/http11 InputFilter.java InternalInputBuffer.java InternalOutputBuffer.java OutputFilter.java http11/src/java/org/apache/coyote/http11/filters

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Larry Isaacs
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, April 09, 2002 3:11 PM > To: Tomcat Developers List > Subject: RE: cvs commit: jakarta-tomcat build.xml > > > I'll commit a fix. > > Larry, is it ok if we call the buildfile for j-t-c from 3.3'

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java InternalOutputBuffer.java

2002-04-09 Thread remm
remm02/04/09 11:21:23 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java InternalOutputBuffer.java Log: - Add some code to prevent problems when calling finish or commit twice. Revision ChangesPath 1.22 +3 -0 jak

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Request.java Response.java

2002-04-09 Thread costin
costin 02/04/09 11:19:27 Modified:coyote/src/java/org/apache/coyote Request.java Response.java Log: Add the second param in calling. The tomcat3 and 4 adapters are calling the request and response methods, it doesn't seem to be any other place to depend on this ( except the imp

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote InputBuffer.java OutputBuffer.java

2002-04-09 Thread costin
costin 02/04/09 11:15:21 Modified:coyote/src/java/org/apache/coyote InputBuffer.java OutputBuffer.java Log: Added a second parameter allowing IB and OB to be implemented stateless ( or statefull, depending on the rest of the code ) I'll add the extra

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costinm
I'll commit a fix. Larry, is it ok if we call the buildfile for j-t-c from 3.3's build.xml ? ( 4.0 is doing that too ). The problem is the order which may be tricky - tomcat33 depends on j-t-c utils and it will copy coyote. But coyote depens on tomcat33 beeing build, so it can find the classe

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread Remy Maucherat
> On Tue, 9 Apr 2002, Remy Maucherat wrote: > > > >public class CoyoteResponse > > > @@ -485,6 +485,7 @@ > > >throws IOException { > > >// Writing leftover bytes > > >outputBuffer.close(); > > > +coyoteResponse.finish(); > > >} > > > > Th

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote InputBuffer.java

2002-04-09 Thread Remy Maucherat
> costin 02/04/09 10:57:13 > > Modified:coyote/src/java/org/apache/coyote InputBuffer.java > Log: > Added (another) piece of comment ( after hunting for NPEs :-) > > The way InputBuffer is used is different from OutputBuffer - the param > is empty, the byte[]. The protocol is su

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java

2002-04-09 Thread costin
costin 02/04/09 11:02:19 Modified:coyote/src/java/org/apache/coyote/tomcat3 Tomcat3Request.java Log: Merged few more methods from ajp. Use the same buffer for addresses, pass the info to Coyote Request Revision ChangesPath 1.7 +56 -0

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread remm
remm02/04/09 10:59:42 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Modify Costin's patch: - In HTTP/1.1, we must default to the protocol's default (spec requirement); this was fixed recently (bug 6668) - In H

Re: tomcat native webdav

2002-04-09 Thread Szymon Stasik
it looks to be even worse for url-parrern: /webdav/* i've found: "PROPFIND /context/webdav HTTP/1.1" 207 1904 and "PROPFIND /context/webdav/aaa HTTP/1.1" 404 585 while webdav exists only in / of webapplication and there is also aaa directory inside the webdav (/webdav/aaa) regards, Szymon -- T

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote InputBuffer.java

2002-04-09 Thread costin
costin 02/04/09 10:57:13 Modified:coyote/src/java/org/apache/coyote InputBuffer.java Log: Added (another) piece of comment ( after hunting for NPEs :-) The way InputBuffer is used is different from OutputBuffer - the param is empty, the byte[]. The protocol is supposed to pr

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4CoyoteResponse.java

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Remy Maucherat wrote: > >public class CoyoteResponse > > @@ -485,6 +485,7 @@ > >throws IOException { > >// Writing leftover bytes > >outputBuffer.close(); > > +coyoteResponse.finish(); > >} > > This is called no matt

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java CoyoteConnector2.java

2002-04-09 Thread remm
remm02/04/09 10:47:07 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteConnector2.java Added: coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java Log: - Add a socket factory to allow configuring

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread Remy Maucherat
> costin 02/04/09 10:26:07 > > Modified:coyote/src/java/org/apache/coyote/tomcat4 > CoyoteResponse.java > Log: > Remy, I think response.finish() must be called - otherwise > we get no COMMIT callback. I put a workaround in ajp, but if this is > correct be

Re: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, April 09, 2002 10:14 AM Subject: Re: cvs commit: jakarta-tomcat build.xml > > On Tue, 9 Apr 2002, Larry Isaacs wrote: > > > > > The instructions for installing

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Larry Isaacs
> -Original Message- > From: Remy Maucherat [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, April 09, 2002 1:15 PM > To: Tomcat Developers List > Subject: Re: cvs commit: jakarta-tomcat build.xml > > > > On Tue, 9 Apr 2002, Larry Isaacs wrote: > > > > > The instructions for installing Coy

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Larry Isaacs
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, April 09, 2002 2:09 PM > To: Tomcat Developers List > Subject: RE: cvs commit: jakarta-tomcat build.xml > > > On Tue, 9 Apr 2002, Larry Isaacs wrote: > > > The instructions for installing Coyot

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-04-09 Thread costin
costin 02/04/09 10:26:07 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java Log: Remy, I think response.finish() must be called - otherwise we get no COMMIT callback. I put a workaround in ajp, but if this is correct behavior it's bet

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-04-09 Thread costin
costin 02/04/09 10:23:49 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: If host header is not set, use the local socket to set the local port and hostname. Remy - I'm not sure if this is correct, but I see no other way to

[SECURITY] Cross site scripting vulnerability revealed in 'examples' webapp of Apache Tomcat

2002-04-09 Thread Remy Maucherat
Cross Site scripting security vulnerabilities exist in the 'examples' web application which is distributed along with Apache Tomcat. This affects all released versions of Tomcat, including 3.x and 4.x. No other components of Tomcat are currently known to be vulnerable to cross site scripting. To

Re: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread Remy Maucherat
> On Tue, 9 Apr 2002, Larry Isaacs wrote: > > > The instructions for installing Coyote on Tomcat 3.3.x say to > > replace connectors_util.jar with j-t-c's tomcat-utils.jar. Since > > j-t-c tomcat-utils are a subset of tomcat-utils.jar from container/ > > Sorry, I didn't read the instructions for

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2002-04-09 Thread costin
costin 02/04/09 10:13:51 Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java Log: Implement the input buffer. Recycle the req/res ( coyote http adapter doesn't call recycle on coyoteRequest/coyoteResponse - which is actually a very good idea ). Add a workaround f

RE: cvs commit: jakarta-tomcat build.xml

2002-04-09 Thread costinm
On Tue, 9 Apr 2002, Larry Isaacs wrote: > The instructions for installing Coyote on Tomcat 3.3.x say to > replace connectors_util.jar with j-t-c's tomcat-utils.jar. Since j-t-c tomcat-utils are a subset of tomcat-utils.jar from container/ Sorry, I didn't read the instructions for Coyote - I'm

DO NOT REPLY [Bug 7880] New: - If a TLV flags flags an error during the translation phase, a fatal translation error is not returned (HTTP 500).

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Constants.java InputBuffer.java OutputBuffer.java

2002-04-09 Thread Remy Maucherat
> Ok, ok. I'll work around it. No need to. You didn't make your intentions known, and I assumed that you had in mind changes in the HTTP/1.1 connector, which I considered to be a bad idea. So since it's been cleared, +1 for adding Request and Response as a parameter to the methods in InputBuffer

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Jk2: removing the servlet and the http connector

2002-04-09 Thread costinm
Hi, As you noticed, we will use coyote for connector and avoid the duplication. There are few more things that need to be fixed, but it seems everything will actually work better. I still like the idea of packing the connector as a webapp and doing all config in web.xml - but having more comm

DO NOT REPLY [Bug 7873] - Null pointer renders servlet unusable with out tomcat restart

2002-04-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyoteConstants.java InputBuffer.java OutputBuffer.java

2002-04-09 Thread costinm
Ok, ok. I'll work around it. Costin On Tue, 9 Apr 2002, Remy Maucherat wrote: > > On Mon, 8 Apr 2002, Remy Maucherat wrote: > > > > > > > > I'd like those two to stay the way they are. They're not related to the > > > hooks or actions. I/O should be handled as a special case IMO; faster + > > >

  1   2   >