costin 01/03/06 23:56:21
Modified:src/share/org/apache/tomcat/core ContextManager.java
Log:
Other places where getContext() needs to be checked.
Revision ChangesPath
1.173 +22 -7
jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java
Index: Co
costin 01/03/06 23:13:27
Modified:src/share/org/apache/tomcat/core ContextManager.java
Log:
Small bug - for bad requests, the context is not set.
Revision ChangesPath
1.172 +9 -2
jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java
Index: C
I have noticed that any objects stored in a requests attributes
doesn't get finalized immediately after the completion of the request.
The attributes get cleared in RequestImpl.initRequest(), but the
resources aren't necessarily freed. I added a System.gc() after the
initRequest() call in Request
Title: RE: FW: problem w/ ajp13 - if Tomcat is shutdown
Here's exactly what I did to reproduce the problem.
Again, I'm running this on a Solaris 2.8 SunOS machine,
using JDK1.2.2, Apache 1.3.14, Tomcat 3.2.1.
1. Start Apache
2. Start Tomcat
3. Start hitting Apache with multiple requests, suc
>
>Sorry for the long message, but I'm a bit unclear on some Tag related
>spec details. I need to make sure I have a clear understanding before
>I start thinking about tag handler reuse implementation.
>
>
>My original understanding of Tag.release was that it was always called after
>a tag handl
I was running recently with that exact same configuration but did not
experience that problem. Can you show some config files.
-Andy
-Original Message-
From: Shinta Tjio
To: [EMAIL PROTECTED]
Cc: 'Dan Milstein'
Sent: 3/6/01 7:01 PM
Subject: RE: FW: problem w/ ajp13 - if Tomcat is shutd
There is one more problem that you should consider while you are looking at this
particular
code...
JasperMangler.java will generate incorrect class paths if you every have a number
after a
separator /.
It will try to generate package starting with a number, which (obviously) doesn't work
in ja
I got around this by just removing j_password and j_username from the sessionid.
HttpSession sessionid = request.getSession(false);
sessionid.removeValue("j_password");
sessionid.removeValue("j_username");
"Dunlop, Aaron" wrote:
I seem to be having a similar problem. My app also uses
session in
Title: RE: FW: problem w/ ajp13 - if Tomcat is shutdown
I am using Tomcat 3.2.1, Apache 1.3.14, running on
Solaris 2.8, Sun machines.
After various attempts of debugging this, I have
more information.
1. Even though I'm setting the worker's property
cache_size to default (1), I'm finding
Title: Re: TC3.3m1 Possible bug with session.invalidate
The place to look is
src/share/org/apache/tomcat/modules/session/SimpleSessionStore.java. Or,
better, get the latest version of this file since the bug was fixed about two
weeks ago.
- Original Message -
From:
Dunlop,
Title: Re: TC3.3m1 Possible bug with session.invalidate
I seem to be having a similar problem. My app also uses session information to track
logins, and calls session.invalidate() when a user logs out.
So far I'm seeing that if a user starts up a new browser, logs in, logs out, and attempts
Hi Costin,
I will be very interested to learn more about the ProfileLoader
and Tomcat 3.3 in general.
I hope to have more time to bang on TC3.3 and TC4.0 after
Enhydra Enterprise 4.0 is released.
Shawn
[EMAIL PROTECTED] wrote:
> Hi William,
>
> Regarding "multiple ContextManagers" - IMHO it shou
Hi Bill,
I would suggest grabbing the current Enhydra Enterprise source from CVS.
The ENHYDRA_4_0_B_1_BRANCH branch is the branch
for the beta release that is coming any day now.
There have been significant changes since alpha4.
If you are interested in how it is done look at the source in
EE/ser
larryi 01/03/06 13:35:47
Modified:src/share/org/apache/jasper/compiler JasperMangler.java
Log:
Update init() method to change '/' character to File.separatorChar in pkgDir
for Windows systems. Jasper doesn't work well under Jdk1.1 on Windows
if classDir contains '/' characters
larryi 01/03/06 13:31:05
Modified:src/examples/WEB-INF/classes Tag: tomcat_32
LocalStrings_en.properties
Log:
Add new strings for SessionExample servlet
Revision ChangesPath
No revision
No revision
larryi 01/03/06 13:29:48
Modified:src/examples/WEB-INF/classes LocalStrings.properties
LocalStrings_en.properties SessionExample.java
Log:
Port update to SessionExample servlet from tomcat_32 by Marc Saegesser
We now include some additional information
Hans Bergsten wrote:
>
> JSSI supports most of the NCSA SSI commands as well as the tag for
> invoking servlets. In addition, it implements a number of configurable settings,
> such as expiration time, buffering, (and server-side caching, I believe) etc.
When I started writing the SSI-servlet I
Hi there,
can you please confirm that mod_jk.dll is broken?
I have tried with Apache-1.3.19, Tomcat-3.2.1, as well as
with several post-1.3.19 snashots and last two nightly builds
of Tomcat.
mod_jk.dll is built without a single warning, but I get
"Error while opening the workers" during apac
Title: controlling the lifecycle of servlets ??
Running a website with more than 1.000 pages - each becoming a servlet by using a JSP-Template - we are facing the following problem:
The reserved JVM-memory (mx512m + ms512m on a 1280 MB W2k-Server) is running short very soon after about 30 - 4
Costin,
> If what you want to do is support virtual hosts - tomcat supports
> virtual hosts using a single ContextManager ( the contextManager is a
> representation for a "server" that may have multiple hosts).
I don't mind using virtual hosts, but they don't do what I'm looking for. I
have two
Casey Lucas wrote:
>
> Sorry for the long message, but I'm a bit unclear on some Tag related
> spec details. I need to make sure I have a clear understanding before
> I start thinking about tag handler reuse implementation.
> [...]
The JSP 1.1 spec is very confusing in this regard. I suggest yo
At 12:35 PM -0800 2001/03/06, [EMAIL PROTECTED] wrote:
>If what you want to do is support virtual hosts - tomcat supports
>virtual hosts using a single ContextManager ( the contextManager is a
>representation for a "server" that may have multiple hosts).
>
>There is no special representation for
Also, after some thought, why doesn't it default to the old
locations?
This will create some confusion, and it's not like mod_jk
needs any more.
Another problem is that the default is to root /. This
could really be a problem. I'd rather it die with an error
than put stuff in a really unexpect
Hi William,
Regarding "multiple ContextManagers" - IMHO it should be possible to do
that, but it's not a very tested feature.
If what you want to do is support virtual hosts - tomcat supports
virtual hosts using a single ContextManager ( the contextManager is a
representation for a "server" th
I've finally added a little key documentation to the C code in mod_jk. I
wanted to mention it here, because all the key information is, basically, in
one file:
jk_service.h
If anyone is looking into bug fixes on mod_jk, or just wants to understand
how it's working, I'd recommend starting with t
danmil 01/03/06 12:22:23
Modified:src/native/mod_jk/common jk_ajp13_worker.c
Log:
Fixed a few typos in some of the logging messages
Revision ChangesPath
1.5 +6 -6 jakarta-tomcat/src/native/mod_jk/common/jk_ajp13_worker.c
Index: jk_ajp13_worker.c
==
danmil 01/03/06 12:22:00
Modified:src/native/mod_jk/common jk_service.h
Log:
Extensive comments added to explain the structure of the core mod_jk
classes. Also explained how Shachor wrote object oriented code in C.
Revision ChangesPath
1.4 +196 -9jakarta-to
> Costin - were you going to make the changes
> (out.flush() -> out.flushBuffers()) in
> JspParseEventListener.generateFooter() and
> PageContextImpl.include() that we had discussed? I
> had thought that you implied you were going to do it
> (that was before I was a committer) but I just noticed
Shawn,
Could you point me more specifically at where Enhydra uses multiple
ContextManagers? I just downloaded EE 4.0a4 and couldn't find any files
that have examples of multiple ContextManagers on different ports serving
groups of apps. Whenever I try to use multiple ContextManagers on
My reading of the spec is that after calling Tag.release, the tag handler
could be safely put back into the pool. However calling Tag.release after
doEndTag isn't mandatory. If the compiler is smart enough, it may re-use a
tag without releasing it first if the second invocation uses a super-set o
I would like a copy of it. Could you send? Thanks,
Amy
Hans Bergsten wrote:
> Bip Thelin wrote:
> >
> > Here's an update of the SSI package I submitted a week ago. The "only" SSI
> > command that has been added is 'echo', example. .
> > [...]
>
> Sorry, I should have commented on this earlier
Hi Mel,
If you are interested in an approach to getting Tomcat to serve
apps on multiple ports, you might want to check out the
Enhydra Enterprise 4.0 source.
We create multiple ContextManagers, where each ContextManager
handles the group of apps running on a particular connection (port).
This is
I'll definitely have to look back in the archives. I've been looking at 3.3
recently and discovered that the issue seemed to be fixed there, which makes me
happy :)
Is there a list of known problems in the latest tc3.3 milestone? I may be able
to use this in our production systems, since our re
I'm having a problem using Bugzilla, and I'm hoping someone can point me
towards an easy solution.
When people post bug reports, they often include patches in the text of the
description (which is great). However, it's very difficult for me to get
those patches into a file so that I can run the
Larry,
I commited the changes to HttpServletResponseFacade that fix the problems
with determine when URLs should be rewritten and what session id to use. I
also beefed up the SessionExample servlet from the examples webapp to
display additional information and allow sessions to be invalidated.
What version of TC are you using? What version of Apache?
I would look into the mod_jk docs -- I think this is the spec'd behavior
(which, admittedly, is not great, but that makes it more of a feature
request than a bug ;-). With ajp13, Apache opens up a persistent TCP/IP
connection TC -- if TC
Stefan,
Thanks for looking into this, but this bug has already been fixed in the 32
branch under cvs. If you check out the most recent version of tomcat_32, or
if you download 3.2.2b1, you can see that jk_sockbuf.c has been cleaned up
(Brian Vetter contributed the patch).
Thanks, though,
-Dan
marcsaeg01/03/06 09:41:38
Modified:src/examples/WEB-INF/classes Tag: tomcat_32
LocalStrings.properties SessionExample.java
Log:
We now include some additional information about session handling, such
as whether the session is new, what the request session i
marcsaeg01/03/06 09:38:17
Modified:src/share/org/apache/tomcat/facade Tag: tomcat_32
HttpServletResponseFacade.java
Log:
This fixes some additional problems uncovered by the fix for
Bugzilla 160.
The isEncodable() method used isRequestedSessionIdValid(
OK. I noticed the change but didn't look at the latest source to
see what was up.
Let me know if I can help with the user docs.
I've started to work on additions/new docs for 3.3 and the web server
connection instructions.
Thanks,
Mike.
--
Mike Braden
-Original Message-
From: Mel Ma
> I'm not as
> familiar with the 3.3. code base but I'll try to port the patch.
Marc,
Don't feel you need to port the patch. I'll be glad to do that.
Thanks.
Larry
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional com
Title: FW: problem w/ ajp13 - if Tomcat is shutdown
I'm having problem with mod_jk if ajp13 is used.
The problem is often reproduced when Tomcat is shut
down without Apache being shut down. When a request
is fired through Apache as soon as Tomcat starts,
I often get Internal Server Error.
Sorry for the long message, but I'm a bit unclear on some Tag related
spec details. I need to make sure I have a clear understanding before
I start thinking about tag handler reuse implementation.
My original understanding of Tag.release was that it was always called after
a tag handler was us
Ethan,
You missed some good discussions on this two weeks ago
between Costin and myself! :-)
Not only is it (premature commit) caused by the
RequestDispatcher.include() calling flushBuffer() but
there are other out.flush() calls in jasper that
contribute to the problem.
I don't know if it will
There may be more to this. This fix uncovered other places that were using
the requested session id and assuming that it was really the active session
id. I'll be committing a fix for that problem later today. I'm not as
familiar with the 3.3. code base but I'll try to port the patch.
> -O
Hi Marc,
Does it look like a few days to come up with these patches?
If so, I would like to include any missing from Tomcat 3.3
in Milestone 2.
Thanks.
> -Original Message-
> From: Marc Saegesser [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, March 06, 2001 10:27 AM
> To: [EMAIL PROTECTED]
This should be fixed in the nightly builds of tc3.3.
As of last sunday, you should be able to explicitely
control the setting of all these paths in the
auto-generated files (and also where they get
generated to) using attributes of the element in server.xml. If you get build the
latest source,
--- Uijin Hong <[EMAIL PROTECTED]> wrote:
> Why don't you just run 2 servlet container(Tomcat)s
> for each port?
>
That could get memory expensive if you have to do this
for several ports.
The best performance scenario might be to use Apache
to listen to several ports and rewrite them to go to
larryi 01/03/06 08:07:45
Modified:src/facade22/org/apache/tomcat/facade
HttpServletRequestFacade.java
Log:
Port patch from tomcat_32 for part of Bugzilla Bug #160
The isRequestedSessionIdValid() should be based on the value of
getRequestedSessionId().
It looks like there have been some new changes to the Tomcat auto config
generator.
Now when you startup, TC3.3 says:
2001-03-06 10:18:48 - ApacheConfig: Generating apache mod_jserv config =
/conf/jserv/tomcat-apache.conf
2001-03-06 10:18:48 - ApacheConfig: Generating apache mod_jk config =
/con
After some further investigation into session ids and url rewritting I've
found more places in the Tomcat 3.2 code that are using the requested
session id as the active session id. I'm tracking down and fixes these now.
These code changes are beyond what I'm willing to accept, as a release
manag
Glenn Nielsen wrote:
> I committed the patch to catalina.sh, thanks Ulf!
>
> I'm not sure about the patch to ContextConfig.java,
> anyone else want to take a look at that?
>
I will take on the ContextConfig patch -- at first blush it looks like a correct patch
to deal with our
recent refactorin
Thanks Conor,
It was a double mistake - Sam set ant.home to a wrong value in gump and I
guessed wrong what was changed ( assuming the distribution layout
changed).
Tomcat doesn't depend on how ant build process works, only on the final
directory layout ( in the distrib ).
Meanwhile I updated a
Conor MacNeill wrote:
> Costin,
>
> > Is there any reasonable explanation for changing the ant structure ( i.e.
> > removing ant/bin ) ? Besides breaking backward compatibility and forcing
> > people to change their scripts ?
> >
>
> We like you to change your scripts on a regular basis to stop t
I committed the patch to catalina.sh, thanks Ulf!
I'm not sure about the patch to ContextConfig.java,
anyone else want to take a look at that?
Regards,
Glenn
Ulf Jaehrig wrote:
>
> Hi,
>
> today I experimented with the Catalina Embedded.class. I first try to
> start it with "catalina.sh embe
glenn 01/03/06 06:13:51
Modified:catalina/src/bin catalina.sh
Log:
Fix embedded startup classpath, contributed by Ulf Jaehrig
Revision ChangesPath
1.14 +5 -2 jakarta-tomcat-4.0/catalina/src/bin/catalina.sh
Index: catalina.sh
===
Hi,
today I experimented with the Catalina Embedded.class. I first try to
start it with "catalina.sh embedded" failed, so I tried to get it run.
After these changes it started. Maybe these are of interest...
The change in the catalina.sh adds the jar files in server/lib and
common/lib to the emb
Costin,
> Is there any reasonable explanation for changing the ant structure ( i.e.
> removing ant/bin ) ? Besides breaking backward compatibility and forcing
> people to change their scripts ?
>
We like you to change your scripts on a regular basis to stop them getting
stale :-)
Seriously Ant'
Why don't you just run 2 servlet container(Tomcat)s for each port?
-Original Message-
From: William Wishon [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, March 06, 2001 9:27 AM
To: [EMAIL PROTECTED]
Subject: Assigning Servlets to different ports.
Hi,
An example of what I'm trying to do is
These changes fixes the following problem:
When using ajp12 with mod_jk, httpd procesess handling a request
will hang, using all cpu time, if tomcat is shut down before the headers
of the request have been sent from tomcat.
BR,
Stefan Åberg
***
/usr/local/src/apache/jakarta-tomcat-3.2.1-src/sr
60 matches
Mail list logo
