Re: patch adding -c flag to new-session

2013-08-21 Thread J Raynor
There are some conditions I don't know how to generate, so I couldn't test those. But I tried testing what I could, and it appears that this preserves the behavior of neww and split-window, and that the prefixes for "new -c" match the -c behavior for neww and split-window. Does cmd_default_path1

Re: patch adding -c flag to new-session

2013-08-21 Thread Nicholas Marriott
On Wed, Aug 21, 2013 at 04:26:41PM -0500, J Raynor wrote: > There are some conditions I don't know how to generate, so I couldn't > test those. But I tried testing what I could, and it appears that > this preserves the behavior of neww and split-window, and that the > prefixes for "new -c" match t

Re: patch adding -c flag to new-session

2013-08-21 Thread Nicholas Marriott
Maybe this which includes your default-path change in a slightly different form and renames the functions to cmd_default_path and cmdq_default_path. diff --git a/cmd-new-session.c b/cmd-new-session.c index 4eebe63..80829f0 100644 --- a/cmd-new-session.c +++ b/cmd-new-session.c @@ -35,9 +35,10 @@ e

Re: Support showenv output as shell code

2013-08-21 Thread Nicholas Marriott
Hi I'm happy to have unambiguous output but I think we should only have one style. So better to change the existing format to be unambiguous, if possible in a way that is fairly backwards compatible and can easily be changed into sh form using sed. On Sun, Aug 18, 2013 at 11:01:39AM -0400, Aaro

Re: patch adding -c flag to new-session

2013-08-21 Thread J Raynor
This looks fine too, except it looks like the unreachable "return (base);" is still there. Also, the comment above cmd_default_path() mentions using the default-path option, but that's now taken care of elsewhere. So that might need an update.