Re: bug with mode-mouse on

2013-03-05 Thread Georgios Choudalakis
Sure, I did it again, this time I clicked only once. Initially the lower pane was selected. I clicked on the right side of the screen, within the upper pane. Instead of moving focus to the upper pane, I heard a beep, and the following text appeared on the lower prompt: " 6#6" (without the quotes).

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Thiago Padilha
Any chance this patch will be accepted? I still need to tweak a few things: - Detect when a waiting pane exits and remove it from the queue/monitor - Move the queue shifting to the event loop - Handle SIGINT in the tmux client(Not sure about this one) I didn't manage to implement those myself,

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Nicholas Marriott
I haven't had a lot of time to spend on this but: I don't understand why you are doing anything with panes. What have panes got to do with it? This only needs to worry about clients. Panes can't wait for anything. Also we will need to change the name, I don't like "monitor", but we can worry abou

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Nicholas Marriott
I think this could be much simpler - to give you an idea, this is the kind of thing I had in mind, but instead of just one saved cmdq having a tree of wait channels each with a list of cmdq attached. Locking can be implemented very similarly and perhaps even using the same data structures as neede

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Thiago Padilha
I'm not always sure about the meaning of client in tmux, but what needs to hold the lock is not the tmux command that connects to the server, but the process that is connected to the pseudo tty that is displayed by the tmux pane(normally this will be a shell), that is why I used panes to reference

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Nicholas Marriott
On Tue, Mar 05, 2013 at 10:30:07AM -0300, Thiago Padilha wrote: >I'm not always sure about the meaning of client in tmux, but what needs to >hold the lock is not the tmux command that connects to the server, but the >process that is connected to the pseudo tty that is displayed by the t

Broken new lines when copying screen output

2013-03-05 Thread David Abdurachmanov
Hi, When I am copying data from terminal screen from tmux I get new lines broken (disappeared) on a some lines. It happens from time to time. Any ideas why it's happening and how to fix it? Examples provided below. Cheers, david ### Example (copy & paste w/o tmux) ### diff --git a/src/XrdApp

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Thiago Padilha
Ok, I your idea is simpler and it should work. mine was just a proof of concept actually. I would like to get this on the next version(already using on my scripts) but I'm kinda busy to reimplement right now so I will probably do it on weekend. Do you any idea when you will freeze tmux 1.8 feature

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Nicholas Marriott
On Tue, Mar 05, 2013 at 11:20:54AM -0300, Thiago Padilha wrote: > Ok, I your idea is simpler and it should work. mine was just a proof > of concept actually. I suggest you extend my code to add the tree+queues and then I will apply it and then we can add locks. Or you can do both but send them as

Re: Broken new lines when copying screen output

2013-03-05 Thread Nicholas Marriott
Hi Are you copying and pasting using tmux's copy mode? On Tue, Mar 05, 2013 at 03:17:57PM +0100, David Abdurachmanov wrote: > Hi, > > When I am copying data from terminal screen from tmux I get new lines broken > (disappeared) on a some lines. It happens from time to time. Any ideas why > it

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Thiago Padilha
Ok, this week I will implement it About the command, do you prefer two separate commands for locking/unlocking and waiting signaling? What name(s)/parameters should the commands have? Should I use a separate file for defining the tree/global variables(like I did with the monitor.c file) I think

Re: [PATCH] Implementation of the 'monitor' command

2013-03-05 Thread Nicholas Marriott
On Tue, Mar 05, 2013 at 12:10:57PM -0300, Thiago Padilha wrote: > Ok, this week I will implement it > > About the command, do you prefer two separate commands for > locking/unlocking and waiting signaling? What name(s)/parameters > should the commands have? Should I use a separate file for defini

Re: bug with mode-mouse on

2013-03-05 Thread Nicholas Marriott
Ok good to hear. You should not need -u if your LANG or LC_ALL is set to a locale with UTF-8 in it. Also you should not use -2 if you use TERM set to xterm-256color instead of xterm. But there is no harm in using the flags -2u if not. On Tue, Mar 05, 2013 at 10:46:59AM -0500, Georgios Choudala

Re: [PATCH] Make last-pane unzoom window

2013-03-05 Thread Nicholas Marriott
Applied, thanks. On Tue, Mar 05, 2013 at 06:55:59PM +0100, Romain Francoise wrote: > I was testing the new zoom feature and found that last-pane doesn't unzoom > the window although it's a frequently used command that would seem a > natural fit for unzooming. > > Also, fix a typo in the descri

[PATCH] Make last-pane unzoom window

2013-03-05 Thread Romain Francoise
I was testing the new zoom feature and found that last-pane doesn't unzoom the window although it's a frequently used command that would seem a natural fit for unzooming. Also, fix a typo in the description. Thanks, diff --git a/cmd-select-pane.c b/cmd-select-pane.c index d24d7b3..b8a1267 100644

[PATCH] Plug format_window_pane() leak

2013-03-05 Thread Romain Francoise
Commit 1db4ec6e63 added a new pane_current_command format using osdep_get_name(), which allocates. So we need to free the result after using it. Thanks, diff --git a/format.c b/format.c index ad52cae..b71 100644 --- a/format.c +++ b/format.c @@ -398,7 +398,8 @@ format_window_pane(struct forma

Re: [PATCH] Plug format_window_pane() leak

2013-03-05 Thread Nicholas Marriott
Fixed, thanks. On Tue, Mar 05, 2013 at 08:51:36PM +0100, Romain Francoise wrote: > Commit 1db4ec6e63 added a new pane_current_command format using > osdep_get_name(), which allocates. So we need to free the result > after using it. > > Thanks, > > diff --git a/format.c b/format.c > index ad52ca

[PATCH] Pass valid pointer to grid_string_cells or it segfaults

2013-03-05 Thread eugene everson
Reproducible with :find-window .. (f) --- grid-view.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grid-view.c b/grid-view.c index 7ef443a..c639b2a 100644 --- a/grid-view.c +++ b/grid-view.c @@ -229,10 +229,12 @@ grid_view_delete_cells(struct grid *gd, u_int px, u_int

[PATCH] Implement 'wait-for' command

2013-03-05 Thread Thiago Padilha
Here it goes: The first patch implements wait/signal, the second extends it with lock/unlock. My goal this time was to make the code small and simple as possible, let me know if you think anything needs to be refactored. --- Makefile.am | 1 + cmd-wait-for.c| 145 +