Re: [PATCH] Fix default client template

2012-05-28 Thread Nicholas Marriott
I don't know if you are offended but you sound a bit like it and there is no need, this thread is not a criticism of your work. The default changed, it makes the code better but it doesn't seem as usable... so what? It happens to everyone. And I don't think it's bikeshedding, the layout is a fairly

Re: [PATCH] Fix default client template

2012-05-28 Thread Thomas Adam
On Mon, May 28, 2012 at 08:29:40AM +0100, Nicholas Marriott wrote: > I don't know if you are offended but you sound a bit like it and there > is no need, this thread is not a criticism of your work. The default Gosh, no, I'm not offended. I care though that whilst some changes might affect more u

Re: [PATCH] Fix default client template

2012-05-28 Thread Romain Francoise
Nicholas Marriott writes: > If it makes things significantly simpler to have one define, I think I > would consider trimming bits from list-windows and force people to add > them back with -F rather than adding them to choose-windows. Can we at least have this? (Note: includes the fix previously

Re: [PATCH] Fix default client template

2012-05-28 Thread Romain Francoise
Thomas Adam writes: > I suppose the wider point is that you're not going to please everybody, > and that despite the change -- and that people are free to change it -- > might seem like too much of a change for people who now have to edit > their configuration files, etc. Changing the default te

Re: zsh double star (**) in tmux command string does not match

2012-05-28 Thread Dennis Günnewig
Hi, it seems to work as expected. 1. Test 1 #terminal_1 % pkill tmux # set SHELL to a defined value different from user shell (zsh) % export SHELL=/bin/sh # no .tmux.conf # fine! % ls -al ~/.tmux.conf ls: cannot access /home/user/.tmux.conf: No such file or directory # terminal_1 % tmux new-se

[PATCH] client: defer reading stdin until requested

2012-05-28 Thread Chris Johnsen
OpenBSD patchset 1114 (pass stdin/stdout/stderr buffers, not fds) made the clients a bit too eager to read stdin. Defer reading from stdin (and sending buffers to an indifferent server via MSG_STDIN) until the server explicitly requests such processing. Without something like this, pasting a serie

[PATCH 2/2] kill-window -a: use safe traversal

2012-05-28 Thread Chris Johnsen
Since we will be removing the winlinks as we process them, it is important to use RB_FOREACH_SAFE (now that it is available) to make sure that the traversal is not affected by removing the current winlink. --- Example: Without the "safe" traversal, some winlinks may not be removed: tmux -L

[PATCH 1/2] kill-window -a: use session from -t

2012-05-28 Thread Chris Johnsen
Let the found winlink determine the session used when handling the 'a' option. This fixes several problematic scenarios: * Command from command line: curclient would be NULL, which would crash the server. * Specifying a window in another session: would have killed all the windows in the curre

Re: [PATCH 1/2] kill-window -a: use session from -t

2012-05-28 Thread Thomas Adam
Hi, On 29 May 2012 06:08, Chris Johnsen wrote: > Let the found winlink determine the session used when handling the > 'a' option. This fixes several problematic scenarios: > > * Command from command line: curclient would be NULL, which would >  crash the server. Yeah, we had this with "move-wind