Re: Some small Patches...

2012-03-20 Thread Nicholas Marriott
Hi Ok the mouse wheel scrolling patch works ok but if you scroll up with mode-mouse on it enters copy mode. Maybe the emulation should ONLY work with shift/alt/ctrl not with no key at all? What do you think? Also I think the amount it scrolls should be the same as copy mode - they should use the

Re: Some small Patches...

2012-03-20 Thread Nicholas Marriott
Here's tweaked version of your border marks diff. However, I'd be interested to know what ACS , . + - show on your terminal because here they just show themselves which looks a bit silly. What are you expecting to appear? On Sat, Mar 17, 2012 at 04:22:25PM +0100, marcel partap wrote: > Hi there

Re: Some small Patches...

2012-03-20 Thread Nicholas Marriott
Whoops this time with the diff Index: screen-redraw.c === RCS file: /cvs/src/usr.bin/tmux/screen-redraw.c,v retrieving revision 1.21 diff -u -p -r1.21 screen-redraw.c --- screen-redraw.c 29 Jan 2012 09:37:02 - 1.21 +++ sc

[patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Jonathan Daugherty
> But that's four diffs... just -T -N -C would be ok but if you do one > -T flag I think we should have all three. Please see the attached patch, which adds -T, -C, and -N options for find-window and defaults to -TCN as discussed. I've also updated tmux.1. -- Jonathan Daugherty Software Eng

Re: [patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Nicholas Marriott
Applied with some fairly unimportant style changes, thanks. On Tue, Mar 20, 2012 at 09:15:18AM -0700, Jonathan Daugherty wrote: > > But that's four diffs... just -T -N -C would be ok but if you do one > > -T flag I think we should have all three. > > Please see the attached patch, which adds -T

Re: [patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Jonathan Daugherty
> Applied with some fairly unimportant style changes, thanks. Thanks! I just realized that there is a stale comment in my patch which made it into yours: a comment mentions 'match_title' but that variable was from a previous version that didn't make it into my final patch. Whoops. -- Jonatha

Re: [patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Nicholas Marriott
Hi I just removed the comment entirely, I think it's clear enough what the code is doing. Cheers On Tue, Mar 20, 2012 at 12:07:30PM -0700, Jonathan Daugherty wrote: > > Applied with some fairly unimportant style changes, thanks. > > Thanks! I just realized that there is a stale comment in my