Re: tmux hangs on aix

2014-09-22 Thread J Raynor
The patch compiles, but part of the change you made reintroduces the race condition. The parent process has to close the slave before closing the write pipe. -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analy

Re: tmux hangs on aix

2014-09-22 Thread Nicholas Marriott
Forgot to do git push sorry should be there now Original message From: J Raynor Date: 22/09/2014 19:19 (GMT+00:00) To: Nicholas Marriott Cc: tmux-users@lists.sourceforge.net Subject: Re: tmux hangs on aix > Applied with some trivial style nits, check it still bui

Re: tmux hangs on aix

2014-09-22 Thread J Raynor
> Applied with some trivial style nits, check it still builds please :-). I don't see any update in the git repository. How long after you apply a change does it take before showing up in git? -- Meet PCI DSS 3.0 Complia

Re: tmux hangs on aix

2014-09-22 Thread Nicholas Marriott
Applied with some trivial style nits, check it still builds please :-). Thanks! On Mon, Sep 22, 2014 at 01:07:16AM -0500, J Raynor wrote: > > I think you should probably loop for EINTR from read() but otherwise > > this looks fine to me. > > I've attached an updated patch. > diff --git a/compa

Re: tmux hangs on aix

2014-09-21 Thread J Raynor
> I think you should probably loop for EINTR from read() but otherwise > this looks fine to me. I've attached an updated patch. diff --git a/compat/forkpty-aix.c b/compat/forkpty-aix.c index db9c2e7..98119f0 100644 --- a/compat/forkpty-aix.c +++ b/compat/forkpty-aix.c @@ -23,16 +23,20 @@ #include

Re: tmux hangs on aix

2014-09-20 Thread Nicholas Marriott
Hi I think you should probably loop for EINTR from read() but otherwise this looks fine to me. On Thu, Sep 18, 2014 at 07:51:37PM -0500, J Raynor wrote: > Tmux is hanging on aix, and the problem appears to be a race condition > in the implementation of forkpty. > > Aix has the behavior that, if

tmux hangs on aix

2014-09-18 Thread J Raynor
Tmux is hanging on aix, and the problem appears to be a race condition in the implementation of forkpty. Aix has the behavior that, if data has been written to the slave side of a pty but has not been read yet by the master side, then the last close of the slave pty will hang until the data is rea